View Single Post
Old 9th June 2018, 21:26   #14  |  Link
Stereodude
Registered User
 
Join Date: Dec 2002
Location: Region 0
Posts: 1,436
Quote:
Originally Posted by pinterf View Post
Good catch, I could reproduce the leak. It's there even at 8 bits but the internal lookup table for 16 bit is 128k, so it eats your memory faster.
EDIT: leak stopped
EDIT: conditional=true supported, like in colorYUV
EDIT: works now with 32 bit float (but no 'dither', and no 'analyze')
EDIT: check Avs+ r2700 test build
I confirm the leak is fixed.

IMHO, RGBAdjust is still missing at least one argument. Some sort of bit depth or scaling argument that can be used to scale the values in the file for the bias values. The ability to apply a formula would be useful too.

When using ScriptClip I can do this:

Code:
ScriptClip(source, "
RGBAdjust(rb=(xyx_b*256), gb=(xyx_b*256), bb=(xyx_b*256), r=(1-xyx_b/256), g=(1-xyx_b/256), b=(1-xyx_b/256))
")
ConditionalReader("levels_t.txt", "xyx_b", false)
Even using the new conditional = true argument there's no way to do something equivalent like:
Code:
RGBAdjust(source, conditional=true
ConditionalReader(("levels_t.txt"*256), "rgbadjust_rb", false)
ConditionalReader(("levels_t.txt"*256), "rgbadjust_gb", false)
ConditionalReader(("levels_t.txt"*256), "rgbadjust_bb", false)
ConditionalReader((1-"levels_t.txt"/256), "rgbadjust_r", false)
ConditionalReader((1-"levels_t.txt"/256), "rgbadjust_g", false)
ConditionalReader((1-"levels_t.txt"/256), "rgbadjust_b", false)
Stereodude is offline   Reply With Quote