Thread: VirtualDub2
View Single Post
Old 23rd May 2017, 09:55   #268  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,316
SDK evolution suggestion.

I'm still using "standard" SDK, didn't make the leap to use yours yet (but intend to in a not too far future), but i've made a small change, maybe you can do the same in your next release.

The VDXVideoFilter class offers a "constructor" with the Init function, but doesn't offer a "destructor".
So, i've added a DeInit function (because i needed it).

The following change in the code are:

VideoFilter.h
Code:
	virtual bool Init();
	virtual void DeInit();
	virtual uint32 GetParams()=0;
VideoFilter.cpp
Code:
bool VDXVideoFilter::Init() {
	return true;
}

void VDXVideoFilter::DeInit() {
}

void VDXVideoFilter::Start() {
}
....

void __cdecl VDXVideoFilter::FilterDeinit   (VDXFilterActivation *fa, const VDXFilterFunctions *ff) {
	VDXVideoFilter *pThis = *reinterpret_cast<VDXVideoFilter **>(fa->filter_data);

	pThis->fa=fa;
	pThis->DeInit();
	pThis->~VDXVideoFilter();
}
Do you think it's something you can add in your next release ?
jpsdr is offline   Reply With Quote