Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Capturing and Editing Video > VapourSynth

Reply
 
Thread Tools Search this Thread Display Modes
Old 21st October 2019, 10:30   #501  |  Link
Myrsloik
Professional Code Monkey
 
Myrsloik's Avatar
 
Join Date: Jun 2003
Location: Ikea Chair
Posts: 2,080
Quote:
Originally Posted by ChaosKing View Post
And if it helps. The problem is produced somewhere in contrahsrapening and not smdegrain: https://github.com/HomeOfVapourSynth...sfunc.py#L5406
It's a short script and the pink border still happens if you remove miniblur.

When I remove the only Expr line, the stripes disappear but the pink border is still there. Border could be Repair or MakeDiff. Will test later more.


EDIT
should this produce a pink image?
Code:
clip = core.std.BlankClip(width=200,height=100, format=vs.YUV420P8)
matrix1 = [1, 2, 1, 2, 4, 2, 1, 2, 1]
con = core.std.Convolution(clip, matrix=matrix1)

clip=core.std.MakeDiff(clip, con)
I've narrowed down the green lines. They happen with expr and 16 bit formats in the sse2 code path.

The script you posted definitely shouldn't be pink. For some odd reason it's not pink on my computer which should use exactly the same code path (threadripper 1950x).
__________________
VapourSynth - proving that scripting languages and video processing isn't dead yet
Myrsloik is offline   Reply With Quote
Old 21st October 2019, 13:36   #502  |  Link
Are_
Registered User
 
Join Date: Jun 2012
Location: Ibiza, Spain
Posts: 294
AMD Ryzen 7 1700 here and no pink image, only the green strips bug.
Are_ is offline   Reply With Quote
Old 21st October 2019, 14:02   #503  |  Link
ChaosKing
Registered User
 
Join Date: Dec 2005
Location: Germany
Posts: 1,056
I tested now with the portable version and it only shows the green stripes. It seems I had still 48-test2 installed,.. I was sure it was the RC edition, sry
Installing the RC removed the pink border

At least my incompetence has found another bug
__________________
AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth
VapourSynth Portable FATPACK || VapourSynth Database || https://github.com/avisynth-repository

Last edited by ChaosKing; 21st October 2019 at 14:06.
ChaosKing is offline   Reply With Quote
Old 22nd October 2019, 22:37   #504  |  Link
ChaosKing
Registered User
 
Join Date: Dec 2005
Location: Germany
Posts: 1,056
Is it possible to port also FineDehalo_contrasharp? It returns a nice sharp image.


Code:
avs+ version
# level == 1.0 : normal contrasharp
Function FineDehalo_contrasharp (clip dehaloed, clip src, float level)
{
	bb  = dehaloed.RemoveGrain (11, -1)
	bb2 = bb.Repair (bb.Repair (bb.Medianblur (2, -256, -256), 1), 1)
	xd  = mt_makediff (bb, bb2)
	xd  = VersionNumber() < 2.6 ? xd.mt_lut ("x 128 - 2.49 * "+String(level)+" * 128 +")
              \                     : xd.mt_lut ("x range_half - 2.49 * "+String(level)+" * range_half +")
	xdd = mt_lutxy (
\		xd,
\		mt_makediff (src, dehaloed),
\		VersionNumber() < 2.6 ? "x 128 - y 128 - * 0 < 128 x 128 - abs y 128 - abs < x y ? ?"
\		                      : "x range_half - y range_half - * 0 < range_half x range_half - abs y range_half - abs < x y ? ?"
\	)

	dehaloed.mt_adddiff (xdd, y=3, u=2, v=2)
}
Code:
Function FineDehalo_contrasharp (clip dehaloed, clip src, float level)
{
	bb  = dehaloed.RemoveGrain (11, -1)
	bb2 = bb.Repair (bb.Repair (bb.Medianblur (2, -256, -256), 1), 1)
	xd  = mt_makediff (bb, bb2)
	xd  = xd.mt_lut ("x 128 - 2.49 * "+String(level)+" * 128 +")
	xdd = mt_lutxy (
\		xd,
\		mt_makediff (src, dehaloed),
\		"x 128 - y 128 - * 0 < 128 x 128 - abs y 128 - abs < x y ? ?"
\	)

	dehaloed.mt_adddiff (xdd, y=3, u=2, v=2)
}
__________________
AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth
VapourSynth Portable FATPACK || VapourSynth Database || https://github.com/avisynth-repository

Last edited by ChaosKing; 22nd October 2019 at 23:03.
ChaosKing is offline   Reply With Quote
Old 23rd October 2019, 04:40   #505  |  Link
HolyWu
Registered User
 
HolyWu's Avatar
 
Join Date: Aug 2006
Location: Taiwan
Posts: 698
Quote:
Originally Posted by ChaosKing View Post
Is it possible to port also FineDehalo_contrasharp? It returns a nice sharp image.
Doesn't FineDehalo already have a contra parameter for contrasharpening?
HolyWu is offline   Reply With Quote
Old 23rd October 2019, 10:28   #506  |  Link
ChaosKing
Registered User
 
Join Date: Dec 2005
Location: Germany
Posts: 1,056
lol I never noticed xD
But an external "dehalo contrasharp" is still usefull. It can be used with other dehalo functions.
__________________
AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth
VapourSynth Portable FATPACK || VapourSynth Database || https://github.com/avisynth-repository
ChaosKing is offline   Reply With Quote
Old 23rd October 2019, 10:45   #507  |  Link
HolyWu
Registered User
 
HolyWu's Avatar
 
Join Date: Aug 2006
Location: Taiwan
Posts: 698
Quote:
Originally Posted by ChaosKing View Post
But an external "dehalo contrasharp" is still usefull. It can be used with other dehalo functions.
I'd like to know how is the result compared to Didée's ContraSharpening function. Is it only suitable for denoising but not the others?
HolyWu is offline   Reply With Quote
Old 23rd October 2019, 11:08   #508  |  Link
ChaosKing
Registered User
 
Join Date: Dec 2005
Location: Germany
Posts: 1,056
ContraSharpening adds halos back. It seems it is only usefull for denoised clips.
__________________
AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth
VapourSynth Portable FATPACK || VapourSynth Database || https://github.com/avisynth-repository
ChaosKing is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 03:53.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.