Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > General > Subtitles

Reply
 
Thread Tools Search this Thread Display Modes
Old 14th July 2014, 18:01   #201  |  Link
von Suppé
Registered User
 
von Suppé's Avatar
 
Join Date: Dec 2013
Posts: 266
I'm gonna try this out too, sounds promising.

Quote:
Originally Posted by Music Fan View Post
Yes, you rule !
But there is a minor problem : curiously, when I open the sup with modified timecodes (thus after having imported new time codes and exported in Blu-ray sup), the timecodes are all displayed 44 ms sooner than those in the srt used as new time codes.
For example, if the time code of the first line of the good srt is ;
1
00:00:07,921 --> 00:00:12,241
I get this in the corrected sup ;
1
00:00:07,877 --> 00:00:12,197

But as I can change srt's timecode easily with SE to compensate this little change, that's not a big problem.
Or, after importing the new timecodes, you could also change all their in/outs manually

Last edited by von Suppé; 14th July 2014 at 18:17.
von Suppé is offline   Reply With Quote
Old 14th July 2014, 21:32   #202  |  Link
Betsy25
Registered User
 
Join Date: Sep 2008
Location: Holland, Belgium
Posts: 330
The "Fix common OCR errors" is a bit too greedy, for example in the example below, it will propose to replace "for" with "For", however this should not be the case.

Any idea how to make the method stay away from automatically capitalizing the new subtitle line when the previous one ended with some "end of sentence" string ? There are quite a lot of "false positives" by default.

Code:
43
00:08:07,379 --> 00:08:11,033
I warned their president...
- Say it John, Say it !

44
00:08:11,133 --> 00:08:13,173
for doing business with them.

Last edited by Betsy25; 15th July 2014 at 04:41.
Betsy25 is offline   Reply With Quote
Old 14th July 2014, 23:21   #203  |  Link
von Suppé
Registered User
 
von Suppé's Avatar
 
Join Date: Dec 2013
Posts: 266
Nikse555, is it possible to add this to the "Fix common error tools":

If there are 2 lines, and both begin with a dash, being able to remove the dash (and the following space, if it's there) in the first line?
This would be as opposite of the tool "Fix (add dash) line pairs with only one dash (-)"
Maybe call it "Fix (remove first dash) line pairs with two dashes" or something?

Example:

- Hi, how are you?
- I'm fine, thanks.


-->

Hi, how are you?
- I'm fine, thanks.


Thanks for your hard work
von Suppé is offline   Reply With Quote
Old 16th July 2014, 21:28   #204  |  Link
Betsy25
Registered User
 
Join Date: Sep 2008
Location: Holland, Belgium
Posts: 330
Proposition for the "Fix Unneeded Spaces" :

In case of <somestring><DASH><space><nextstring>, when <nextstring> is "and" or "or", do not remove the <space>.
("en" or "of" in Dutch)

Examples :

(English)
Code:
What are your long- and altitude stats ?
There is an X- and a Y-chromosome.
Did you buy that first- or second-handed ?
(Dutch)
Code:
Wat zijn je voor- en familienaam ?
Was het in het voor- of najaar ?
I've commited some brewing on my github that probably is far below your coding standards, but perhaps you can refine it.

Last edited by Betsy25; 3rd August 2014 at 19:44. Reason: Added some more info & link
Betsy25 is offline   Reply With Quote
Old 21st July 2014, 08:53   #205  |  Link
Ghitulescu
Registered User
 
Ghitulescu's Avatar
 
Join Date: Mar 2009
Location: Germany
Posts: 5,635
Quote:
Originally Posted by von Suppé View Post
If there are 2 lines, and both begin with a dash, being able to remove the dash (and the following space, if it's there) in the first line?
This would be as opposite of the tool "Fix (add dash) line pairs with only one dash (-)"
Maybe call it "Fix (remove first dash) line pairs with two dashes" or something?

Example:

- Hi, how are you?
- I'm fine, thanks.


-->

Hi, how are you?
- I'm fine, thanks.
)
Why would be this a correct formatting?
Yes, I've seen this also on commercial movies, but I still have no explanation why one line is treated differently than the other one, although both are dialogues ...
__________________
Born in the USB (not USA)
Ghitulescu is offline   Reply With Quote
Old 21st July 2014, 21:34   #206  |  Link
von Suppé
Registered User
 
von Suppé's Avatar
 
Join Date: Dec 2013
Posts: 266
I'm not saying it's correct formatting, if there is any. I and many people just like it this way and find the first line dash not necessary.
I myself do a lot of manual subtitling and there's a lot of feel to it, which I find more important than correct formatting or not. A first dash disturbs my feel to the text in most cases.
von Suppé is offline   Reply With Quote
Old 21st July 2014, 22:55   #207  |  Link
Betsy25
Registered User
 
Join Date: Sep 2008
Location: Holland, Belgium
Posts: 330
Quote:
Originally Posted by von Suppé View Post
I'm not saying it's correct formatting, if there is any. I and many people just like it this way and find the first line dash not necessary.
I myself do a lot of manual subtitling and there's a lot of feel to it, which I find more important than correct formatting or not. A first dash disturbs my feel to the text in most cases.
the - normally "tells" the viewer that a different person than the one who told the last line is now speaking, so it's perfectly normal to have both lines beginning with - in that case. (at least, that's the way I understand it)

Last edited by Betsy25; 21st July 2014 at 22:58.
Betsy25 is offline   Reply With Quote
Old 22nd July 2014, 08:54   #208  |  Link
von Suppé
Registered User
 
von Suppé's Avatar
 
Join Date: Dec 2013
Posts: 266
Yes, I know what you mean.
If one would consist in that way, in every new subtitle display where the speaker of the first line is another than the last one in the previous subtitle display, how many cases would you have to start with a dash to tell the viewer this? It feels unnatural to me to do so.

Example:

Display 1:

Son, as I don't have much time today,
will you do me a favor and wash the car?

Display 2 would have to be like this:

- I will in the afternoon dad, because
I promised mom to fix her computer first.


Or similar things. Doesn't feel right. But everybody should of course do as they see or feel fit.
von Suppé is offline   Reply With Quote
Old 22nd July 2014, 14:07   #209  |  Link
TheSkiller
Registered User
 
Join Date: Dec 2007
Location: Germany
Posts: 637
I agree with von Suppé.
Whenever I'm creating subtitles myself I put the dash (which in my humble opinion should always be a so called "em dash" , not a "hyphen" - ) in front of the second line, in other words exactly where the change of the speaker happens within the same subtitle.
I also think it's easier to follow such a subtitle if both lines are left-aligend but as a whole the subtitle should of course be centered within the video frame, with the top line not starting before the em dash of the bottom line.


(click to enlarge)

That's what I personally consider "most aesthetic" and easiest to read.



I'm quite sure the main reason for putting a dash in front of both lines is rather just a technical shortcoming because it is easier to format this way. But of course it also depends on what the viewer is expecting and used to.

Last edited by TheSkiller; 22nd July 2014 at 14:10.
TheSkiller is offline   Reply With Quote
Old 23rd July 2014, 09:10   #210  |  Link
mood
Registered User
 
Join Date: May 2012
Posts: 83
@Nikse

It is possible add boxing options to context menu???
mood is offline   Reply With Quote
Old 24th July 2014, 10:26   #211  |  Link
von Suppé
Registered User
 
von Suppé's Avatar
 
Join Date: Dec 2013
Posts: 266
@ mood

Can you tell me what "boxing" is?
von Suppé is offline   Reply With Quote
Old 26th July 2014, 02:42   #212  |  Link
mood
Registered User
 
Join Date: May 2012
Posts: 83
@von Suppé

is in version 3.4 change log.

boxing is this:




you can add tags manually (<BoxSingleLine>) and (<BoxMultiLine> to the lines to get the effect shown in the image above.

is a black box on background subtitle, you can have lines with black box on background and without them in same subtitle.

this only on sub image based.

this is great, but only can do this manually or in export window.

And in export window not work very well because the effect only work in one line whatever more lines you add the effect

I use this in idx/sub and I need this on context menu like italic tag and others

this effect is useful when you have hardsubs on video.

Last edited by mood; 26th July 2014 at 03:02.
mood is offline   Reply With Quote
Old 26th July 2014, 12:58   #213  |  Link
von Suppé
Registered User
 
von Suppé's Avatar
 
Join Date: Dec 2013
Posts: 266
I understand. Thanks for clear explanation.
von Suppé is offline   Reply With Quote
Old 31st July 2014, 13:56   #214  |  Link
Nikse555
Registered User
 
Join Date: Feb 2004
Location: Mars
Posts: 233
About the dialogues and hyphen, try File - Plugins - "Dialogue one hyphen only".
The rules regarding one or two hyphens might be different depending on language I think...

@mood: In export you can choose default "Border style" incl. "box single line" or "one box".
The list view (and hence the list view context menu) in the export will be improved with Ctrl+a for select all, ctrl+d for de-select + ctrl+shif+i for inverse selection. Changing selection will also be much faster (was very slow previously).

Last edited by Nikse555; 31st July 2014 at 14:05.
Nikse555 is offline   Reply With Quote
Old 31st July 2014, 17:07   #215  |  Link
Betsy25
Registered User
 
Join Date: Sep 2008
Location: Holland, Belgium
Posts: 330
Nikse, you're willing to take a look at my 2 latest brewings here : https://github.com/Betsy25/subtitlee...its/My-Fixes-2

I'm a complete noob in C#, but I'm pretty sure you'll understand what I'm trying to do. (Regarding the dash cases followed by and or or)
Betsy25 is offline   Reply With Quote
Old 31st July 2014, 18:28   #216  |  Link
mood
Registered User
 
Join Date: May 2012
Posts: 83
@Nikse555

thanks, but the "Border style" applies to all lines and I do not want to apply the style to all lines, only the lines that I choose.

In export window the boxing effect only work for one line, if you applie more than one line, the effect you applie on line before disappears, the tags <BoxSingleLine> or <BoxMultiLine> still there but without effect.

Last edited by mood; 31st July 2014 at 18:34.
mood is offline   Reply With Quote
Old 31st July 2014, 21:20   #217  |  Link
Nikse555
Registered User
 
Join Date: Feb 2004
Location: Mars
Posts: 233
@Betsy25: I'll take a look... sorry I've looked earlier (was on vacation).

@mood: thx, a bug - hopefully fixed now (on Github and in this portable beta - http://www.nikse.dk/SubtitleEdit.zip )
Nikse555 is offline   Reply With Quote
Old 31st July 2014, 23:45   #218  |  Link
mood
Registered User
 
Join Date: May 2012
Posts: 83
@Nikse555

thanks, now work but I hope you add this style to context menu
mood is offline   Reply With Quote
Old 1st August 2014, 17:04   #219  |  Link
Betsy25
Registered User
 
Join Date: Sep 2008
Location: Holland, Belgium
Posts: 330
@Nikse,

when you have the time, will you take a look at your PM's here on Doom9 forum please ?

Last edited by Betsy25; 2nd August 2014 at 13:55.
Betsy25 is offline   Reply With Quote
Old 3rd August 2014, 17:48   #220  |  Link
mariner
Registered User
 
Join Date: Nov 2005
Posts: 561
Font settings not follwed when renderinbg BD sup

Greetings Nik.

Having trouble getting the BD sup to follow the font settings defined in ass subtitles. The preview panel seems to work fine, but the sup created uses only one font. Is this a known issue?

Many thanks and best regards.
mariner is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 06:37.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.