Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Capturing and Editing Video > Avisynth Development

Reply
 
Thread Tools Search this Thread Display Modes
Old 28th June 2016, 07:44   #1861  |  Link
qyot27
...?
 
qyot27's Avatar
 
Join Date: Nov 2005
Location: Florida
Posts: 1,084
Quote:
Originally Posted by MysteryX View Post
OK I created a new Fork into my account, but MT-pfmod doesn't show up in the list of branches
This is where git's remotes come in:
Code:
git remote add pinterf git://github.com/pinterf/AviSynthPlus.git
git fetch pinterf
git checkout MT-pfmod (or git checkout -b MT-pfmod pinterf/MT-pfmod if it doesn't let you do it with just the branch name)
qyot27 is offline   Reply With Quote
Old 28th June 2016, 09:12   #1862  |  Link
tormento
Acid fr0g
 
tormento's Avatar
 
Join Date: May 2002
Location: Italy
Posts: 1,034
@pinterf

So, it is a bug of AVS+ you will fix or a bug of the script that appears in AVS+ only?
__________________
@turment on Telegram
tormento is offline   Reply With Quote
Old 28th June 2016, 09:37   #1863  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 1,764
Quote:
Originally Posted by MysteryX View Post
VDub destructor crash fixed
....
I hope Wilbert follow this thread, because maybe this issue is also in standard avisynth 2.6, and this fix should also be include within.
jpsdr is offline   Reply With Quote
Old 28th June 2016, 09:42   #1864  |  Link
MysteryX
Soul Architect
 
MysteryX's Avatar
 
Join Date: Apr 2014
Posts: 2,173
Quote:
Originally Posted by qyot27 View Post
This is where git's remotes come in:
Code:
git remote add pinterf git://github.com/pinterf/AviSynthPlus.git
git fetch pinterf
git checkout MT-pfmod (or git checkout -b MT-pfmod pinterf/MT-pfmod if it doesn't let you do it with just the branch name)
Ah! After toying around with it, I finally got it. There you go Pinterf, you can merge the changes with a single click
MysteryX is offline   Reply With Quote
Old 28th June 2016, 13:32   #1865  |  Link
Wilbert
Moderator
 
Join Date: Nov 2001
Location: Netherlands
Posts: 6,335
Quote:
Originally Posted by MysteryX View Post
Here's another bug. I tried using Deshaker.
http://www.guthspot.se/video/deshaker.htm

Here's a script that will run the first pass and generate a log file to be used for the second pass.
Code:
P="Encoder\"
LoadVirtualDubPlugin(P+"deshaker.vdf", "deshaker", preroll=0)
LoadPlugin(P+"LSMASHSource.dll")
file="Source.MOV"
LWLibavVideoSource(file, cache=True)
ConvertToRGB32()
deshaker("19|1|30|4|1|0|1|0|640|640|1|2|1000|1000|1000|1000|4|1|3|2|8|30|300|4|Preview_Deshaker.log|0|0|0|0|0|0|0|0|0|0|0|0|0|1|15|15|5|15|0|0|30|30|0|0|0|0|1|0|0|10|1000|1|88|1|1|20|5000|100|20|1|0")
PointResize(8,8)
To run the second pass, re-insert the deshaker line in your full script wherever you want and change the 2nd argument from 1 to 2 to run the 2nd pass from that log file.

With AviSynth 2.6 it works fine. With AviSynth+, I get a crash in the destructor. Whenever I close the preview I get a crash.

Deshaker doesn't seem to work with MT but a single thread tops all 8 CPU cores anyway.
Could you give a link to an AviSynth+ version where this results in a crash?
Wilbert is offline   Reply With Quote
Old 28th June 2016, 14:08   #1866  |  Link
MysteryX
Soul Architect
 
MysteryX's Avatar
 
Join Date: Apr 2014
Posts: 2,173
Quote:
Originally Posted by Wilbert View Post
Could you give a link to an AviSynth+ version where this results in a crash?
I'm using Pinterf's latest version. I fixed the crash already and the changes have been merged into MT-pfmod branch
MysteryX is offline   Reply With Quote
Old 28th June 2016, 14:35   #1867  |  Link
ryrynz
Registered User
 
ryrynz's Avatar
 
Join Date: Mar 2009
Posts: 3,228
Next build will be official?
ryrynz is offline   Reply With Quote
Old 28th June 2016, 14:39   #1868  |  Link
Wilbert
Moderator
 
Join Date: Nov 2001
Location: Netherlands
Posts: 6,335
I'm not able to crash AviSynth v2.61a1 like you do with Deshaker, but it hasn't your changes. If i close VirtualDub during or at the end of the second pass it just exists without crashing.

avsplus-r1858-pfmod doesn't have the fix right? If i install the XP_x86 (yes still running that on my laptop) and run Version.avs it complains: 'AVI Import Filter error'. Anyone?

Guess i need to turn my pc on and try again.
Wilbert is offline   Reply With Quote
Old 28th June 2016, 14:47   #1869  |  Link
MysteryX
Soul Architect
 
MysteryX's Avatar
 
Join Date: Apr 2014
Posts: 2,173
v2.6 works fine, only AVS+ crashes.

The fix is here
https://github.com/pinterf/AviSynthP...acacb7b7661f37

If you want the updated VDubFilter.dll now (x86), I uploaded it here (compiled with VS2015)

Deshaker is complicated to use; so that's a good reason to integrate it into my Media Encoder software

Last edited by MysteryX; 28th June 2016 at 14:50.
MysteryX is offline   Reply With Quote
Old 28th June 2016, 14:59   #1870  |  Link
Wilbert
Moderator
 
Join Date: Nov 2001
Location: Netherlands
Posts: 6,335
Let me reword it. I don't understand why it crashed in AVS+ and it works fine in v2.61a1. I guess it must have something to do with VDubFilter being a plugin in AVS+ and part of the core in v2.61a1?

@pinterf, any ideas?

Last edited by Wilbert; 28th June 2016 at 15:09.
Wilbert is offline   Reply With Quote
Old 28th June 2016, 15:23   #1871  |  Link
MysteryX
Soul Architect
 
MysteryX's Avatar
 
Join Date: Apr 2014
Posts: 2,173
The plugin code has been altered since v2.6. Just looking at the code history, there has been quite a few changes over time.
MysteryX is offline   Reply With Quote
Old 28th June 2016, 21:57   #1872  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 1,256
@Wilbert: no idea, nor have I deeper insight on this area
pinterf is offline   Reply With Quote
Old 28th June 2016, 23:58   #1873  |  Link
ultim
AVS+ Dev
 
ultim's Avatar
 
Join Date: Aug 2013
Posts: 359
Quote:
Originally Posted by ryrynz View Post
Next build will be official?
pinterf and I will consult (it seems we might be able to do that IRL), and his changes will be merged. Until then, just overwrite the avisynth dll from the official installer package with pinterf's version, there is nothing wrong with doing that.
__________________
AviSynth+
ultim is offline   Reply With Quote
Old 29th June 2016, 15:10   #1874  |  Link
Wilbert
Moderator
 
Join Date: Nov 2001
Location: Netherlands
Posts: 6,335
@pinterf,

I can't get your fork to work: https://github.com/pinterf/AviSynthPlus/releases (x86).
I copied your dll over the regular avisynth+ version (AviSynthPlus-r1576.exe). The regular version works fine, but when overwriting it by your dll i get 'AVI Import Filter error' when opening Version.avs in 32-bit Virtualdub (Win7).

edit: Guess i needed Microsoft Visual C++ 2015 Redistributable.

Last edited by Wilbert; 29th June 2016 at 15:31.
Wilbert is offline   Reply With Quote
Old 29th June 2016, 15:34   #1875  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 1,256
Quote:
Originally Posted by Wilbert View Post
@pinterf,

I can't get your fork to work: https://github.com/pinterf/AviSynthPlus/releases (x86).
I copied your dll over the regular avisynth+ version (AviSynthPlus-r1576.exe). The regular version works fine, but when overwriting it by your dll i get 'AVI Import Filter error' when opening Version.avs in 32-bit Virtualdub (Win7).
Do you have VS 2015 Redistributables installed?
edit: I see, O.K. - at least I found again where my virtualdub folder is

Last edited by pinterf; 29th June 2016 at 15:36.
pinterf is offline   Reply With Quote
Old 30th June 2016, 10:29   #1876  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 1,256
Quote:
Originally Posted by tormento View Post
@pinterf

So, it is a bug of AVS+ you will fix or a bug of the script that appears in AVS+ only?
Still couldn't identify which part works differently, but the modified SMDegrain script with TV_range parameter solves the problem (does not call rebuild luma if TV_range false)
pinterf is offline   Reply With Quote
Old 30th June 2016, 10:31   #1877  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 1,256
Quote:
Originally Posted by real.finder View Post
this with TV_range bool http://pastebin.com/vz6Ewuvv

try first
Code:
SMDegrain (tr=4,PreFilter=prefilter4,TV_range=false,thSAD=400,contrasharp=false,refinemotion=false,plane=4,chroma=true,lsb=true,mode=6)
Prefetch(8)
then try
Code:
SMDegrain (tr=4,PreFilter=prefilter4.SmoothCustom16("Y>60160?y:y","u>61440?u:u","v>61440?v:v",limiter=true),thSAD=400,contrasharp=false,refinemotion=false,plane=4,chroma=true,lsb=true,mode=6)
Prefetch(8)
and
Code:
SMDegrain (tr=4,PreFilter=prefilter4.Ditherpost(mode=6,ampn=0.0,staticnoise=false).Limiter(),thSAD=400,contrasharp=false,refinemotion=false,plane=4,chroma=true,lsb=true,mode=6)
Prefetch(8)
The one with the new TV_range=true parameter is O.K.
The other two clips are corrupted.
What is the conclusion? The second method receives a limited prefiltered clip, still it shows garbage
pinterf is offline   Reply With Quote
Old 30th June 2016, 11:18   #1878  |  Link
tormento
Acid fr0g
 
tormento's Avatar
 
Join Date: May 2002
Location: Italy
Posts: 1,034
Quote:
Originally Posted by pinterf View Post
Still couldn't identify which part works differently, but the modified SMDegrain script with TV_range parameter solves the problem (does not call rebuild luma if TV_range false)


Ok... Anyway understanding why AVS+ works differently would be better

What does that modified scripts do exactly? If reduces color range is no go...
__________________
@turment on Telegram
tormento is offline   Reply With Quote
Old 30th June 2016, 14:45   #1879  |  Link
ultim
AVS+ Dev
 
ultim's Avatar
 
Join Date: Aug 2013
Posts: 359
It turns out pinterf and I live close to each other, so we took advantage of this and met up in person. We talked about many things, like introductions ofc, what we do for a living, how we got into Avisynth. We also looked at various parts of the code, some parts he still needed to look into, and others that I needed to refresh my own memory about. We also spoke about how important it is that when we get a bug report, we receive a sample video and a minimalistic script to reproduce it. We both felt compelled to point out that a script which has only two lines, but in one of them calls a multi-hundred-line script, is not minimal. We know there are a multiple things to improve and many wishes, but neither of us have the resources to make everything come true, so we need to aggressively prioritize.

pinterf has a lot of development experience, though he only recently started using C++, so he is still experimenting a lot. There are also some other things he's been working on, all related to Avisynth, so you can expect more goodies from him soon As for me, I have taken home a list of stuff for me to investigate/debug. I'd say once I catch up to this list, pinterf's changes, and Avs 2.6.1, I'll feel comfortable to do another release. Pinterf will probably release other builds earlier.

Of course we went into a lot more detail on each of these topics, but I think this gives you a basic overview of the things we talked about.
__________________
AviSynth+
ultim is offline   Reply With Quote
Old 30th June 2016, 16:12   #1880  |  Link
LigH
German doom9/Gleitz SuMo
 
LigH's Avatar
 
Join Date: Oct 2001
Location: Germany, rural Altmark
Posts: 5,963
Quote:
Originally Posted by ultim View Post
It turns out pinterf and I live close to each other, so we took advantage of this and met up in person.
Rare occasion... I hope you had
__________________

New German Gleitz board
MediaFire: x264 | x265 | VPx | AOM | Xvid
LigH is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 18:29.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.