TIVTC for VapourSynth

jackoneill · 13th March 2021, 15:23

What do you think?

https://github.com/dubhater/vapoursynth-tivtc

ChaosKing · 13th March 2021, 16:08

Nice!
But isn't vivtc = tivtc?

jackoneill · 13th March 2021, 16:28

Quote:

Originally Posted by ChaosKing

Nice!
But isn't vivtc = tivtc?

Not completely. Mostly VIVTC does fewer things.

Izuchi · 14th March 2021, 16:17

So is this meant to supersede VIVTC?

DJATOM · 14th March 2021, 18:22

Is it final? I compiled it yesterday and tried to make 2pass vfr, but it writes empty metric files. I didn't reported since assumed it might be a WIP.

ChaosKing · 14th March 2021, 19:07

I tested it with my "problematic" DVD and I must say vivtc performed better (with same settings, maybe some other default values are different). TIVTC missed some frames. Both seem equally fast.

Bonus point for tivtc: d2v input (idk what it does exactly but at least it reported the correct field order

)

jackoneill · 14th March 2021, 20:08

@Izuchi: It's not meant to supersede VIVTC. I don't know, use whichever you prefer.

@DJATOM: It's final in the sense that I thought I was done. But I only tested TDecimate with modes 0 and 1, with default settings. I tested mode 4 just now and it wrote the metrics in the output file. Can you step through TDecimate::~TDecimate to see where it fails?

@ChaosKing: If the Avisynth version makes the same mistakes, then it's okay.

DJATOM · 14th March 2021, 20:19

It seems with doodle1 version TDecimate::~TDecimate is never called. Weird. Vanilla VS works as expected.

Selur · 14th March 2021, 20:28

Nice!

ChaosKing · 14th March 2021, 23:18

Quote:

@ChaosKing: If the Avisynth version makes the same mistakes, then it's okay.

I just re-checked and the avisynth version does not have these mistakes.

EDIT:
See PM for sample vob.

Myrsloik · 15th March 2021, 10:54

Quote:

Originally Posted by ChaosKing

Nice!
But isn't vivtc = tivtc?

VIVTC is basically a reimplementation of TIVTC and only borrows two (I think) heavily refactored field matching metric calculation functions. The rest is implemented more or less based on common sense/TIVTC documentation description which means it doesn't match the actual TIVTC behavior at all.

jackoneill · 17th March 2021, 18:38

v2 fixes this bug:

Quote:

Originally Posted by ChaosKing

I tested it with my "problematic" DVD and I must say vivtc performed better (with same settings, maybe some other default values are different). TIVTC missed some frames.

And DJATOM added frame durations for modes 5 and 6.

ChaosKing · 17th March 2021, 18:53

Nice. The bug is gone now. I love this kind of typos. Everything seems to work but not really and you spend hours to figure out what is wrong

Output looks now identical to avs ivtc

p.s. ivtc package added to vsrepo git, but not uploaded yet!

13th March 2021, 15:23	#1 \| Link
jackoneill unsigned int Join Date: Oct 2012 Location: 🇪🇺 Posts: 760	TIVTC for VapourSynth What do you think? https://github.com/dubhater/vapoursynth-tivtc __________________ Buy me a "coffee" and/or hire me to write code!

13th March 2021, 16:08	#2 \| Link
ChaosKing Registered User Join Date: Dec 2005 Location: Germany Posts: 1,795	Nice! But isn't vivtc = tivtc? __________________ AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth VapourSynth Portable FATPACK \|\| VapourSynth Database

14th March 2021, 18:22	#5 \| Link
DJATOM Registered User Join Date: Sep 2010 Location: Ukraine, Bohuslav Posts: 377	Is it final? I compiled it yesterday and tried to make 2pass vfr, but it writes empty metric files. I didn't reported since assumed it might be a WIP. __________________ Me on GitHub PC Specs: Ryzen 5950X, 64 GB RAM, RTX 2070

14th March 2021, 19:07	#6 \| Link
ChaosKing Registered User Join Date: Dec 2005 Location: Germany Posts: 1,795	I tested it with my "problematic" DVD and I must say vivtc performed better (with same settings, maybe some other default values are different). TIVTC missed some frames. Both seem equally fast. Bonus point for tivtc: d2v input (idk what it does exactly but at least it reported the correct field order ) __________________ AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth VapourSynth Portable FATPACK \|\| VapourSynth Database

14th March 2021, 20:08	#7 \| Link
jackoneill unsigned int Join Date: Oct 2012 Location: 🇪🇺 Posts: 760	@Izuchi: It's not meant to supersede VIVTC. I don't know, use whichever you prefer. @DJATOM: It's final in the sense that I thought I was done. But I only tested TDecimate with modes 0 and 1, with default settings. I tested mode 4 just now and it wrote the metrics in the output file. Can you step through TDecimate::~TDecimate to see where it fails? @ChaosKing: If the Avisynth version makes the same mistakes, then it's okay. __________________ Buy me a "coffee" and/or hire me to write code!

14th March 2021, 16:17	#4 \| Link
Izuchi Registered User Join Date: Dec 2014 Posts: 28	So is this meant to supersede VIVTC?

14th March 2021, 20:19	#8 \| Link
DJATOM Registered User Join Date: Sep 2010 Location: Ukraine, Bohuslav Posts: 377	It seems with doodle1 version TDecimate::~TDecimate is never called. Weird. Vanilla VS works as expected. __________________ Me on GitHub PC Specs: Ryzen 5950X, 64 GB RAM, RTX 2070

14th March 2021, 20:28	#9 \| Link
Selur Registered User Join Date: Oct 2001 Location: Germany Posts: 7,277	Nice! __________________ Hybrid here in the forum, homepage

17th March 2021, 18:53	#13 \| Link
ChaosKing Registered User Join Date: Dec 2005 Location: Germany Posts: 1,795	Nice. The bug is gone now. I love this kind of typos. Everything seems to work but not really and you spend hours to figure out what is wrong Output looks now identical to avs ivtc p.s. ivtc package added to vsrepo git, but not uploaded yet! __________________ AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth VapourSynth Portable FATPACK \|\| VapourSynth Database

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode