Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
24th March 2020, 10:26 | #81 | Link |
結城有紀
Join Date: Dec 2003
Location: NJ; OR; Shanghai
Posts: 894
|
I shot a quick email to the original author and see if I can get something.
I finished organizing all Apply*3D*() family and all their SSE2 counterparts. bt=5 shows a significant speed improvement (85539ms -> 13925ms for a short clip). Might start working on AVX part later. Hopefully I can get an answer soon. |
24th March 2020, 17:29 | #82 | Link |
Registered User
Join Date: Jan 2014
Posts: 2,309
|
Nice. You can check VapourSynth solution, there had been a refactor as well.
https://forum.doom9.org/showthread.php?t=175199 |
24th March 2020, 18:47 | #84 | Link |
Professional Code Monkey
Join Date: Jun 2003
Location: Kinnarps Chair
Posts: 2,548
|
Insanity! The Avisynth developer code dictates that you must create yet another incompatible fork!
__________________
VapourSynth - proving that scripting languages and video processing isn't dead yet |
24th March 2020, 18:58 | #85 | Link | |
結城有紀
Join Date: Dec 2003
Location: NJ; OR; Shanghai
Posts: 894
|
Quote:
|
|
26th March 2020, 04:57 | #87 | Link |
結城有紀
Join Date: Dec 2003
Location: NJ; OR; Shanghai
Posts: 894
|
https://github.com/pinterf/fft3dfilt...lter.cpp#L2811
Is coverpitch * pixelsize supposed to be coverpitch? |
26th March 2020, 08:14 | #88 | Link | |
Registered User
Join Date: Jan 2014
Posts: 2,309
|
Quote:
|
|
26th March 2020, 08:23 | #89 | Link |
Registered User
Join Date: Jan 2014
Posts: 2,309
|
(In general) When you make filters that work for both VS and AVS, parameter handling is different when applied on different bit depth.
Conventionally VS filters require to scale parameters to the appropriate bit-depth at the scripting side. In my AVS filters the same parameter magnitudes will work similarly for all bit depths. E.g. sigmas, smin, smax. |
26th March 2020, 10:53 | #90 | Link |
結城有紀
Join Date: Dec 2003
Location: NJ; OR; Shanghai
Posts: 894
|
Yea I saw that when I refactor those part.
Now I can almost ensure it's very bit identical to the before-refactoring, except for some minor difference (such as different order of float additions and subtractions). Moving from ancient C++ to modern C++ really gives a fresh breeze. I have wiped the original caching system and made a LRU template caching, and refactor bt 2..5 into a single block. Should be much easier to maintain now. Duplicate code in Apply family are all eliminated with a more functional programming structure (lambda callback). This is the first time I'm writing C++ code in Ruby style, so will see how it goes. Next step is to finish the AVS+VS dual interface, then I'll move back to LSMASH-Works Linux porting work, and hopefully I can get it up and running on Debian very soon. |
26th March 2020, 12:22 | #91 | Link |
Registered User
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
|
maybe parameters scale parameter like paramscale in MaskTools2 will be a good idea, with "none" by Default in vs and Default "i8" in avs
__________________
See My Avisynth Stuff Last edited by real.finder; 26th March 2020 at 12:26. |
27th March 2020, 04:35 | #93 | Link | |
Registered User
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
|
Quote:
so paramscale will be balanced solution for both, and it's also useful in debugging also sigmas, smin, smax etc... should be float parameter instead of int (if it not float already) and if the old filter/plugin parameter was int, then it better to have dual filter signatures
__________________
See My Avisynth Stuff Last edited by real.finder; 27th March 2020 at 05:37. |
|
27th March 2020, 07:00 | #94 | Link |
結城有紀
Join Date: Dec 2003
Location: NJ; OR; Shanghai
Posts: 894
|
Since this refactor is going to be a big change, I'm going to ignore full compatibility and try to do things right (at least right according to my mind).
That includes removing of plane / multiplane parameter and use the easier [y/u/v]=[3/2/1] convention, removing YUY2 colorspace support, and a few fixes that might not give bit identical result. I also plan to add a set of window parameters according to my personal need, so only pixels inside window is processed. |
27th March 2020, 07:34 | #96 | Link | |
Registered User
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
|
Quote:
__________________
See My Avisynth Stuff |
|
27th March 2020, 08:29 | #98 | Link |
結城有紀
Join Date: Dec 2003
Location: NJ; OR; Shanghai
Posts: 894
|
I already changed it to Neo_FFT3D since I forgot to mention that. The original filter was written in 2004/2005 where WinXP and YUY2 were mainstream support. I think now it's a good time to move on. Although there are incompatibilities, it's still pretty easy to move to the new filter with minor changes to scripts.
|
27th March 2020, 15:18 | #99 | Link | |
Broadcast Encoder
Join Date: Nov 2013
Location: Royal Borough of Kensington & Chelsea, UK
Posts: 2,883
|
Quote:
Last edited by FranceBB; 27th March 2020 at 15:23. |
|
27th March 2020, 15:51 | #100 | Link | |
HeartlessS Usurer
Join Date: Dec 2009
Location: Over the rainbow
Posts: 10,980
|
Quote:
__________________
I sometimes post sober. StainlessS@MediaFire ::: AND/OR ::: StainlessS@SendSpace "Some infinities are bigger than other infinities", but how many of them are infinitely bigger ??? |
|
Thread Tools | Search this Thread |
Display Modes | |
|
|