Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Video Encoding > High Efficiency Video Coding (HEVC)
Register FAQ Calendar Today's Posts Search

Reply
 
Thread Tools Search this Thread Display Modes
Old 15th December 2022, 14:24   #8861  |  Link
Boulder
Pig on the wing
 
Boulder's Avatar
 
Join Date: Mar 2002
Location: Finland
Posts: 5,733
Quote:
Originally Posted by LigH View Post
New upload: x265 3.5+74-1ec26b9f6

[Windows][GCC 12.2.0][32/32XP/64 bit] 8bit+10bit+12bit

News since v3.5+70:
Code:
--scenecut-qp-config <file>   File containing scenecut-aware-qp mode, window duration and offsets settings required for the masking. Works only with --pass 2
I guess we need a sample file to know how it works...
Yes, the functionality looks a bit confusing to me. Hopefully someone could provide a simple use case for this.
__________________
And if the band you're in starts playing different tunes
I'll see you on the dark side of the Moon...
Boulder is offline   Reply With Quote
Old 15th December 2022, 14:38   #8862  |  Link
LigH
German doom9/Gleitz SuMo
 
LigH's Avatar
 
Join Date: Oct 2001
Location: Germany, rural Altmark
Posts: 6,784
Unfortunately, readthedocs is not yet up to date.
__________________

New German Gleitz board
MediaFire: x264 | x265 | VPx | AOM | Xvid
LigH is offline   Reply With Quote
Old 15th December 2022, 22:24   #8863  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,316
I was using --scenecut-aware-qp 3 in my scripts, and now with the new version i have a FLAW error, "invalid argument", but according the --fullhelp it's stil a valid argument...

Edit :
Has anyone else tested to check if --scenecut-aware-qp 3 is still working after these commits ?
For me this release is broken somewhere, all my encoding scripts are not running anymore.
__________________
My github.

Last edited by jpsdr; 16th December 2022 at 09:41.
jpsdr is offline   Reply With Quote
Old 16th December 2022, 17:54   #8864  |  Link
benwaggoner
Moderator
 
Join Date: Jan 2006
Location: Portland, OR
Posts: 4,771
Quote:
Originally Posted by LigH View Post
Unfortunately, readthedocs is not yet up to date.
FWIW, there is an "Edit on Bitbucket" button at the top of all those pages. We can submit edits and additions ourselves for things that MCW hasn't documented yet or needs tweaking. I just submitted a commit to edit the weird discontinuity in the options list for --force-flush as a test.
__________________
Ben Waggoner
Principal Video Specialist, Amazon Prime Video

My Compression Book

Last edited by benwaggoner; 16th December 2022 at 18:14. Reason: Hit Send prematurely
benwaggoner is offline   Reply With Quote
Old 16th December 2022, 18:04   #8865  |  Link
ShortKatz
Registered User
 
Join Date: Aug 2018
Location: Germany
Posts: 119
Quote:
Originally Posted by LigH View Post
New upload: x265 3.5+74-1ec26b9f6

[Windows][GCC 12.2.0][32/32XP/64 bit] 8bit+10bit+12bit

News since v3.5+70:
Code:
--scenecut-qp-config <file>   File containing scenecut-aware-qp mode, window duration and offsets settings required for the masking. Works only with --pass 2
I guess we need a sample file to know how it works...

There is now a sample file here: https://bitbucket.org/multicoreware/..._qp_config.txt

Its from https://mailman.videolan.org/piperma...er/013560.html
ShortKatz is offline   Reply With Quote
Old 16th December 2022, 19:20   #8866  |  Link
benwaggoner
Moderator
 
Join Date: Jan 2006
Location: Portland, OR
Posts: 4,771
Quote:
Originally Posted by ShortKatz View Post
Huh. It seems odd to use an external file for just a few static parameters. Normally x265 uses external files (multi-pass-opt-analysis, qpfile) for data that can vary per-frame.

Perhaps there will be a way to specify different parameters for different frame ranges?
__________________
Ben Waggoner
Principal Video Specialist, Amazon Prime Video

My Compression Book
benwaggoner is offline   Reply With Quote
Old 16th December 2022, 21:25   #8867  |  Link
Greenhorn
Registered User
 
Join Date: Apr 2018
Posts: 61
Looking at the docs for the new file on BitBucket, it can get a lot more complicated that sample, so I can see why they used a file for it even if it's still static values.

(docs/rEST/cli.rst, and you have to click "Open Raw" in the little menu next to the "Edit" button since the fancy markdown version you see by default is ancient. Search for masking-strength.)
Greenhorn is offline   Reply With Quote
Old 16th December 2022, 21:54   #8868  |  Link
quietvoid
Registered User
 
Join Date: Jan 2019
Location: Canada
Posts: 574
You can specify the different QP adjustments per window, and there are 6 windows now.
So the file is useful for that, but hardly IMO.

My CLI for example is already 1000 characters, so it wouldn't bother me.
__________________
LG C2 OLED | GitHub Projects
quietvoid is offline   Reply With Quote
Old 16th December 2022, 22:14   #8869  |  Link
LigH
German doom9/Gleitz SuMo
 
LigH's Avatar
 
Join Date: Oct 2001
Location: Germany, rural Altmark
Posts: 6,784
Quote:
Originally Posted by benwaggoner View Post
We can submit edits ...
... but better do so only when we actually have a clue. I do not, in this case.

But I noticed a mailing list entry so it will happen.
__________________

New German Gleitz board
MediaFire: x264 | x265 | VPx | AOM | Xvid
LigH is offline   Reply With Quote
Old 16th December 2022, 23:31   #8870  |  Link
benwaggoner
Moderator
 
Join Date: Jan 2006
Location: Portland, OR
Posts: 4,771
Quote:
Originally Posted by LigH View Post
... but better do so only when we actually have a clue. I do not, in this case.

But I noticed a mailing list entry so it will happen.
It still goes through the normal commit process, so MCW has a chance to review any edits. I focused on some formatting deficiencies that I'd noticed had been a common source of confusion.
__________________
Ben Waggoner
Principal Video Specialist, Amazon Prime Video

My Compression Book
benwaggoner is offline   Reply With Quote
Old 17th December 2022, 12:17   #8871  |  Link
ghostshadow
Registered User
 
Join Date: Jan 2020
Posts: 34
I thought there was an option to activate an automatic filling of this file with different options for each scene but the need to put them by hand from what I understand
ex : --scenecut-aware-qp 3 --masking-strength 500,2,0,200,-1,-1 in the file scenecut_qp_config.txt.
so we have to manually enter all the options per scene?
ghostshadow is offline   Reply With Quote
Old 17th December 2022, 13:33   #8872  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,316
I have, just for testing, replaced :
Code:
OPT("scenecut-aware-qp") p->bEnableSceneCutAwareQp = x265_atoi(value, bError);
with
Code:
OPT("scenecut-aware-qp") p->bEnableSceneCutAwareQp = atoi(value);
No change, my log file has only one line :
Code:
x265 [FLAW]: invalid argument: scenecut-aware-qp = 3
__________________
My github.
jpsdr is offline   Reply With Quote
Old 17th December 2022, 15:41   #8873  |  Link
Boulder
Pig on the wing
 
Boulder's Avatar
 
Join Date: Mar 2002
Location: Finland
Posts: 5,733
Do we still need quietvoid's patch (probably a new version of it) to make the functionality work in CRF mode?
__________________
And if the band you're in starts playing different tunes
I'll see you on the dark side of the Moon...
Boulder is offline   Reply With Quote
Old 19th December 2022, 02:12   #8874  |  Link
benwaggoner
Moderator
 
Join Date: Jan 2006
Location: Portland, OR
Posts: 4,771
Quote:
Originally Posted by ghostshadow View Post
I thought there was an option to activate an automatic filling of this file with different options for each scene but the need to put them by hand from what I understand
ex : --scenecut-aware-qp 3 --masking-strength 500,2,0,200,-1,-1 in the file scenecut_qp_config.txt.
so we have to manually enter all the options per scene?
While it can be hand-edited, which is very useful for testing and early days evaluations like we are today. Production implementations would automatically generate the file based on preanalysis, like how qpfiles are most commonly used. Perhaps a future x265 will generate the file, which could be analyzed and edited as needed.
__________________
Ben Waggoner
Principal Video Specialist, Amazon Prime Video

My Compression Book
benwaggoner is offline   Reply With Quote
Old 20th December 2022, 09:59   #8875  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,316
Ok, i think i understand my mistake.
I thought the new patch offered the possibility of having an external file to configure the scenecut-qp stuff.
But not, it's a necessity !
For just using --scenecut-aware-qp 3 i have to create an external file, acces it with --scenecut-qp-config and put --scenecut-aware-qp 3 inside it...
I will in my mod version restore the possibility of being able to just put --scenecut-aware-qp directly in command inside a script without the necessity to have an external file just for it (and make all my encoding scripts working again...)
__________________
My github.
jpsdr is offline   Reply With Quote
Old 20th December 2022, 16:23   #8876  |  Link
LigH
German doom9/Gleitz SuMo
 
LigH's Avatar
 
Join Date: Oct 2001
Location: Germany, rural Altmark
Posts: 6,784
That's all? It sounded like there is a zone control.
__________________

New German Gleitz board
MediaFire: x264 | x265 | VPx | AOM | Xvid
LigH is offline   Reply With Quote
Old 20th December 2022, 19:29   #8877  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,316
What i ment, it's that now you can't anymore just put --scenecut-aware-qp 3 directly in the command line, you have to put it in an external file. There is probably a lot of others possibilities with this new patch (i didn't dig to see what it's doing because i'm not using these stuff), and having the possibility of using an external file for a lot of zone description is a good thing of course, but for someone like me who was just using --scenecut-aware-qp 3, it breaks all my encode script, and to have to add an extra file just to put one command inside...
__________________
My github.

Last edited by jpsdr; 20th December 2022 at 19:31.
jpsdr is offline   Reply With Quote
Old 20th December 2022, 22:06   #8878  |  Link
Barough
Registered User
 
Barough's Avatar
 
Join Date: Feb 2007
Location: Sweden
Posts: 483
x265 v3.5+75
https://www.mediafire.com/file/w8xufft0b475b1t
Barough is offline   Reply With Quote
Old 20th December 2022, 23:15   #8879  |  Link
ShortKatz
Registered User
 
Join Date: Aug 2018
Location: Germany
Posts: 119
Quote:
Originally Posted by jpsdr View Post
Ok, i think i understand my mistake.
I thought the new patch offered the possibility of having an external file to configure the scenecut-qp stuff.
But not, it's a necessity !
For just using --scenecut-aware-qp 3 i have to create an external file, acces it with --scenecut-qp-config and put --scenecut-aware-qp 3 inside it...
Oh, really? That's stupid, who came up with that idea?
ShortKatz is offline   Reply With Quote
Old 22nd December 2022, 20:33   #8880  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,316
I've made a new build on my mod version (check my github).
As i have en encode running, i couldn't test it.
__________________
My github.
jpsdr is offline   Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 23:29.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.