Port of NNEDI under new v2.6 AVS API - Page 5

jpsdr · 10th May 2015, 11:00

New build avaible. With a little luck, maybe the good one...

stax76 · 10th May 2015, 11:10

You made it, this is a great day for AviSynth x64, for StaxRip x64 and for people using different languages working together, it has been a pleasure to work with you on this, thanks!

jpsdr · 10th May 2015, 12:01

Wonderful. It's also a good thing to get ridance of lefting bugs. The only surprising thing, it's that these bugs left could have been trigged by anything. It was clearly not a specific issue to Win8.1/Win10. Well, everything ends well, it's what matters.
Thanks also at the others who have helped, providing information and running debug builds.

stax76 · 10th May 2015, 12:01

@jpsdr

DGDecNV and mvtools2 behave the same as nnedi3 before you fixed it. They work in VirtualDub but cause a access violation and crash in managed applications and in MPC-BE. Is there anything I can tell the authors how to find the problem? Did the line I showed you help/relate?

jpsdr · 10th May 2015, 12:40

Unfortunately i don't think so. My issue was clealy a bug in the ASM file, some registers where kept with their 32bit versions when they should have been their 64bits versions. What helped me more (and that was what i needed) was the screenshot of HolyWu with disassembled part of the crash, and the status of the registers when crash occured.

videoh · 10th May 2015, 15:14

Quote:

Originally Posted by stax76

They work in VirtualDub but cause a access violation and crash in managed applications

Let's be precise: they crash in your managed applicaton. There is no problem in DGDecNV. And the threads here show that you refuse to answer questions or perform any straightforward debugging to actually try to locate the problem. I stand ready to assist if you are actually interested in solving the problem, but it seems that you are more interested in insulting people because they do not use .NET. That is my reward for trying to help you.

stax76 · 10th May 2015, 15:29

I told you about 15 times that all you need is loading a DGDecNV avs script with MPC-BE x64 or StaxRip x64 and you will see a access violation happening in YOUR native code, you were wrong, accept it, let it go, fix your code.

videoh · 10th May 2015, 15:52

I don't have the environment setup for opening avs scripts in the DirectShow-based players (they can't open AVS on my system and I never figured out why), so I can't currently test MPC-BE. Can you please show me the crash screen?

burfadel · 23rd May 2015, 18:20

I see there is someone doing active work on NNEDI3 for Vapoursynth. Are any of those commits compatible with NNEDI3 for Avisynth, and if so can they be ported if they haven't already been done so?

https://github.com/dubhater/vapoursy...commits/master

jpsdr · 24th May 2015, 10:22

Projects are too different, and so very very unlikely.

burfadel · 24th May 2015, 11:19

Fair enough

. I just wasn't sure to what extent that the two were different.

Myrsloik · 24th May 2015, 11:56

Quote:

Originally Posted by jpsdr

Projects are too different, and so very very unlikely.

I think this commit may be of interest to you:
https://github.com/dubhater/vapoursy...c20812b761cfee

Equivalent line probably here:
https://github.com/jpsdr/NNEDI3/blob...nedi3.cpp#L471

Not sure if this commit is also relevant but maybe it should be checked:
https://github.com/dubhater/vapoursy...1bd554d4ec00d4

jpsdr · 25th May 2015, 09:08

Thanks, i'll take a look.

jpsdr · 25th May 2015, 19:40

New version avaible.

burfadel · 25th May 2015, 20:08

Quote:

Originally Posted by jpsdr

New version avaible.

Thanks

hello_hello · 26th May 2015, 00:27

If anyone cares, the right click explorer file/properties menu shows version 0.9.4.10 of the various nnedi3.dlls as being version 0.9.4.7. It was the same for 0.9.4.9.

Cheers.

jpsdr · 26th May 2015, 09:51

Ah... Thanks for the information, i totaly forgot this in the compiler settings. And i have to find out where it was again... I'll do a new build very soon, even if not critical, it's always usefull.

jpsdr · 26th May 2015, 19:27

New build avaible with correct version in properties file.

jpsdr · 9th June 2015, 12:06

If anyone have any idea of how correct nnedi3 according the informations here :
http://forum.doom9.org/showthread.ph...44#post1660744

I personnaly don't know how to "fix" the actual code.
I know the opencl version is corrected, but code is too much different, i don't know how to implement it in the actual code.

I don't know if the Vapoursynth version is "fixed".

Any information or even pull request are welcomed.

jpsdr · 31st July 2015, 21:15

New version, i've tried to fix the chroma shift according the informations on this thread :
http://forum.doom9.org/showthread.php?t=170029

Test and report any issue, any feedback is welcomed.

10th May 2015, 15:52	#88 \| Link
videoh Useful n00b Join Date: Jul 2014 Posts: 1,667	I don't have the environment setup for opening avs scripts in the DirectShow-based players (they can't open AVS on my system and I never figured out why), so I can't currently test MPC-BE. Can you please show me the crash screen? Last edited by videoh; 10th May 2015 at 16:10.

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

10th May 2015, 11:00	#81 \| Link
jpsdr Registered User Join Date: Oct 2002 Location: France Posts: 2,316	New build avaible. With a little luck, maybe the good one...

10th May 2015, 11:10	#82 \| Link
stax76 Registered User Join Date: Jun 2002 Location: On thin ice Posts: 6,837	You made it, this is a great day for AviSynth x64, for StaxRip x64 and for people using different languages working together, it has been a pleasure to work with you on this, thanks!

10th May 2015, 12:01	#83 \| Link
jpsdr Registered User Join Date: Oct 2002 Location: France Posts: 2,316	Wonderful. It's also a good thing to get ridance of lefting bugs. The only surprising thing, it's that these bugs left could have been trigged by anything. It was clearly not a specific issue to Win8.1/Win10. Well, everything ends well, it's what matters. Thanks also at the others who have helped, providing information and running debug builds.

10th May 2015, 12:01	#84 \| Link
stax76 Registered User Join Date: Jun 2002 Location: On thin ice Posts: 6,837	@jpsdr DGDecNV and mvtools2 behave the same as nnedi3 before you fixed it. They work in VirtualDub but cause a access violation and crash in managed applications and in MPC-BE. Is there anything I can tell the authors how to find the problem? Did the line I showed you help/relate?

10th May 2015, 12:40	#85 \| Link
jpsdr Registered User Join Date: Oct 2002 Location: France Posts: 2,316	Unfortunately i don't think so. My issue was clealy a bug in the ASM file, some registers where kept with their 32bit versions when they should have been their 64bits versions. What helped me more (and that was what i needed) was the screenshot of HolyWu with disassembled part of the crash, and the status of the registers when crash occured.

10th May 2015, 15:29	#87 \| Link
stax76 Registered User Join Date: Jun 2002 Location: On thin ice Posts: 6,837	I told you about 15 times that all you need is loading a DGDecNV avs script with MPC-BE x64 or StaxRip x64 and you will see a access violation happening in YOUR native code, you were wrong, accept it, let it go, fix your code.

23rd May 2015, 18:20	#89 \| Link
burfadel Registered User Join Date: Aug 2006 Posts: 2,229	I see there is someone doing active work on NNEDI3 for Vapoursynth. Are any of those commits compatible with NNEDI3 for Avisynth, and if so can they be ported if they haven't already been done so? https://github.com/dubhater/vapoursy...commits/master

24th May 2015, 10:22	#90 \| Link
jpsdr Registered User Join Date: Oct 2002 Location: France Posts: 2,316	Projects are too different, and so very very unlikely.

24th May 2015, 11:19	#91 \| Link
burfadel Registered User Join Date: Aug 2006 Posts: 2,229	Fair enough . I just wasn't sure to what extent that the two were different.

25th May 2015, 09:08	#93 \| Link
jpsdr Registered User Join Date: Oct 2002 Location: France Posts: 2,316	Thanks, i'll take a look.

25th May 2015, 19:40	#94 \| Link
jpsdr Registered User Join Date: Oct 2002 Location: France Posts: 2,316	New version avaible.

26th May 2015, 00:27	#96 \| Link
hello_hello Registered User Join Date: Mar 2011 Posts: 4,829	If anyone cares, the right click explorer file/properties menu shows version 0.9.4.10 of the various nnedi3.dlls as being version 0.9.4.7. It was the same for 0.9.4.9. Cheers.

26th May 2015, 09:51	#97 \| Link
jpsdr Registered User Join Date: Oct 2002 Location: France Posts: 2,316	Ah... Thanks for the information, i totaly forgot this in the compiler settings. And i have to find out where it was again... I'll do a new build very soon, even if not critical, it's always usefull.

26th May 2015, 19:27	#98 \| Link
jpsdr Registered User Join Date: Oct 2002 Location: France Posts: 2,316	New build avaible with correct version in properties file.

9th June 2015, 12:06	#99 \| Link
jpsdr Registered User Join Date: Oct 2002 Location: France Posts: 2,316	If anyone have any idea of how correct nnedi3 according the informations here : http://forum.doom9.org/showthread.ph...44#post1660744 I personnaly don't know how to "fix" the actual code. I know the opencl version is corrected, but code is too much different, i don't know how to implement it in the actual code. I don't know if the Vapoursynth version is "fixed". Any information or even pull request are welcomed.

31st July 2015, 21:15	#100 \| Link
jpsdr Registered User Join Date: Oct 2002 Location: France Posts: 2,316	New version, i've tried to fix the chroma shift according the informations on this thread : http://forum.doom9.org/showthread.php?t=170029 Test and report any issue, any feedback is welcomed.