[Solved] Implementing t_mod patches on r2969

jpsdr · 22nd March 2019, 17:08

As i've said, i'm trying to implement t_mod patches on r2969. I'm stuck with an issue i'm unable to solve...

nasm throw a warning i can't get rid of, and i don't understand the reason of it.

Building for 10 bits works, building for 8 bits didn't, a lot of unresolved symbol on final link phase.
I'm unable to understand why this happens.

Is there someone who have the time and who can help me ?

jpsdr · 25th March 2019, 14:46

Finaly, after long strugle, solved...!

Blue_MiSfit · 27th March 2019, 21:57

Maybe post how you fixed it?

jpsdr · 28th March 2019, 10:18

I didn't get rid of the nasm warning, realy unable to understand it, and if my memory is correct, this warning wasn't in previous nasm version, so it may be related to the new nasm release.
About the unresolved symbols, in the new x264 version, it seems i have to "declare" any new asm functions, so i had to add the following in common/x86/pixel.h :

Code:

#define x264_pixel_noise_16x16_mmx2 x264_template(pixel_noise_16x16_mmx2)
#define x264_pixel_noise_16x8_mmx2 x264_template(pixel_noise_16x8_mmx2)
#define x264_pixel_noise_8x16_mmx2 x264_template(pixel_noise_8x16_mmx2)
#define x264_pixel_noise_8x8_mmx2 x264_template(pixel_noise_8x8_mmx2)
#define x264_pixel_noise_8x4_mmx2 x264_template(pixel_noise_8x4_mmx2)
#define x264_pixel_noise_4x16_mmx2 x264_template(pixel_noise_4x16_mmx2)
#define x264_pixel_noise_4x8_mmx2 x264_template(pixel_noise_4x8_mmx2)
#define x264_pixel_noise_4x4_mmx2 x264_template(pixel_noise_4x4_mmx2)

22nd March 2019, 17:08	#1 \| Link
jpsdr Registered User Join Date: Oct 2002 Location: France Posts: 2,316	[Solved] Implementing t_mod patches on r2969 As i've said, i'm trying to implement t_mod patches on r2969. I'm stuck with an issue i'm unable to solve... nasm throw a warning i can't get rid of, and i don't understand the reason of it. Building for 10 bits works, building for 8 bits didn't, a lot of unresolved symbol on final link phase. I'm unable to understand why this happens. Is there someone who have the time and who can help me ? __________________ My github. Last edited by jpsdr; 25th March 2019 at 14:45.

25th March 2019, 14:46	#2 \| Link
jpsdr Registered User Join Date: Oct 2002 Location: France Posts: 2,316	Finaly, after long strugle, solved...! __________________ My github.

27th March 2019, 21:57	#3 \| Link
Blue_MiSfit Derek Prestegard IRL Join Date: Nov 2003 Location: Los Angeles Posts: 5,989	Maybe post how you fixed it?