Media Player Classic - BE Win32/x64

[Klaus1189]

I cannot find a problem of syntax of the file, but for grammar mistakes I can not help because I don’t understand that language
Please check the new translation when a nightly build is available if every new string is correct and no typo is in the translation. I must also say, well done many translated strings, I know how time consuming that is but MPC-BE is worth every minute I spent for the translation. Coded with passion for perfection by the devs

[s0meone_new]

Yes, yes and YES!
Tomorrow it will be completely ready.
Cool?

Please check it out: https://www105.zippyshare.com/v/KgEfERMY/file.html
90% it will be complete tomorrow.

[Liisachan]

When MP4 has 2 or more cover arts, [Shift]+[F10] -> resources shows only one (the first?) embedded file, if the internal MP4/MOV source filter is enabled in MPC-BE. If the internal filter is disabled (MPC-BE + LAV) or MPC-HC is used, you can see all embedded files via [Shift]+[F10].

Not a big problem at all; happened to notice.

Sample MP4 (55 KiB) with 2 cover arts (PNG, Jpeg)

[s0meone_new]

Hungarian translation finished!
https://www101.zippyshare.com/v/pSDLUE88/file.html

[Aleksoid1978]

Originally Posted by Liisachan

When MP4 has 2 or more cover arts, [Shift]+[F10] -> resources shows only one (the first?) embedded file, if the internal MP4/MOV source filter is enabled in MPC-BE. If the internal filter is disabled (MPC-BE + LAV) or MPC-HC is used, you can see all embedded files via [Shift]+[F10].

Not a big problem at all; happened to notice.

Sample MP4 (55 KiB) with 2 cover arts (PNG, Jpeg)

Thanks - fixed

[v0lt]

@s0meone_new
Thank. Updated in r4885.

[s0meone_new]

where is the r4885 installer available? I can't verify it.

[ryrynz]

Originally Posted by s0meone_new

where is the r4885 installer available? I can't verify it.

Wait, they will update. Beta links a page or two back.

[Liisachan]

Originally Posted by Aleksoid1978

Thanks - fixed

Tested 4885 with a sample MP4 (no video, silent audio + 3 cover arts in BMP/PNG/JPG). Everything works fine! Thanks

But I have 2 questions:
1) dataType 0x1b (for BMP) seems undocumented. do we really have to support non-standard BMP cover arts? It won't hurt though...
2) does the GETU32(db->GetData()) check in MP4Splitter.cpp necessary? I'm guessing something like this might be simpler and quicker:

if (dataType == 0x0d) { /* jpeg */ }
else if (dataType == 0x0e) { /* png */ }
else if (dataType == 0x1b) { /* bmp */ } // if to be supported at all

[Aleksoid1978]

Originally Posted by Liisachan

But I have 2 questions:
1) dataType 0x1b (for BMP) seems undocumented. do we really have to support non-standard BMP cover arts? It won't hurt though...
2) does the GETU32(db->GetData()) check in MP4Splitter.cpp necessary? I'm guessing something like this might be simpler and quicker:

if (dataType == 0x0d) { /* jpeg */ }
else if (dataType == 0x0e) { /* png */ }
else if (dataType == 0x1b) { /* bmp */ } // if to be supported at all

Why it for you ?

[Liisachan]

Originally Posted by Aleksoid1978

Why it for you ?

I'm not sure if I'm understanding correctly, but currently we're reading the first 4 bytes "sync" from the image data, and we decide it's JPEG if (sync & 0x00ffffff) == 0x00FFD8FF, and it's PNG if sync == MAKEFOURCC(0x89, 'P', 'N', 'G').
Isn't it faster and cleaner to just use the variable dataType, without actually peeking into the image raw data?

[s0meone_new]

I checked the Hungarian translation in r4885. I fixed some things.
https://www77.zippyshare.com/v/3FVSmk2u/file.html

[Aleksoid1978]

Originally Posted by Liisachan

I'm not sure if I'm understanding correctly, but currently we're reading the first 4 bytes "sync" from the image data, and we decide it's JPEG if (sync & 0x00ffffff) == 0x00FFD8FF, and it's PNG if sync == MAKEFOURCC(0x89, 'P', 'N', 'G').
Isn't it faster and cleaner to just use the variable dataType, without actually peeking into the image raw data?

ffmpeg also with checking data type - also check first bytes from data

[Grimsdyke]

Is 'jump to: frame' currently broken ?? No problems with HC.
Would it be possible to also implement a 'frame backwards' function ??

[huhn]

control arrow key left.

[Liisachan]

Originally Posted by Aleksoid1978

ffmpeg also with checking data type - also check first bytes from data

I guess there is some historical reason, then. Checking the image data helps if the tagging tool is broken and doesn't write the atom flag properly (0x0d for Jpeg, 0x0e for PNG). Probably ffmpeg devs had such broken samples and decided that they couldn't trust the atom flag.

Not a big problem Everything is working for me anyway. Thanks again!

[v0lt]

@s0meone_new
Thank. Updated in r4887.

[s0meone_new]

v0lt:
Thank. I checked it. The last fix:
https://www55.zippyshare.com/v/YaSx3d1q/file.html

Thanks for everything. All the best.

[Klaus1189]

I beg for a new Nightly build of MPC Video Renderer, mine is several days old

[v0lt]

@Klaus1189
MPCVideoRenderer-v0.3.3.934_git2019.11.08-e04319e was uploaded yesterday.

@s0meone_new
Translation updated in r4889.

MPCVideoRenderer-v0.3.3.936_git2019.11.09-3dcf99a