Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
4th November 2019, 22:28 | #6841 | Link |
Registered User
Join Date: Feb 2015
Location: Bavaria
Posts: 1,667
|
I cannot find a problem of syntax of the file, but for grammar mistakes I can not help because I don’t understand that language
Please check the new translation when a nightly build is available if every new string is correct and no typo is in the translation. I must also say, well done many translated strings, I know how time consuming that is but MPC-BE is worth every minute I spent for the translation. Coded with passion for perfection by the devs |
4th November 2019, 23:34 | #6842 | Link |
Registered User
Join Date: Oct 2019
Posts: 124
|
Yes, yes and YES!
Tomorrow it will be completely ready. Cool? Please check it out: https://www105.zippyshare.com/v/KgEfERMY/file.html 90% it will be complete tomorrow. Last edited by s0meone_new; 5th November 2019 at 04:02. |
5th November 2019, 21:46 | #6843 | Link |
李姗倩 Lǐ Shān Qiàn
Join Date: Nov 2002
Posts: 1,340
|
mp4 source filter: minor problem
When MP4 has 2 or more cover arts, [Shift]+[F10] -> resources shows only one (the first?) embedded file, if the internal MP4/MOV source filter is enabled in MPC-BE. If the internal filter is disabled (MPC-BE + LAV) or MPC-HC is used, you can see all embedded files via [Shift]+[F10].
Not a big problem at all; happened to notice. Sample MP4 (55 KiB) with 2 cover arts (PNG, Jpeg) |
6th November 2019, 00:01 | #6844 | Link |
Registered User
Join Date: Oct 2019
Posts: 124
|
Hungarian translation finished!
https://www101.zippyshare.com/v/pSDLUE88/file.html Last edited by s0meone_new; 6th November 2019 at 00:17. |
6th November 2019, 06:05 | #6845 | Link | |
Registered User
Join Date: Apr 2008
Location: Russia, Vladivostok
Posts: 2,787
|
Quote:
__________________
AMD Ryzen 5 3600 /GIGABYTE B450 Gaming X /Patriot 32Gb@3200 /Kingston 500Gb M.2 /RTX 4060 /Samsung U28R550UQI /OLED Philips 55OLED707 /Yamaha RX-V471 + NS-555 + NS-C444 + NS-333 + YST-SW215 |
|
6th November 2019, 13:03 | #6846 | Link |
Registered User
Join Date: Dec 2008
Posts: 1,968
|
@s0meone_new
Thank. Updated in r4885.
__________________
MPC-BE 1.7.0 and Nightly builds | VideoRenderer | ImageSource | ScriptSource | BassAudioSource |
7th November 2019, 12:45 | #6849 | Link |
李姗倩 Lǐ Shān Qiàn
Join Date: Nov 2002
Posts: 1,340
|
Tested 4885 with a sample MP4 (no video, silent audio + 3 cover arts in BMP/PNG/JPG). Everything works fine! Thanks
But I have 2 questions: 1) dataType 0x1b (for BMP) seems undocumented. do we really have to support non-standard BMP cover arts? It won't hurt though... 2) does the GETU32(db->GetData()) check in MP4Splitter.cpp necessary? I'm guessing something like this might be simpler and quicker: Code:
if (dataType == 0x0d) { /* jpeg */ } else if (dataType == 0x0e) { /* png */ } else if (dataType == 0x1b) { /* bmp */ } // if to be supported at all |
7th November 2019, 14:01 | #6850 | Link | |
Registered User
Join Date: Apr 2008
Location: Russia, Vladivostok
Posts: 2,787
|
Quote:
__________________
AMD Ryzen 5 3600 /GIGABYTE B450 Gaming X /Patriot 32Gb@3200 /Kingston 500Gb M.2 /RTX 4060 /Samsung U28R550UQI /OLED Philips 55OLED707 /Yamaha RX-V471 + NS-555 + NS-C444 + NS-333 + YST-SW215 |
|
7th November 2019, 14:11 | #6851 | Link |
李姗倩 Lǐ Shān Qiàn
Join Date: Nov 2002
Posts: 1,340
|
I'm not sure if I'm understanding correctly, but currently we're reading the first 4 bytes "sync" from the image data, and we decide it's JPEG if (sync & 0x00ffffff) == 0x00FFD8FF, and it's PNG if sync == MAKEFOURCC(0x89, 'P', 'N', 'G').
Isn't it faster and cleaner to just use the variable dataType, without actually peeking into the image raw data? |
8th November 2019, 00:46 | #6852 | Link |
Registered User
Join Date: Oct 2019
Posts: 124
|
I checked the Hungarian translation in r4885. I fixed some things.
https://www77.zippyshare.com/v/3FVSmk2u/file.html |
8th November 2019, 09:48 | #6853 | Link | |
Registered User
Join Date: Apr 2008
Location: Russia, Vladivostok
Posts: 2,787
|
Quote:
__________________
AMD Ryzen 5 3600 /GIGABYTE B450 Gaming X /Patriot 32Gb@3200 /Kingston 500Gb M.2 /RTX 4060 /Samsung U28R550UQI /OLED Philips 55OLED707 /Yamaha RX-V471 + NS-555 + NS-C444 + NS-333 + YST-SW215 |
|
8th November 2019, 15:17 | #6856 | Link | |
李姗倩 Lǐ Shān Qiàn
Join Date: Nov 2002
Posts: 1,340
|
Quote:
Not a big problem Everything is working for me anyway. Thanks again! |
|
9th November 2019, 06:52 | #6857 | Link |
Registered User
Join Date: Dec 2008
Posts: 1,968
|
@s0meone_new
Thank. Updated in r4887.
__________________
MPC-BE 1.7.0 and Nightly builds | VideoRenderer | ImageSource | ScriptSource | BassAudioSource |
9th November 2019, 08:16 | #6858 | Link |
Registered User
Join Date: Oct 2019
Posts: 124
|
v0lt:
Thank. I checked it. The last fix: https://www55.zippyshare.com/v/YaSx3d1q/file.html Thanks for everything. All the best. |
9th November 2019, 19:20 | #6860 | Link |
Registered User
Join Date: Dec 2008
Posts: 1,968
|
@Klaus1189
MPCVideoRenderer-v0.3.3.934_git2019.11.08-e04319e was uploaded yesterday. @s0meone_new Translation updated in r4889. MPCVideoRenderer-v0.3.3.936_git2019.11.09-3dcf99a
__________________
MPC-BE 1.7.0 and Nightly builds | VideoRenderer | ImageSource | ScriptSource | BassAudioSource Last edited by v0lt; 9th November 2019 at 19:24. |
Thread Tools | Search this Thread |
Display Modes | |
|
|