xy-VSFilter Project (High Performance VSFilter Compatible Subtitle Filters)

[madshi]

Thanks, it's good to see minor stability updates...

[kasper93]

Why you don't want to enable SSE (1)?

Tapatalk 4 @ GT-I9300

[Sarasa]

Originally Posted by cyberbeing

XySubFilter 3.1.0.697 Beta2 has been released

XySubFilter Beta2 .7z Archive (32-bit) | XySubFilter Beta2 .7z Archive (64-bit)

...

Copy/paste gone bad ?
your links have an 7z extension but the github one are zip

[andyvt]

Originally Posted by cyberbeing

XySubFilter 3.1.0.697 Beta2 has been released

XySubFilter Beta2 .7z Archive (32-bit) | XySubFilter Beta2 .7z Archive (64-bit)

Debug Symbols for XySubFilter 3.1.0.697

Features & Changes

• Update Cache defaults (LV1 256->2048, LV4 512->768)
• Disable /arch:SSE2 in VS2012/VS2013 builds

Bug Fix

• Unable to load subtitle files with uppercase file extension
• Correct a parser check which broke loading of script embedded UUE fonts
• Revert Insane Border Support (temporary crash fix)

This release is a minor update of XySubFilter 3.1.0.682 Beta2.

Does this include the patch to query the EVR presenter for ISubRenderConsumer?

[clsid]

Pull request looks good. NoExtensions is fine too is you prefer that.

Can you also commit your interlacing fix? Here is another patch for that by kasper93:
https://github.com/kasper93/mpc-hc/commit/d8ff6fac333b9602b6cc9865d4998f36cf479f2b

It would also be trivial to apply all the mpc-hc backports and fixes of Jeeb's clone to the vsfilter_rc branch.

[cyberbeing]

I've silently replaced the 3.1.0.697 VS2013 build links with VS2010 builds. I'd encourage everyone who downloaded prior to this post to re-download.

There seems to be a VS2012/VS2013 compiler related performance regression found, which hurts performance greatly on scripts which make heavy use of \clip.

For whatever reason, the code VS2010 generates is around 2x faster on such scripts.

Originally Posted by kasper93

Why you don't want to enable SSE (1)?

Since it doesn't result in a measurable improvement of performance for our filters. Visual Studio also seem to have a tendency to convert fast C code into slow SSE code in some cases.

I see no reason to break compatibility, unless doing so offered some benefit to our users.

Originally Posted by Sarasa

Copy/paste gone bad ?
your links have an 7z extension but the github one are zip

Yep, copy/paste gone bad. First post was correct, but I copied from that older Beta2 thread post which never got updated for that 7z to zip link change. Fixed now.

Originally Posted by andyvt

Does this include the patch to query the EVR presenter for ISubRenderConsumer?

No, not yet. I'm still waiting for our developer to look over and approve those changes. He seems to be busy, as I haven't been able to get in contact with him at all during the past month.

Originally Posted by clsid

Can you also commit your interlacing fix?

Once I figure out what we are doing for our next xy-VSFilter release, that change will be committed.

I had my own version and a test build posted here around a month ago. I've not had a chance to test kasper93's variation yet, and it seems it still hasn't been merged into MPC-HC master.

At this point, I was just awaiting JEEB to make a final decision about how this change should be implemented, and merge it into his CCCP branch.

[kasper93]

Originally Posted by cyberbeing

Since it doesn't result in a measurable improvement of performance for our filters. Visual Studio also seem to have a tendency to convert fast C code into slow SSE code in some cases.

Fair enough. It indeed depends on your code and what do you need.

Originally Posted by cyberbeing

I had my own version and a test build posted here around a month ago. I've not had a chance to test kasper93's variation yet, and it seems it still hasn't been merged into MPC-HC master.

It will be merged soon, after next stable in fact which will be hotfix for PGS crash. We plan to release tomorrow or so. That's why this changes wait that long.

[Aranzabal]

When I dont use xysubfilter, I can see subtitles in the black bar, so is it about xysubfilter or madvr?

xysubfilter options don't have this "position subtitles relative to the video frame" option.

[cyberbeing]

Originally Posted by Aranzabal

When I dont use xysubfilter, I can see subtitles in the black bar, so is it about xysubfilter or madvr?

It's about madVR. Supporting this is something madshi has stated is high priority on his to-do list. I'd hope that MPC-HC will eventually support this for their their EVR-CP/VMR9 subtitle consumer as well, but I haven't heard anything. XySubFilter itself added support for black bar rendering and subtitle repositioning (untested) almost 1 year ago now, so all we can do is wait patiently.

Originally Posted by Aranzabal

xysubfilter options don't have this "position subtitles relative to the video frame" option.

SubRenderIntf.h was implemented in such a way that the Subtitle Consumer is required to initiate the request for subtitle repositioning. Since there is no way for Subtitle Providers to force such a behavior, having an 'enable' option in XySubFilter would only be confusing to the user. Depending on how Subtitle Consumers choose to support this, its more likely that XySubFilter would gain an option like "never position subtitles outside the video frame" to disable automated black bar rendering.

[clsid]

@cyberbeing
In the build script of vsfilter_rc branch you should replace "3.0.0.4" with "3.0.0.211" (and +4 with +211 in the line below).

[cyberbeing]

Originally Posted by clsid

@cyberbeing
In the build script of vsfilter_rc branch you should replace "3.0.0.4" with "3.0.0.211" (and +4 with +211 in the line below).

Any particular reason?

[clsid]

Otherwise it will result in an incorrect version calculation due to the non-existent tag 3.0.0.4 in that branch.

[cyberbeing]

The 3.0.0.4 tag should now exist once again. I accidentally removed it last week when I was pruning non-release tags, since I had forgotten it was used for this purpose.

[mahoushounen]

For some reason subtitle drag-n-drop doesn't work with latest XySubFilter. Am I doing something wrong or is this the filter's shortcoming?

[cyberbeing]

Only MPC-BE supports drag-n-drop functionality with XySubFilter currently.
[note: there seems to be a regression in the r4913 MPC-BE nightly, so grab the previous r4901 nightly or 1.4.2 stable]

For MPC-HC we have a ticket open here requesting they backport the behavior.

[mahoushounen]

Originally Posted by cyberbeing

Only MPC-BE supports drag-n-drop functionality with XySubFilter currently.
[note: there seems to be a regression in the r4913 MPC-BE nightly, so grab the previous r4901 nightly or 1.4.2 stable]

Will try it out, thanks.

[cyberbeing]

Just note that if your video does not have any auto-loaded embedded/external subtitles, you would need to configure XySubFilter settings to "Always Load" so it will be present in the graph before you drag-n-drop.

[Skymil]

Hello,

I'm not sure if it's the right place to ask this, please forgive me if it's not the case.

Before I was able to display two subtitles at the same time by using XySubFilter + the internal subtitles renderer of MPC-HC.
But now, it doesn't work anymore.
I've tried to change a lot of options from the LAV Splitter to MPC-HC.
If XySubFilter is loaded, the internal subtitles renderer displays nothing.
But if XySubFilter is not loaded, it's possible to use the internal renderer.
I have :
MPC-HC 1.7.5
madVR 0.87.10
XySubFilter 3.1.0.697
LAV Audio Decoder + Video Decoder + Splitter 0.61.2

Do you have any idea where this issue comes from?

[cyberbeing]

See: MPC-HC Ticket #4231 for details and the new solution.

[Skymil]

It works great now thank you (and sorry I checked the tickets but didn't found this one)!