Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > General > Subtitles

Reply
 
Thread Tools Search this Thread Display Modes
Old 5th August 2018, 00:28   #941  |  Link
FranceBB
Broadcast Encoder
 
FranceBB's Avatar
 
Join Date: Nov 2013
Location: Germany
Posts: 633
Quote:
Originally Posted by pinterf View Post
Download xy-VSFilter / XySubFilter v3.1.0.800

Code:
-- Native support for YUV420P10 and YUV420P16 formats in Avisynth filter TextSub and probably VobSub.
thank you very much indeed for making it available in 10bit and 16bit!!

I don't have to do this anymore:

Code:
#Hardsub 8bit
s16 = last
DitherPost (mode=-1)
TextSub("Ep1.ass")
 
#Overlay 8bit subs to 16bit video
Dither_convert_8_to_16 ()
s16.Dither_limit_dif16 (last, thr=1.0, elast=2.0)
Thank you!!

Quote:
Originally Posted by hello_hello View Post
pinterf,
I'm having an issue with VSFilter 3.1.0.800.
Full XP discloser: I'm running XP.

If I have VSFilter in a script it results in the following error when I try to preview it in AvsPmod:

LoadPlugin: unable to load "C:\Program Files\MeGUI\tools\avisynth_plugin\VSFilter.dll", error=0x3e6
That's because when he compiled he didn't target XP in Visual Studio 2017.
The dll calls DeleteProcThreadAttributeList and InitializeProcThreadAttributeList that are missing in the XP kernel.
__________________
Broadcast Encoder
LinkedIn

Last edited by FranceBB; 5th August 2018 at 01:53.
FranceBB is online now   Reply With Quote
Old 6th August 2018, 09:38   #942  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 1,240
for hello_hello's problem:
Quote:
Originally Posted by FranceBB View Post
That's because when he compiled he didn't target XP in Visual Studio 2017.
The dll calls DeleteProcThreadAttributeList and InitializeProcThreadAttributeList that are missing in the XP kernel.
Actually vsfilter was compiled with the v141_xp toolset with the usual /Zc:threadSafeInit- option.
pinterf is offline   Reply With Quote
Old 6th August 2018, 20:25   #943  |  Link
FranceBB
Broadcast Encoder
 
FranceBB's Avatar
 
Join Date: Nov 2013
Location: Germany
Posts: 633
That's weird, 'cause I tried to run it on an XP virtual machine just to be sure and it doesn't recognise the command "TextSub()" with the new DLL, 'cause it fails to load and when I opened it with Dependency Walker I noticed these two missing function calls.

(And by the way, I have all the C++ Redistributable on my VM 2005 - 2017 and it's an AVX2 capable CPU, although XP supports up to SSE4.2 only).
__________________
Broadcast Encoder
LinkedIn
FranceBB is online now   Reply With Quote
Old 28th August 2018, 12:18   #944  |  Link
Siso
Registered User
 
Siso's Avatar
 
Join Date: Sep 2013
Location: Bulgaria
Posts: 392
Can anyone help me with xy-vsfilter 3.0.0.400, when I watch 1.85:1 movies the subtitles are in high quality. But when I watch 2.35:1 or 2.40:1 movies, the subtitles quality is low...
Siso is offline   Reply With Quote
Old 28th August 2018, 13:06   #945  |  Link
sneaker_ger
Registered User
 
Join Date: Dec 2002
Posts: 5,436
xy-vsfilter renders the subtitles at the video resolution. So if you want to increase quality you would have to upscale (at least the chroma) in the chain before the picture reaches xy-vsfilter.

But it is more straight-forward to use a subtitle renderer that renders at the display resolution to begin with like e.g. the internal subtitle renderer (ISR) of MPC-HC or XySubFilter.
sneaker_ger is offline   Reply With Quote
Old 28th August 2018, 13:31   #946  |  Link
jmonier
Registered User
 
Join Date: Oct 2008
Posts: 183
Quote:
Originally Posted by Siso View Post
Can anyone help me with xy-vsfilter 3.0.0.400, when I watch 1.85:1 movies the subtitles are in high quality. But when I watch 2.35:1 or 2.40:1 movies, the subtitles quality is low...
Are you using madVR as the renderer and LAV Splitter? xy-vsfilter interfaces directly with them and then should not have the problem you are seeing.
jmonier is offline   Reply With Quote
Old 28th August 2018, 14:19   #947  |  Link
Siso
Registered User
 
Siso's Avatar
 
Join Date: Sep 2013
Location: Bulgaria
Posts: 392
Quote:
Originally Posted by jmonier View Post
Are you using madVR as the renderer and LAV Splitter? xy-vsfilter interfaces directly with them and then should not have the problem you are seeing.
Yes I'm using madvr and lav filters.
Siso is offline   Reply With Quote
Old 28th August 2018, 14:20   #948  |  Link
Siso
Registered User
 
Siso's Avatar
 
Join Date: Sep 2013
Location: Bulgaria
Posts: 392
Quote:
Originally Posted by sneaker_ger View Post
xy-vsfilter renders the subtitles at the video resolution. So if you want to increase quality you would have to upscale (at least the chroma) in the chain before the picture reaches xy-vsfilter.

But it is more straight-forward to use a subtitle renderer that renders at the display resolution to begin with like e.g. the internal subtitle renderer (ISR) of MPC-HC or XySubFilter.
Is the bug with the italics has been fixed in xysubfilter?
Siso is offline   Reply With Quote
Old 28th August 2018, 15:17   #949  |  Link
sneaker_ger
Registered User
 
Join Date: Dec 2002
Posts: 5,436
Madshi released a fixed version for it. I think it's still not in pinterf's fork, though.

https://forum.doom9.org/showthread.p...84#post1839284
sneaker_ger is offline   Reply With Quote
Old 28th August 2018, 19:53   #950  |  Link
Siso
Registered User
 
Siso's Avatar
 
Join Date: Sep 2013
Location: Bulgaria
Posts: 392
Quote:
Originally Posted by sneaker_ger View Post
Madshi released a fixed version for it. I think it's still not in pinterf's fork, though.

https://forum.doom9.org/showthread.p...84#post1839284
Thank you for the link.
Siso is offline   Reply With Quote
Old 4th September 2018, 12:14   #951  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 1,240
New build, download v3.1.0.801

An issue with random x64 crashes was reported on git and it looked interesting enough

Then I have found some "new" commits in the original rc4 branch, including the fix for italics issue, so I included them also. I hope they work, there are quite a few branches there.

Note: as original authors have said, treat this version as a beta.
Note2: I'm just a re-builder and not developer of the product. Use my build as-is.

Warning: problems under xp reported, despite my v141_xp settings.

Code:
v3.1.0.801 (20180904)
- fix random crash in x64 build (address truncated to 32 bits, Rasterizer::Draw and Rasterizer::FillSolidRect were affected)
- XySubFilter.DLL now compiled with v141_xp toolset instead of v141 (like VSFilter.DLL)
- From upstream (madshi, Cyberbeing)
  - Fix a possible infinite loop in the Real Text subtitle parser on 64-bit
  - Fix external SRT subtitles with italic tag not being flagged as repositionable
  - Disable repositioning for SSA/ASS subtitles with default position level
  - Add setting to allow repositioning of SSA/ASS dialog

Last edited by pinterf; 7th September 2018 at 10:12. Reason: xp warning
pinterf is offline   Reply With Quote
Old 7th September 2018, 00:40   #952  |  Link
FranceBB
Broadcast Encoder
 
FranceBB's Avatar
 
Join Date: Nov 2013
Location: Germany
Posts: 633
Quote:
- XySubFilter.DLL now compiled with v141_xp toolset instead of v141 (like VSFilter.DLL)
Still, VSFilter 3.1.0.801 doesn't work on my XP Professional (with Microsoft Extended Support) with Avisynth+ r2728.
None of your modified version work on XP, even though you compiled with v141_xp.
I have all the C++ Redistributable installed, from 2005 to 2017, by the way.

I tried with a simple script, but AVSPmod didn't recognize the command "TextSub" in the first place.


When I tried to run it:


So I tried to run AVSMeter and it reported "Invalid Access Memory Location (998)".


I decided to investigate why and it seems that two kernel calls are missing in Windows XP: InitializeProcThreadAttributeList and DeleteProcThreadAttributeList.
Unfortunately, these two functions have been introduced in Windows Vista.

InitializeProcThreadAttributeList is a bool.
It returns a zero value if it fails or a non-zero value if it succeeds.
It has lpAttributeList (which is the attribute list and it can be NULL to determine the buffer size required to support the specified number of attributes), dwAttributeCount (which is the count of attributes to be added to the list), dwFlags (which is a reserved parameter and it must be zero) and lpSize.

Code:
BOOL InitializeProcThreadAttributeList(
  LPPROC_THREAD_ATTRIBUTE_LIST lpAttributeList,
  DWORD                        dwAttributeCount,
  DWORD                        dwFlags,
  PSIZE_T                      lpSize
);
DeleteProcThreadAttributeList is a void and thus it does not return a value. It simply has lpAttributeList which is the attribute list created by the InitializeProcThreadAttributeList function.

Code:
void DeleteProcThreadAttributeList(
  LPPROC_THREAD_ATTRIBUTE_LIST lpAttributeList
);

I took a look at Wine and it seems that they implemented the call, so I tried to take their implementation and use it as a wrapper to basically direct the call to it instead of to the kernel, but unfortunately it didn't work (I messed it up when I tried to adapt it, I'm 100% sure).
Any thoughts?

__________________
Broadcast Encoder
LinkedIn
FranceBB is online now   Reply With Quote
Old 7th September 2018, 09:39   #953  |  Link
nevcairiel
Registered Developer
 
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 9,760
Going multiple levels down in Dependency Walker is not meaningful, since you cannot control what other DLLs use. You can only check what your own DLL imports directly, and if those are fine then thats not it. From the error it sounds like the DLL crashes on load, not that it fails to load due to missing symbols.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders
nevcairiel is offline   Reply With Quote
Old 7th September 2018, 10:07   #954  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 1,240
Don't know, what happens, all I have found is:
https://developercommunity.visualstu...-target-s.html
And the DLLs were compiled with /MT instead of /MD, so no redistributables are needed.
pinterf is offline   Reply With Quote
Old 7th September 2018, 15:34   #955  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 1,747
Stupid question, you didn't forget the /Zc:threadSafeInit- option ?
__________________
My github.
jpsdr is offline   Reply With Quote
Old 10th September 2018, 06:38   #956  |  Link
tonyxc600
Registered User
 
Join Date: Apr 2018
Posts: 1
Trying to open external PGS subtitles (whether autoloading or manual) results in my player freezing for extended periods of time, and when it does finally load the text is either greatly out of sync or don't display at all.

Muxing the subs into the video allows it to load correctly. The issue is also consistently reproducible when I extract subs from any video and try to load them externally.

Is this a known issue with external PGS subs?
tonyxc600 is offline   Reply With Quote
Old 10th September 2018, 15:40   #957  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 1,240
Quote:
Originally Posted by jpsdr View Post
Stupid question, you didn't forget the /Zc:threadSafeInit- option ?
No, it's there.
pinterf is offline   Reply With Quote
Old 20th September 2018, 18:29   #958  |  Link
Siso
Registered User
 
Siso's Avatar
 
Join Date: Sep 2013
Location: Bulgaria
Posts: 392
Do the subtitle output options in XYVsfilter - YCbCr level range "auto" and YCbCr matrix should always be on "auto"? In the OSD when they are on auto it says Colorspace: TV BT.601(auto), if I set the matrix to "guess" it says TV BT.709 (Guessed). I watch only BT.709 content. Which option is the right one?

Last edited by Siso; 20th September 2018 at 18:36.
Siso is offline   Reply With Quote
Old 20th September 2018, 19:06   #959  |  Link
huhn
Registered User
 
Join Date: Oct 2012
Posts: 5,778
leave it at the default settings because this topic is very simple and very complicated at the same time.

the issue comes from the software creating the ASS sub titles usual aegisub which doesn'T really care about color matrix in the past and was using BT 601.

the content you watch is not of important it is the ass sub colors relative to the video.
it get's really complicated on how they fixed this issue.
huhn is offline   Reply With Quote
Old 20th September 2018, 19:08   #960  |  Link
Siso
Registered User
 
Siso's Avatar
 
Join Date: Sep 2013
Location: Bulgaria
Posts: 392
Quote:
Originally Posted by huhn View Post
leave it at the default settings because this topic is very simple and very complicated at the same time.

the issue comes from the software creating the ASS sub titles usual aegisub which doesn'T really care about color matrix in the past and was using BT 601.

the content you watch is not of important it is the ass sub colors relative to the video.
it get's really complicated on how they fixed this issue.
My subtitles are in srt, but I guess the defaults will work, right huhn?
Siso is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 09:24.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.