Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Capturing and Editing Video > Avisynth Development

Reply
 
Thread Tools Search this Thread Display Modes
Old 26th June 2020, 08:17   #561  |  Link
vcmohan
Registered User
 
Join Date: Jul 2003
Location: India
Posts: 890
Problem with SetLogParams opening file?

I have been updating my plugins for the 3.6 version and correcting for earlier using IScriptEnvironment2.
A particular function SegAmp in my modPlus plugin I modified and tested fully in 3.5 version v6 and even had a bench mark run. I then tested in 3.6 v8. While all other functions were running OK, this particular function gave an error "error Reading Source Frame 0, Avisynth Read Error: SetLogParams. could not open file "po"for writing. I was using colorbars as input. I then converted to YV24. It ran OK. I then commented out converttoYV24(), reverting back to earlier color space. Curiously it now ran and I could even bench mark.
What could be the problem?
__________________
mohan
my plugins are now hosted here
vcmohan is offline   Reply With Quote
Old 26th June 2020, 10:01   #562  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 2,309
Quote:
Originally Posted by MeteorRain View Post
memcpy_amd
asm_BitBlt_ISSE

How about bitblt / memcpy code? They should only work faster on old CPU and only on 32-bit. std::copy should give very optimal performance.
I've left them active only for pre-avx processors.
pinterf is offline   Reply With Quote
Old 26th June 2020, 11:12   #563  |  Link
MeteorRain
結城有紀
 
Join Date: Dec 2003
Location: NJ; OR; Shanghai
Posts: 894
Did some quick benchmark on L5506 (took me a long time to find a non-avx user).

memcpy_amd is slightly slower than system memcpy and std::copy, by about 3%. On sandy bridge it's running 15% slower. On a modern Ryzen it's running half the speed.

asm_BitBlt_ISSE is not quick either. The core code is movntq / _mm_stream_pi which uses 64 bit registers, not a modern SSE 128bit registers.

My personal opinion is there's no need to keep this ancient code. (Considering this is still called ISSE, which is probably optimized against Pentium 4 or earilier.)
__________________
Projects
x265 - Yuuki-Asuna-mod Download / GitHub
TS - ADTS AAC Splitter | LATM AAC Splitter | BS4K-ASS
Neo AviSynth+ filters - F3KDB | FFT3D | DFTTest | MiniDeen | Temporal Median

Last edited by MeteorRain; 26th June 2020 at 11:15.
MeteorRain is offline   Reply With Quote
Old 26th June 2020, 15:37   #564  |  Link
tormento
Acid fr0g
 
tormento's Avatar
 
Join Date: May 2002
Location: Italy
Posts: 2,542
Is there a reason of the AviSynth installer including colors_rgb.avsi + colors_rgb.txt and the "files only" not?
__________________
@turment on Telegram
tormento is offline   Reply With Quote
Old 26th June 2020, 15:42   #565  |  Link
qyot27
...?
 
qyot27's Avatar
 
Join Date: Nov 2005
Location: Florida
Posts: 1,419
Quote:
Originally Posted by MeteorRain View Post
asm_BitBlt_ISSE is not quick either. The core code is movntq / _mm_stream_pi which uses 64 bit registers, not a modern SSE 128bit registers.

My personal opinion is there's no need to keep this ancient code. (Considering this is still called ISSE, which is probably optimized against Pentium 4 or earilier.)
SSE2 introduced the 128-bit registers for integer operations. First-generation SSE (Pentium III) re-used the MMX registers.
qyot27 is offline   Reply With Quote
Old 26th June 2020, 17:40   #566  |  Link
MeteorRain
結城有紀
 
Join Date: Dec 2003
Location: NJ; OR; Shanghai
Posts: 894
I have to say, translating those MMX code to SSE is pain nass. ResampleAudio took me hours and I'm only half done.
__________________
Projects
x265 - Yuuki-Asuna-mod Download / GitHub
TS - ADTS AAC Splitter | LATM AAC Splitter | BS4K-ASS
Neo AviSynth+ filters - F3KDB | FFT3D | DFTTest | MiniDeen | Temporal Median
MeteorRain is offline   Reply With Quote
Old 27th June 2020, 07:59   #567  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 2,309
Service announcement, I'll be *offline for two weeks.
*not doing any serious work other than running and will have limited PC access; my reactions on questions will be lagging a bit.
pinterf is offline   Reply With Quote
Old 27th June 2020, 10:33   #568  |  Link
StainlessS
HeartlessS Usurer
 
StainlessS's Avatar
 
Join Date: Dec 2009
Location: Over the rainbow
Posts: 10,980
Missing you already
__________________
I sometimes post sober.
StainlessS@MediaFire ::: AND/OR ::: StainlessS@SendSpace

"Some infinities are bigger than other infinities", but how many of them are infinitely bigger ???
StainlessS is offline   Reply With Quote
Old 27th June 2020, 20:18   #569  |  Link
FranceBB
Broadcast Encoder
 
FranceBB's Avatar
 
Join Date: Nov 2013
Location: Royal Borough of Kensington & Chelsea, UK
Posts: 2,883
Quote:
Originally Posted by pinterf View Post
Service announcement, I'll be *offline for two weeks.
*not doing any serious work other than running and will have limited PC access; my reactions on questions will be lagging a bit.
You deserve this two weeks holiday after all you've done, Ferenc.
I'm already looking forward for you to come back.
FranceBB is offline   Reply With Quote
Old 2nd July 2020, 18:08   #570  |  Link
ChaosKing
Registered User
 
Join Date: Dec 2005
Location: Germany
Posts: 1,795
Was this ported from neo avs+ ? https://forum.doom9.org/showthread.p...06#post1859306
I saw Filtergraph.cpp in https://github.com/pinterf/AviSynthP...ilterGraph.cpp
but with avs+ 3.4 it says DumpFilterGraph() is unknown.


EDIT
whoops why am I still on 3.4. Installed avs 3.6 and it works now

If someone wants to test it, you need to call SetGraphAnalysis(true) at the beginning of your script and DumpFilterGraph the end.
__________________
AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth
VapourSynth Portable FATPACK || VapourSynth Database

Last edited by ChaosKing; 2nd July 2020 at 18:16.
ChaosKing is offline   Reply With Quote
Old 3rd July 2020, 19:34   #571  |  Link
Nuihc88
Registered User
 
Nuihc88's Avatar
 
Join Date: Oct 2016
Location: Tellus, Milky Way Galaxy
Posts: 21
Here's a few problems i've been encountering with v3.6.1 and later builds:

1. Some test builds are giving me occasional Access Violations and silent crashes while seeking during realtime playback; i get far more of the former with test8 than test6, test4 & test5 seem to be working most reliably for me. Seeking or pausing for extended periods of time during realtime playback seems to be the surest way to trigger it, even so it only happens about 1 out of every 50 tries. Each build handles the issue differently and gives a slightly different error, always starting with 0xC0000005, when one is given at all.
2. Sometimes realtime playback never recovers on it's own after presentation queue drops to zero, despite there being enough computational power for it. Seems to have about 50% chance of occurring.
3. After test6, playback recovery behavior has changed for the worse, if a script is too heavy, instead of just dropping interpolated frame(s), video sometimes starts lagging behind the audio.
4. Final 3.6.1 build (r3300) and later are causing hard lockups with PotPlayer.

I'm guessing that all of above is due to memory leak(s) somewhere. Perhaps someone can verify if they're getting the same ones...


There's also this older problem with Prefetch, which may warrant investigation at some point:

When using multiple instances of Prefetch (with SVPflow filters) there are times when the same frame is returned two times in a row.
In realtime playback usage this can also cause both sync-drifting and occasional jerky movements (without frame drops or glitches showing up in MadVR's OSD).
Frame repeats become more frequent with each additional Prefetch buffer, regardless of whether it's from an additional Prefetch instance or thread and rate of occurrence doesn't seem to scale with buffer size or latency.
Latencies reported by MadVR also more than double every time a new Prefetch thread is added. Thread count of other filters doesn't have nearly as much impact on latency.

I have been trying to gather more detailed information on the nature of the issue for the past month, but haven't managed to figure out a whole lot. I'm guessing that there's probably an off-by-one bug somewhere within cache management.


My test environment is 64bit Win7, running 32bit AviSynth+ through PotPlayer, ffdshow and MadVR.

Last edited by Nuihc88; 16th July 2020 at 02:24. Reason: Problem 2 seems harder to pin down as i initially thought, also clarifications, and never forget about OCD :-P
Nuihc88 is offline   Reply With Quote
Old 3rd July 2020, 22:06   #572  |  Link
manolito
Registered User
 
manolito's Avatar
 
Join Date: Sep 2003
Location: Berlin, Germany
Posts: 3,078
Can you reproduce all of these issues when using AVS+ 3.5.1 32-bit? I have this feeling that merging the features from the AVS+ Neo fork are responsible for most of these issues.

With the plugins I use AVS+ 3.6.1 is now just as stable as version 3.5.1, but I really see no advantage whatsoever over 3.5.1. It's all in the name of progress...
manolito is offline   Reply With Quote
Old 3rd July 2020, 22:45   #573  |  Link
Nuihc88
Registered User
 
Nuihc88's Avatar
 
Join Date: Oct 2016
Location: Tellus, Milky Way Galaxy
Posts: 21
Quote:
Originally Posted by manolito View Post
Can you reproduce all of these issues when using AVS+ 3.5.1 32-bit? I have this feeling that merging the features from the AVS+ Neo fork are responsible for most of these issues.
I really only started checking and testing pinterf's builds on regular basis after he started merging stuff from the Neo fork and AVS+ inherited it's realtime speed and latency benefits.

v3.5.2 builds were fairly stable for me, but i did get an occasional Access Violation at least with some of those too. Realtime usage has a tendency to highlight stability problems that are far less often encountered in 'normal' use; repeatedly seeking back on a scene to optimize script performance, even more so.
In my much earlier notes i had marked r2772 & r2923 as exceptionally stable, but even between those, some builds were far less so, which is one of the reasons i'm suspecting that there's a memory leak somewhere.

I don't think the Prefetch issues could have even been detected before the merge, as Neo was too unstable and AVS+ too slow and inflexible to test with. In any case, the new version of the Prefetch function performs far faster with one thread than the old version ever did with any value.

Last edited by Nuihc88; 4th July 2020 at 04:17. Reason: clarifications
Nuihc88 is offline   Reply With Quote
Old 4th July 2020, 05:45   #574  |  Link
real.finder
Registered User
 
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
this work fine for me

Code:
mp_pipeline("""
### dll: Avisynth-3.6.2_20200624_test1-filesonly\x64\AviSynth.dll
ColorBars(width=640, height=480, pixel_type="yv12")
admfilter(custom_filter="dfttest(Sigma=(adSigma+1.0)/f)")
Prefetch(4)
### ###
""")
it was not before https://forum.doom9.org/showthread.p...31#post1904931

admfilter is in AdvancedDenoising.avsi and it also need this
__________________
See My Avisynth Stuff

Last edited by real.finder; 4th July 2020 at 05:50.
real.finder is offline   Reply With Quote
Old 5th July 2020, 07:19   #575  |  Link
real.finder
Registered User
 
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
pinterf, if you have time, can you please check this? https://forum.doom9.org/showthread.p...85#post1917585
__________________
See My Avisynth Stuff
real.finder is offline   Reply With Quote
Old 6th July 2020, 21:28   #576  |  Link
gispos
Registered User
 
Join Date: Oct 2018
Location: Germany
Posts: 996
Quote:
Originally Posted by real.finder View Post
this work fine for me

Code:
mp_pipeline("""
### dll: Avisynth-3.6.2_20200624_test1-filesonly\x64\AviSynth.dll
ColorBars(width=640, height=480, pixel_type="yv12")
admfilter(custom_filter="dfttest(Sigma=(adSigma+1.0)/f)")
Prefetch(4)
### ###
""")
it was not before https://forum.doom9.org/showthread.p...31#post1904931

admfilter is in AdvancedDenoising.avsi and it also need this
admfilter(custom_filter="dfttest(Sigma=(adSigma+1.0)/f)")

Please help me.
I don't know what 'color_white' means. (AdvancedDenoising.avsi, line 107)

Zs_RF_Shared.avsi is loaded.
__________________
Live and let live
gispos is offline   Reply With Quote
Old 6th July 2020, 23:21   #577  |  Link
StainlessS
HeartlessS Usurer
 
StainlessS's Avatar
 
Join Date: Dec 2009
Location: Over the rainbow
Posts: 10,980
Quote:
I don't know what 'color_white' means.
colors_rgb.avsi, installed along with Avisynth/+
Code:
# ...
global color_violet                 = $EE82EE
global color_wheat                  = $F5DEB3
global color_white                  = $FFFFFF
global color_whitesmoke             = $F5F5F5
global color_yellow                 = $FFFF00
global color_yellowgreen            = $9ACD32
# ...
EDIT: Maybe that color_white should be replaced with $FFFFFF, should not really need to install an avsi just to use an obvious definition.
__________________
I sometimes post sober.
StainlessS@MediaFire ::: AND/OR ::: StainlessS@SendSpace

"Some infinities are bigger than other infinities", but how many of them are infinitely bigger ???

Last edited by StainlessS; 6th July 2020 at 23:31.
StainlessS is offline   Reply With Quote
Old 7th July 2020, 04:19   #578  |  Link
gispos
Registered User
 
Join Date: Oct 2018
Location: Germany
Posts: 996
Quote:
Originally Posted by StainlessS View Post
colors_rgb.avsi, installed along with Avisynth/+
Thanks StainlessSS, It must have been lost. I have to google it.
__________________
Live and let live
gispos is offline   Reply With Quote
Old 7th July 2020, 07:35   #579  |  Link
tormento
Acid fr0g
 
tormento's Avatar
 
Join Date: May 2002
Location: Italy
Posts: 2,542
Quote:
Originally Posted by StainlessS View Post
colors_rgb.avsi, installed along with Avisynth/+
As I reported earlier, it's not included in the "file only" version.
__________________
@turment on Telegram
tormento is offline   Reply With Quote
Old 7th July 2020, 08:01   #580  |  Link
LigH
German doom9/Gleitz SuMo
 
LigH's Avatar
 
Join Date: Oct 2001
Location: Germany, rural Altmark
Posts: 6,753
May require a "supplement" files archive in addition to the "file only" archive...
__________________

New German Gleitz board
MediaFire: x264 | x265 | VPx | AOM | Xvid
LigH is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 23:12.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.