KNLMeansCL: OpenCL NLMeans de-noising algorithm [2018-01-29]

[feisty2]

the latest OpenCL driver should be shipped with the latest video card driver, download the latest video card driver and reinstall it.
and also the Intel OpenCL package for CPUs, https://software.intel.com/en-us/art...opencl-drivers, no x86 version since that crap is obsolete and we're all on x64 now
after the driver reinstallation, copy Program Files\NVIDIA Corporation\OpenCL\OpenCL.dll to SysWOW64 folder and rename Program Files\NVIDIA Corporation\OpenCL\OpenCL64.dll to OpenCL.dll and copy it to System32

[Groucho2004]

Originally Posted by johnmeyer

(P.S. I went to my Windows 7 boot partition and tried it with that installation, but got the same results, so I don't think it is Windows XP Pro SP3 that is the cause).

Maybe your graphics card is not supported. What card do you have?

[dipje]

Originally Posted by johnmeyer

It's in the System32 folder. I too thought it might be the problem, but I can't find any link to a newer one. I think the one I was installed by the nVidia driver installer.

just a reminder (and 'to be sure'). If you are on a 64 bit OS: 64bit DLLs go into c:\windows\system32, 32bit DLLs go into c:\windows\syswow64.

If you're still tring with 32bit avisynth and 32bit knlmeanscl, did you copy the 32bit opencl.dll to the right folder? (or at least first tried with the version already on your system, the supplied .dll file is only for troubleshooting).

[johnmeyer]

My graphic card is the Nvidia GeForce 9800GTX 512M PCIe2.0 16x.

My computer is dual boot, with WinXP Pro 32-bit on one drive and Win7 64-bit on a second drive. I have tried both installations, and they both behave the same. The XP installation has the OpenCL.DLL in the c:\windows\system32 folder. It is dated 7/9/2010. The Win7 installation has OpenCL.DLL in the c:\windows\SysWOW64 folder. It is dated 2/25/2013. There is also an nvopencl.dll in that folder as well as a IntelOpenCL32.DLL. The first two also appear in the c:\windows\system32 folder along with IntelOpenCL64.DLL.

The OpenCL.DLL in my XP installation is version 1.0.0 and is signed by the Khronos Group.

We are all focusing on this as the problem, and perhaps it is, but the fact that it exists and is in the correct folder makes me think I'd get a different error message than the one which says the KNLMeansCL.DLL won't load.

BTW, my NVidia drivers are not the latest for my older card because the newer drivers don't work with Sony Vegas, the NLE I use every day.

[Groucho2004]

Originally Posted by johnmeyer

My graphic card is the Nvidia GeForce 9800GTX 512M PCIe2.0 16x.

That card does only support OpenCL 1.1. You have to use an older version of KNLMeansCL, see here, last paragraph.
I'm not sure about the minimum required driver version but I think it has to be at least something like 3xx.xx.

Edit: Just googled - it should be at least 258.19 for OpenCL 1.1.

Edit2: As for the correct OpenCL.dll - There should be one in "Program Files\NVIDIA Corporation\OpenCL". This is in most cases the right one to use. If you have an older version in your system32 directory, make a backup of it and then overwrite it with the one from the NVIDIA directory.

[johnmeyer]

Originally Posted by Groucho2004

That card does only support OpenCL 1.1. You have to use an older version of KNLMeansCL, see here, last paragraph.

Bingo!

The older version, coupled with the older redistributable works. Many thanks.

[Groucho2004]

Originally Posted by johnmeyer

Bingo!

The older version, coupled with the older redistributable works. Many thanks.

I'm glad you got it sorted. You should still clean up your plugin directory.

For example mixing old and new, 2.5 and 2.6 versions of plugins is not recommended:

[CPP 2.5 / 32 Bit plugins]
C:\Program Files\AviSynth 2.5\plugins\mt_masktools-25.dll  [2.0.48.0]
C:\Program Files\AviSynth 2.5\plugins\mt_masktools-26.dll  [2.0.48.0]
C:\Program Files\AviSynth 2.5\plugins\RoboCrop.dll
C:\Program Files\AviSynth 2.5\plugins\RT_Stats.dll

[CPP 2.6 / 32 Bit plugins]
C:\Program Files\AviSynth 2.5\plugins\masktools2.dll  [2.1.0.0]
C:\Program Files\AviSynth 2.5\plugins\RoboCrop26.dll
C:\Program Files\AviSynth 2.5\plugins\RT_Stats26.dll

Also, your DGDecode.dll is very old, update it to the latest version unless you have a reason to stick with the old one.

[johnmeyer]

I don't use DGDecode except to troubleshoot other people's programs, but I definitely need to sort out the masktools conflicts/redundancies. Thanks!

[StainlessS]

Also these are conflicting, pick only one (SSE2).

C:\Program Files\AviSynth 2.5\plugins\RemoveDirt.dll
C:\Program Files\AviSynth 2.5\plugins\RemoveDirtSSE2.dll

[mp3dom]

Uhm, I don't know if it was already covered, but I'm getting the following problem:

OpenCL Platform
------------------------------------------------------------
 CL_PLATFORM_VENDOR:                Advanced Micro Devices, Inc.
 CL_PLATFORM_NAME:                  AMD Accelerated Parallel Processing
 CL_PLATFORM_VERSION:               OpenCL 2.0 AMD-APP (2236.10)
 CL_PLATFORM_PROFILE:               FULL_PROFILE

 OpenCL Device
------------------------------------------------------------
 CL_DEVICE_VENDOR:                  GenuineIntel
 CL_DEVICE_NAME:                    Intel(R) Core(TM) i7 CPU         920  @ 2.67GHz
 CL_DRIVER_VERSION:                 2236.10 (sse2)
 CL_DEVICE_VERSION:                 OpenCL 1.2 AMD-APP (2236.10)
 CL_DEVICE_PROFILE:                 FULL_PROFILE
 CL_DEVICE_IMAGE_SUPPORT:           1
 CL_DEVICE_IMAGE2D_MAX_WIDTH:       8192
 CL_DEVICE_IMAGE2D_MAX_HEIGHT:      8192
 CL_DEVICE_IMAGE_MAX_ARRAY_SIZE:    2048

 Program Build
------------------------------------------------------------
 CL_PROGRAM_BUILD_OPTIONS:          -cl-single-precision-constant
                                    -cl-denorms-are-zero
                                    -cl-fast-relaxed-math
                                    -Werror        
                                    -D NLM_CLIP_TYPE_STACKED
                                    -D NLM_CLIP_REF_LUMA
                                    -D NLM_WMODE_WELSCH
                                    -D VI_DIM_X=1440
                                    -D VI_DIM_Y=1080
                                    -D HRZ_RESULT=3
                                    -D VRT_RESULT=3        
                                    -D HRZ_BLOCK_X=16
                                    -D HRZ_BLOCK_Y=8 
                                    -D VRT_BLOCK_X=16
                                    -D VRT_BLOCK_Y=8        
                                    -D NLM_D=1
                                    -D NLM_S=4
                                    -D NLM_H=1.200000
                                    -D NLM_WREF=1.000000


Warnings being treated as errors
"C:\Users\usr\AppData\Local\Temp\OCL123264T1.cl", line 19: error: global
          variable declaration is corrected by the compiler to have addrSpace
          constant
  const sampler_t nne = CLK_NORMALIZED_COORDS_FALSE | CLK_ADDRESS_NONE  | CLK_FILTER_NEAREST;                      
                  ^

"C:\Users\usr\AppData\Local\Temp\OCL123264T1.cl", line 20: error: global
          variable declaration is corrected by the compiler to have addrSpace
          constant
  const sampler_t clm = CLK_NORMALIZED_COORDS_FALSE | CLK_ADDRESS_CLAMP | CLK_FILTER_NEAREST;

Using latest AviSynth+ in both x86/x64.
Is the card not supported?
Thanks.

[Khanattila]

Originally Posted by mp3dom

Uhm, I don't know if it was already covered, but I'm getting the following problem:

OpenCL Platform
------------------------------------------------------------
 CL_PLATFORM_VENDOR:                Advanced Micro Devices, Inc.
 CL_PLATFORM_NAME:                  AMD Accelerated Parallel Processing
 CL_PLATFORM_VERSION:               OpenCL 2.0 AMD-APP (2236.10)
 CL_PLATFORM_PROFILE:               FULL_PROFILE

 OpenCL Device
------------------------------------------------------------
 CL_DEVICE_VENDOR:                  GenuineIntel
 CL_DEVICE_NAME:                    Intel(R) Core(TM) i7 CPU         920  @ 2.67GHz
 CL_DRIVER_VERSION:                 2236.10 (sse2)
 CL_DEVICE_VERSION:                 OpenCL 1.2 AMD-APP (2236.10)
 CL_DEVICE_PROFILE:                 FULL_PROFILE
 CL_DEVICE_IMAGE_SUPPORT:           1
 CL_DEVICE_IMAGE2D_MAX_WIDTH:       8192
 CL_DEVICE_IMAGE2D_MAX_HEIGHT:      8192
 CL_DEVICE_IMAGE_MAX_ARRAY_SIZE:    2048

 Program Build
------------------------------------------------------------
 CL_PROGRAM_BUILD_OPTIONS:          -cl-single-precision-constant
                                    -cl-denorms-are-zero
                                    -cl-fast-relaxed-math
                                    -Werror        
                                    -D NLM_CLIP_TYPE_STACKED
                                    -D NLM_CLIP_REF_LUMA
                                    -D NLM_WMODE_WELSCH
                                    -D VI_DIM_X=1440
                                    -D VI_DIM_Y=1080
                                    -D HRZ_RESULT=3
                                    -D VRT_RESULT=3        
                                    -D HRZ_BLOCK_X=16
                                    -D HRZ_BLOCK_Y=8 
                                    -D VRT_BLOCK_X=16
                                    -D VRT_BLOCK_Y=8        
                                    -D NLM_D=1
                                    -D NLM_S=4
                                    -D NLM_H=1.200000
                                    -D NLM_WREF=1.000000


Warnings being treated as errors
"C:\Users\usr\AppData\Local\Temp\OCL123264T1.cl", line 19: error: global
          variable declaration is corrected by the compiler to have addrSpace
          constant
  const sampler_t nne = CLK_NORMALIZED_COORDS_FALSE | CLK_ADDRESS_NONE  | CLK_FILTER_NEAREST;                      
                  ^

"C:\Users\usr\AppData\Local\Temp\OCL123264T1.cl", line 20: error: global
          variable declaration is corrected by the compiler to have addrSpace
          constant
  const sampler_t clm = CLK_NORMALIZED_COORDS_FALSE | CLK_ADDRESS_CLAMP | CLK_FILTER_NEAREST;

Using latest AviSynth+ in both x86/x64.
Is the card not supported?
Thanks.

Do not worry about this error.
The final version will work normally.

[Khanattila]

When the API has bugs: https://www.khronos.org/bugzilla/show_bug.cgi?id=397

[mp3dom]

Good to know that, thanks!

[MysteryX]

Does KNLMeans now support AVS+'s native 16-bit clips as input and output? I don't see such a feature in the change log.

[Reel.Deel]

Originally Posted by MysteryX

Does KNLMeans now support AVS+'s native 16-bit clips as input and output? I don't see such a feature in the change log.

Not yet but:

Originally Posted by Khanattila

Yes, it requires no extra work for me.

[Khanattila]

Originally Posted by Reel.Deel

Not yet but:

I'm thinking about what formats to support, probably the same as VapourSynth.

Greyscale: 8-bit, 16-bit, 32-bit
YUV: 8-bit, 10-bit, 16-bit, 32-bit
Packed RGB: 8-bit, 16-bit, 32-bit

All other formats are useless.

[MysteryX]

I was also considering the exact same question for AviSynthShader. Since the GPU processing is done with UINT16 and half-float data, converting to-from 10, 12 or 14 bits is useless. If the user wants 10-bit output, he'll get a 16-bit output from the GPU, then he can ditter it down to 10-bit.

[feisty2]

half precision is not meant for processing, it's meant for storing.

[MysteryX]

Originally Posted by feisty2

half precision is not meant for processing, it's meant for storing.

GPU does processing with half-float and can't work well with INT. CPU does processing with INT and can't work well with half-float.

[feisty2]

Originally Posted by MysteryX

GPU does processing with half-float.

bullshit, GPU works with different sizes of floats, half is a very low precision one and should not be used for processing, it was designed to reduce the bandwidth of data transferring (storing, not processing, half precision arithmetics are not any faster than single precision arithmetics)