Vapoursynth

[lansing]

Originally Posted by feisty2

no, it sends the collected messages TO stderr BY USING vsapi->logMessage(), read the documentation of vaporsynth's C API. any string passed to logMessage() already automatically appears in vsedit, you don't need any extra stuff.

So the chain would be like this?

collected messages -> dummy vs filter -> inside dummy vs filter -> logMessage()

[feisty2]

yes,,,

[lansing]

Originally Posted by feisty2

yes,,,

Thanks, I'll work on it.

[feisty2]

@Myrsloik
should I release *frameData instantly if an exception is thrown from the arAllFramesReady branch? or should I just leave it unhandled and expect it gets deleted when getFrame() is invoked again with arError?

basically, this

try {
    if (auto& ResourceHandle = reinterpret_cast<ResourceType*&>(*frameData); activationReason == arInitial)
        ResourceHandle = new auto{ FilterInstance->AcquireResources(...) };
    else if (activationReason == arAllFramesReady) {
        auto ManagedResourceHandle = std::unique_ptr<ResourceType>{ ResourceHandle };
        auto GeneratedFrame = FilterInstance->DrawFrame(*ManagedResourceHandle, ...);
        // if DrawFrame() throws an exception, *ResourceHandle is instantly released
        // by the destructor of std::unique_ptr

        return GeneratedFrame.ReleaseOwnership();
    }
    else if (activationReason == arError)
        delete ResourceHandle;
        // possible double-free here?

    return nullptr;
}
catch (RuntimeError& ErrorMessage) {
    FrameContext.RaiseError(ErrorMessage);
    return nullptr;
}

or this

try {
    if (auto& ResourceHandle = reinterpret_cast<ResourceType*&>(*frameData); activationReason == arInitial)
        ResourceHandle = new auto{ FilterInstance->AcquireResources(...) };
    else if (activationReason == arAllFramesReady) {
        auto GeneratedFrame = FilterInstance->DrawFrame(*ResourceHandle, ...);
        // no leak if DrawFrame() throws an exception
        // *ResourceHandle will be released later from the arError branch

        delete ResourceHandle;
        return GeneratedFrame.ReleaseOwnership();
    }
    else if (activationReason == arError)
        delete ResourceHandle;
    return nullptr;
}
catch (RuntimeError& ErrorMessage) {
    FrameContext.RaiseError(ErrorMessage);
    return nullptr;
}

?

[Myrsloik]

Originally Posted by feisty2

@Myrsloik
should I release *frameData instantly if an exception is thrown from the arAllFramesReady branch? or should I just leave it unhandled and expect it gets deleted when getFrame() is invoked again with arError?

basically, this
...
?

You can't get an "exception" or error in arAllFramesReady. All frames are already successfully produced so I'm not sure what you're asking. And if there is an error arAllFramesReady won't be called, only arError, so obviously you should free the frameData there.

[feisty2]

the exception is thrown from the user defined function DrawFrame() when for instance, a required frame property is missing from the input (basically any situation that involves setFilterError() in a C plugin).

[feisty2]

oh I see, I think I kinda get it now, so arError indicates error getting an input frame, not error in an attempt to generate an output frame, is that right?

[Myrsloik]

Originally Posted by feisty2

oh I see, I think I kinda get it now, so arError indicates error getting an input frame, not error in an attempt to generate an output frame, is that right?

Exactly!

[lansing]

Originally Posted by lansing

Thanks, I'll work on it.

I have created a dummy filter and passed in a list from the script to the filter, but I couldn't figure out the right syntax to retrieve it in C.

script

core.vsedit.Logger(["message 1", "message 2"])

dummy.c

static void VS_CC logger(VSMap* in, VSMap* out, void *userData, VSCore* core, const VSAPI* vsapi) {
    char messages[] = vsapi->propGetData(in, "name", 0, NULL);

    int i = 0;
    while (messages[i]) {
        vsapi->logMessage("WARNING", messages[i]);        
        i++;
    }
}

VS_EXTERNAL_API(void) VapourSynthPluginInit(VSConfigPlugin configFunc, VSRegisterFunction registerFunc, VSPlugin* plugin) {
    configFunc("com.vsedit.logger", "vsedit", "VapourSynth Logger", VAPOURSYNTH_API_VERSION, 1, plugin);
    registerFunc("Logger", "name:data[]", &logger, 0, plugin);
}

I couldn't get this to compile.

[feisty2]

auto logger(auto in, auto, auto, auto, auto vsapi) {
    for (auto x : Range{ vsapi->propNumElements(in, "name") })
        vsapi->logMessage(VSMessageType::mtWarning, vsapi->propGetData(in, "name", x, nullptr));
}

[feisty2]

char messages[] = vsapi->propGetData(in, "name", 0, NULL);

apparently you're not very familiar with C constructs, you cannot initialize a char array from a pointer (note that string literals are of type const char[N], not const char*, an array type can decay to a pointer type, but arrays and pointers are distinct entities). it's better if you just avoid C stuff all together.

[lansing]

Originally Posted by feisty2

apparently you're not very familiar with C constructs, you cannot initialize a char array from a pointer (note that string literals are of type const char[N], not const char*, an array type can decay to a pointer type, but arrays and pointers are distinct entities). it's better if you just avoid C stuff all together.

Yes C is confusing to me, it gave me a headache even trying to do simple thing like converting int to string.

[lansing]

I got the dummy filter printing messages now, but for some reason the logging module is not catching warnings on evaluation

import logging

class MessageAbsorber(logging.Handler):
    def __init__(self, message_container):
        logging.Handler.__init__(self)
        self.messageContainer = message_container
    def emit(self, message_record):
        self.messageContainer += [message_record.getMessage()]

WarningMessages = []
logging.captureWarnings(True)
logging.getLogger('py.warnings').addHandler(MessageAbsorber(WarningMessages))

def get_warnings():
    return WarningMessages

import vapoursynth as vs

core = vs.get_core()
core2 = vs.get_core()
core3 = vs.get_core()
clip = core.dgdecodenv.DGSource(r'video.dgi')
clip.set_output()

core.vsedit.Logger(get_warnings())

The same codes worked on PyCharm, but in vseditor, I'm getting error about the WarningMessages list still being empty. It will print if I passed in a list core.vsedit.Logger(["message1", "message2"])

Update: I think the reason for this is because vs disabled the warnings so they aren't even logged.

[feisty2]

@Myrsloik
Does the flags field of the VSVideoInfo object passed to setVideoInfo() partially determine the cache mode of the output node (along with the flags argument passed to createFilter()), or is it simply ignored?

[Myrsloik]

Originally Posted by feisty2

@Myrsloik
Does the flags field of the VSVideoInfo object passed to setVideoInfo() partially determine the cache mode of the output node (along with the flags argument passed to createFilter()), or is it simply ignored?

It's simply ignored and is filled out with the flags passed to createFilter()

[lansing]

What is the correct scenario for use of setting max cache size? I have a 1080i source with QTGMC(Preset='Medium'), setting max cache size to 4000 MB will give me a "script exceeded memory limit" warning, raising it to 12,000 MB will clear the warning, but there is no difference in speed on benchmark at 41 fps.

[feisty2]

Originally Posted by lansing

I got the dummy filter printing messages now, but for some reason the logging module is not catching warnings on evaluation

The same codes worked on PyCharm, but in vseditor, I'm getting error about the WarningMessages list still being empty. It will print if I passed in a list core.vsedit.Logger(["message1", "message2"])

Update: I think the reason for this is because vs disabled the warnings so they aren't even logged.

add these 2 lines

import logging
import warnings

class MessageAbsorber(logging.Handler):
    def __init__(self, MessageContainer):
        logging.Handler.__init__(self)
        self.MessageContainer = MessageContainer
    def emit(self, MessageRecord):
        self.MessageContainer += [MessageRecord.getMessage()]

WarningMessages = []
warnings.simplefilter('always')
logging.captureWarnings(True)
logging.getLogger('py.warnings').addHandler(MessageAbsorber(WarningMessages))

# user script goes here

core.vsedit.PrintWarnings(WarningMessages)

[feisty2]

@Myrsloik
could you add

const char* getPluginName(VSPlugin*);
const char* getPluginNamespace(VSPlugin*);
const char* getPluginIdentifier(VSPlugin*);
const char* getPluginFunctionArguments(VSPlugin*, const char* functionName);

to APIv3? so the instantiation of a single plugin object or plugin func object can get rid of the super expensive getPlugins() or getFunctions()