Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > General > Subtitles

Reply
 
Thread Tools Search this Thread Display Modes
Old 30th September 2014, 09:09   #661  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,140
Looks like a little bug in XySubFilter, but it's not dramatic, IMHO. Why double checking the type if the parameter is already hard coded to ISubRenderFrame? Yeah, sure, doesn't hurt to double check, I guess. But if XySubFilter sent in something other than ISubRenderFrame, incorrectly type-converted to ISubRenderFrame, that would be a dramatic bug, IMHO. FWIW, madVR doesn't check the parameter type, IIRC, and it works just fine.

In any case, fixing this in XySubFilter should be a 2 minute job, it should definitely be done.
madshi is offline   Reply With Quote
Old 30th September 2014, 09:17   #662  |  Link
Zachs
Suptitle, MediaPlayer.NET
 
Join Date: Nov 2001
Posts: 1,721
This is critical if it is to be used in. NET. You can't cast it to the right type otherwise.
Zachs is offline   Reply With Quote
Old 30th September 2014, 10:15   #663  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,140
Why would you need to cast it *at all*? The DeliverFrame() method should already provide the interface in the right type. So a cast should not be necessary.

Anyway, as I said, it should be easy to fix. Unfortunately the XySubFilter developer is currently not active. If you need this fix urgently, you may have to implement the fix yourself...
madshi is offline   Reply With Quote
Old 30th September 2014, 10:30   #664  |  Link
Zachs
Suptitle, MediaPlayer.NET
 
Join Date: Nov 2001
Posts: 1,721
You don't have to cast it. .NET Framework does it internally when the callback occurs. In which case invalid cast exception will be thrown (i.e. cast in .NET on com objects is actually a QI. Marshaling also checks for the correct type before allowing the type to be what the declaration claims it to be).

Edit: not complaining. Just informing. Took me an hour to figure out it's xysubfilter missing a QI export but a minute to fix it.

Last edited by Zachs; 30th September 2014 at 11:23.
Zachs is offline   Reply With Quote
Old 30th September 2014, 11:23   #665  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,140
Ah, I see, thanks. I've zero experience with .NET.
madshi is offline   Reply With Quote
Old 30th September 2014, 11:32   #666  |  Link
Zachs
Suptitle, MediaPlayer.NET
 
Join Date: Nov 2001
Posts: 1,721
You should try c# someday. It was created by the same guy who created turbo pascal and Delphi. Anders Hejlsberg. He simply took Delphi to the next level.
Zachs is offline   Reply With Quote
Old 30th September 2014, 12:05   #667  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,140
I like Delphi a lot. But I dislike the whole .NET concept. I much prefer native compiling/linking over JIT compilation. That's just my personal opinion, of course. And slightly OT here...
madshi is offline   Reply With Quote
Old 30th September 2014, 17:08   #668  |  Link
cyberbeing
Broadband Junkie
 
Join Date: Oct 2005
Posts: 1,859
Looking through the code, I can only assume this was overlooked because the dev wrapped ISubRenderFrame within XySubRenderIntf.h as IXySubRenderFrame (ISubRenderFrame is never used directly anywhere in the code) and it seems he did remember to include IXySubRenderFrame in NonDelegatingQueryInterface.

So is this just a simple fix of adding a single line for ISubRenderFrame to xy_sub_filter.h & xy_sub_filter.cpp or is there more to it than that? As madshi mentioned the developer isn't really active right now, but I could certainly commit trivial changes or merge pull requests myself from github and release a new hotfix build if necessary.
cyberbeing is offline   Reply With Quote
Old 30th September 2014, 23:26   #669  |  Link
Zachs
Suptitle, MediaPlayer.NET
 
Join Date: Nov 2001
Posts: 1,721
Yeah its a single line fix. HotFix would be great! Thanks!
Zachs is offline   Reply With Quote
Old 1st October 2014, 13:29   #670  |  Link
SecurityBunny
Registered User
 
Join Date: Jul 2013
Posts: 76
I would also appreciate a hotfix.

Been noticing quite a few subtitle changes in MPC-HC the last couple of weeks. Hopefully XySubFilter is still faster and preferred for quality. Hoping development kicks back up again sometime soon.
SecurityBunny is offline   Reply With Quote
Old 1st October 2014, 19:37   #671  |  Link
cyberbeing
Broadband Junkie
 
Join Date: Oct 2005
Posts: 1,859
I was only thinking of merging our outstanding pull requests along with the change Zachs requested. I haven't noticed any critically important bugfix in the recent MPC-HC commits, but if I've overlooked something which can be reproduced in XySubFilter, please point out the related MPC-HC commit and I'll look into it.

The XySubFilter developer remains inactive, so development starting back up soon seems very unlikely.
cyberbeing is offline   Reply With Quote
Old 29th October 2014, 02:15   #672  |  Link
ahaha2013
Registered User
 
Join Date: Jun 2014
Posts: 10
This shared file.
http://pan.baidu.com/s/1c0b9tfi

neither xyvsfilter nor xysubfilter can dispay correctly.

mpc-hc built-in: http://i2.tietuku.com/7f9932a98be51711.png

can you fix it...
ahaha2013 is offline   Reply With Quote
Old 29th October 2014, 05:41   #673  |  Link
cyberbeing
Broadband Junkie
 
Join Date: Oct 2005
Posts: 1,859
Quote:
Originally Posted by ahaha2013 View Post
This shared file.
http://pan.baidu.com/s/1c0b9tfi

neither xyvsfilter nor xysubfilter can dispay correctly.

mpc-hc built-in: http://i2.tietuku.com/7f9932a98be51711.png

can you fix it...
I'm not seeing an issue with XySubFilter, at least on our end. Correct 1920x1080 PGS bitmaps are being sent to the subtitle consumer, and are displayed with EVR-CP & madVR. Though both are resizing the bitmap vertically to 1920x800 to match the video resolution, which messes up the aspect ratio and positioning. You'd need to file a bug report with madVR & MPC-HC about that.

With xy-VSFilter, the video needs to be 1920x1080 for Blu-ray PGS subtitles to display. A workaround for cropped video like that one, is to set Vertical Padding to Extend to 16:9.
cyberbeing is offline   Reply With Quote
Old 30th October 2014, 01:15   #674  |  Link
kasper93
MPC-HC Developer
 
Join Date: May 2010
Location: Poland
Posts: 586
Fixed. Will be in next nightly.
kasper93 is offline   Reply With Quote
Old 30th October 2014, 13:28   #675  |  Link
ahaha2013
Registered User
 
Join Date: Jun 2014
Posts: 10
thks.
ahaha2013 is offline   Reply With Quote
Old 30th October 2014, 13:29   #676  |  Link
ahaha2013
Registered User
 
Join Date: Jun 2014
Posts: 10
Quote:
Originally Posted by kasper93 View Post
Fixed. Will be in next nightly.
thks
ahaha2013 is offline   Reply With Quote
Old 11th November 2014, 08:13   #677  |  Link
salam2009
Registered User
 
Join Date: Oct 2014
Posts: 60
Why does xySubFilter get replaced by DirectVobSub when MadVR is disabled?
salam2009 is offline   Reply With Quote
Old 11th November 2014, 09:35   #678  |  Link
cyberbeing
Broadband Junkie
 
Join Date: Oct 2005
Posts: 1,859
xySubFilter requires a subtitle consumer to function.

madVR, EVR-CP (MPC-HC), and VMR9 Renderless (MPC-HC) are currently the only consumers available.
cyberbeing is offline   Reply With Quote
Old 11th November 2014, 10:30   #679  |  Link
andyvt
Registered User
 
Join Date: Jan 2010
Posts: 265
Quote:
Originally Posted by cyberbeing View Post
xySubFilter requires a subtitle consumer to function.

madVR, EVR-CP (MPC-HC), and VMR9 Renderless (MPC-HC) are currently the only consumers available.
+ EVR-CP in MediaBrowser Theater
__________________
babgvant.com
Missing Remote
andyvt is offline   Reply With Quote
Old 11th November 2014, 20:43   #680  |  Link
salam2009
Registered User
 
Join Date: Oct 2014
Posts: 60
I know! I'm using EVR-CP and that's the weird thing!
salam2009 is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 11:48.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.