Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
16th May 2020, 18:38 | #122 | Link |
Registered User
Join Date: Jun 2012
Location: Ibiza, Spain
Posts: 321
|
Instead of:
Code:
#include "Include/fftw3.h" #include "Include/VapourSynth.h" #include "Include/VSHelper.h" Code:
#include "fftw3.h" #include "VapourSynth.h" #include "VSHelper.h" |
16th May 2020, 18:53 | #123 | Link | |
Registered User
Join Date: Dec 2005
Location: Germany
Posts: 1,795
|
Quote:
Generate a very noisy clip and denoise it with mvtools. compare it inside and outside of FrameEval Code:
def mvtoolsDenoise(): .... def abc(n, c): return mvtoolsDenoise(c) clip1 = clip.std.FrameEval(functools.partial(abc, c=clip)) clip2 = mvtoolsDenoise(clip)
__________________
AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth VapourSynth Portable FATPACK || VapourSynth Database Last edited by ChaosKing; 16th May 2020 at 19:06. |
|
16th May 2020, 19:32 | #124 | Link |
I'm Siri
Join Date: Oct 2012
Location: void
Posts: 2,633
|
trivial update:
- the "limit" parameter of mvsf.Degrain now defaults to infinity. it still follows the [0.0, 1.0] range, however out-of-range samples are allowed for floating point clips, which makes infinity the only true "unlimited" bound. |
16th May 2020, 19:57 | #125 | Link | |
I'm Siri
Join Date: Oct 2012
Location: void
Posts: 2,633
|
Quote:
you can check if you are able to reproduce the problem with v11 of jackoneill's branch and if the problem disappears with v12 |
|
16th May 2020, 20:07 | #126 | Link |
Registered User
Join Date: Dec 2005
Location: Germany
Posts: 1,795
|
I just found out that it happens with other filters as well. It was just easier to spot with mvtools-sf because I could use a very large temporal radius with strong denoising. Will post the problem in VS thread again.
__________________
AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth VapourSynth Portable FATPACK || VapourSynth Database |
17th May 2020, 09:47 | #127 | Link | |
I'm Siri
Join Date: Oct 2012
Location: void
Posts: 2,633
|
Quote:
mvtools relies on VSHelper.h relies on VapourSynth.h -> VapourSynth.h must be placed in the mvtools folder you will need 2 copies of VapourSynth.h, one in the "Include" folder and one in the mvtools folder, that doesn't look nice Last edited by feisty2; 17th May 2020 at 09:50. |
|
17th May 2020, 20:33 | #128 | Link | |
Guest
Posts: n/a
|
Quote:
For example in jackoneill's mvtools you'll see the headers are done this way: Code:
#include <limits.h> #include <stdexcept> #include <string> #include <unordered_map> #include <VapourSynth.h> #include <VSHelper.h> #include "Bullshit.h" #include "CPU.h" #include "Fakery.h" #include "MVAnalysisData.h" #include "MVDegrains.h" #include "MVFrame.h" #include "Overlap.h" This is the proper way you should be including the headers. Last edited by amichaelt; 17th May 2020 at 20:45. |
|
17th May 2020, 23:32 | #129 | Link |
Registered User
Join Date: Jun 2012
Location: Ibiza, Spain
Posts: 321
|
Yeah, exactly that.
You make your vsFilterScript install all the headers system wide somewhere like "/usr/include/vsFilterScript" and create pkg-config file for them. Then you just retrieve the path for gcc with pkg-config and you don't need to worry about them. This is good because it's easy to package and it's easy to use for everybody on their own projects. I can send you PR on both projects with build system and edit project files for this (remove the "Include/" bits from them). |
18th May 2020, 11:17 | #130 | Link | |
I'm Siri
Join Date: Oct 2012
Location: void
Posts: 2,633
|
Quote:
|
|
22nd May 2020, 23:33 | #132 | Link |
Registered User
Join Date: Jun 2006
Posts: 452
|
How did you compile it ?
I used the included Meson file and got : Code:
Starting 64bit compilation of global tools 22:05:22 Running git update for vapoursynth-mvtools-sf... 22:05:24 + vapoursynth-mvtools-sf git ................................... [Recently updated] The Meson build system Version: 0.54.1 Source dir: H:/Mingw645/build/vapoursynth-mvtools-sf-git Build dir: H:/Mingw645/build/vapoursynth-mvtools-sf-git/build Build type: native build Using 'PKG_CONFIG_PATH' from environment with value: 'H:\\Mingw645\\local64\\lib\\pkgconfig;H:\\Mingw645\\msys64\\mingw64\\lib\\pkgconfig' Using 'PKG_CONFIG_PATH' from environment with value: 'H:\\Mingw645\\local64\\lib\\pkgconfig;H:\\Mingw645\\msys64\\mingw64\\lib\\pkgconfig' Project name: vapoursynth-mvtools-sf Project version: 10 Using 'CXX' from environment with value: 'ccache g++' Using 'CXXFLAGS' from environment with value: '-mthreads -mtune=native -O2 -pipe' Using 'LDFLAGS' from environment with value: '-pipe -static-libgcc -static-libstdc++' Using 'CPPFLAGS' from environment with value: '-D_FORTIFY_SOURCE=0 -D__USE_MINGW_ANSI_STDIO=1' Using 'CXX' from environment with value: 'ccache g++' Using 'CXXFLAGS' from environment with value: '-mthreads -mtune=native -O2 -pipe' Using 'LDFLAGS' from environment with value: '-pipe -static-libgcc -static-libstdc++' Using 'CPPFLAGS' from environment with value: '-D_FORTIFY_SOURCE=0 -D__USE_MINGW_ANSI_STDIO=1' C++ compiler for the host machine: ccache g++ (gcc 10.1.0 "g++ (Rev2, Built by MSYS2 project) 10.1.0") C++ linker for the host machine: g++ ld.bfd 2.34 Host machine cpu family: x86_64 Host machine cpu: x86_64 Using 'PKG_CONFIG' from environment with value: 'H:/Mingw645/msys64/mingw64/bin/pkg-config --static' Found pkg-config: --static (0.29.2) Using 'PKG_CONFIG_PATH' from environment with value: 'H:\\Mingw645\\local64\\lib\\pkgconfig;H:\\Mingw645\\msys64\\mingw64\\lib\\pkgconfig' Run-time dependency vapoursynth found: YES 50 Using 'PKG_CONFIG_PATH' from environment with value: 'H:\\Mingw645\\local64\\lib\\pkgconfig;H:\\Mingw645\\msys64\\mingw64\\lib\\pkgconfig' Run-time dependency vsfilterscript found: YES 50 Using 'PKG_CONFIG_PATH' from environment with value: 'H:\\Mingw645\\local64\\lib\\pkgconfig;H:\\Mingw645\\msys64\\mingw64\\lib\\pkgconfig' Run-time dependency fftw3 found: YES 3.3.8 Build targets in project: 1 Found ninja.EXE-1.10.0 at H:\Mingw645\msys64\mingw64\bin/ninja.EXE ninja: Entering directory `build' [1/2] Compiling C++ object vapoursynth-mvtools-sf@sha/src_EntryPoint.cxx.obj FAILED: vapoursynth-mvtools-sf@sha/src_EntryPoint.cxx.obj ccache g++ @vapoursynth-mvtools-sf@sha/src_EntryPoint.cxx.obj.rsp ../src/EntryPoint.cxx:1:10: fatal error: Interface.vxx: No such file or directory 1 | #include "Interface.vxx" | ^~~~~~~~~~~~~~~ compilation terminated. ninja: build stopped: subcommand failed. 22:05:27 + Running rustup_update... What am I doing wrong ? Last edited by Pat357; 22nd May 2020 at 23:42. |
22nd May 2020, 23:44 | #133 | Link |
Registered User
Join Date: Jun 2012
Location: Ibiza, Spain
Posts: 321
|
You need to install https://github.com/IFeelBloated/vsFilterScript too.
Your log says: Code:
Run-time dependency vsfilterscript found: YES 50 Code:
Run-time dependency vsfilterscript found: YES 1 |
23rd May 2020, 19:27 | #134 | Link |
Registered User
Join Date: Jun 2006
Posts: 452
|
Thanks for your input, so I got vsfilterscript from repo and installed it first.
Now I got : https://github.com/IFeelBloated/vsFilterScript/issues/3 I reported it with the vsfilterScript because The breaking error seems to be: include/vsFilterScript/Buffer.vxx:14:51: error: 'aligned_alloc' is not a member of 'std'; did you mean 'aligned_union'? Any ideas ? Edit : I think I found the issue on hand here : because Mingw64and even MSVC don't support aligned_alloc, it looks like is simply impossible to compile the current code with Mingw64 gcc / g++. See also https://github.com/IFeelBloated/vapo...s-sf/issues/17. The author stated he will not alter his code for this. That's really a pity. So atm there would be no compiler on a Windows system able to compile the current code. This would be a major issue for a lot of people. How 106062316 managed to get the code compiled on Mingw is beyond me. Last edited by Pat357; 23rd May 2020 at 23:19. |
23rd May 2020, 23:25 | #137 | Link | |
Registered User
Join Date: Jun 2006
Posts: 452
|
Quote:
I'm not a developer and I didn't know the workaround is so simple. Thank you very much for this hint. Got it all working now ! |
|
7th September 2021, 08:44 | #138 | Link |
Registered User
Join Date: Dec 2005
Location: Germany
Posts: 1,795
|
I just tried this example here:
Code:
#MDegrainN sup = core.mvsf.Super(clip) vec = core.mvsf.Analyze(sup, radius=1, overlap=4) vec = core.mvsf.Recalculate(sup, vec, blksize=4, overlap=2) clip = core.mvsf.Degrain(clip, sup, vec, thsad=400) EDIT I used the "r10_pre" binary from github.
__________________
AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth VapourSynth Portable FATPACK || VapourSynth Database Last edited by ChaosKing; 7th September 2021 at 09:35. |
7th September 2021, 09:02 | #139 | Link | |
Registered User
Join Date: Jul 2021
Posts: 26
|
Quote:
|
|
7th September 2021, 09:26 | #140 | Link |
Registered User
Join Date: Dec 2005
Location: Germany
Posts: 1,795
|
You also changed radius to 1?
The compiled binary from here has the same issue, but the frame is black now xD https://forum.doom9.org/showthread.p...69#post1912769
__________________
AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth VapourSynth Portable FATPACK || VapourSynth Database Last edited by ChaosKing; 7th September 2021 at 09:36. |
Thread Tools | Search this Thread |
Display Modes | |
|
|