Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Hardware & Software > Software players

Reply
 
Thread Tools Search this Thread Display Modes
Old 14th October 2019, 18:39   #701  |  Link
adipose
Registered User
 
Join Date: Jul 2010
Posts: 45
Quote:
Originally Posted by Nintendo Maniac 64 View Post
The weird flickering artifact on the seek bar that I showed in my most recent post in this very thread is still occurring with the latest test build.

Is this something that's just inherent to how the dark theme is implemented and therefore a proper fix is not possible without flat-out disabling the dark theme altogether?
I don't think so. What I'm seeing there looks like a resize of the tooltip after display. Overriding windows tooltips is very complicated--there are probably 6 different ways tooltips can be enabled in MFC, and some are easier than others to hijack. I think I handled all of them! But one issue was the size of the tooltip would be based on the default font.

There is something of a "hack" that resizes the tooltip after receiving the new text, which is when it can first calculate the width.

In testing, I do not get any flicker at all in Windows 10. I thought I had eliminated it in Win7 as well, but it appears not.

To clarify, you have Windows 7 using native Classic theme?

I can't imagine why, if you like Win7 classic (which pretty much is exactly what mpc-hc classic looks like), you would be interested in a theme based on Win10 Dark, but I digress

I will take a look.
adipose is offline   Reply With Quote
Old 15th October 2019, 05:37   #702  |  Link
Nintendo Maniac 64
Registered User
 
Nintendo Maniac 64's Avatar
 
Join Date: Nov 2009
Location: Northeast Ohio
Posts: 447
Quote:
Originally Posted by adipose View Post
I can't imagine why, if you like Win7 classic (which pretty much is exactly what mpc-hc classic looks like), you would be interested in a theme based on Win10 Dark, but I digress
It's because I tend to use the high contrast black theme as a form of "night mode" on the classic Windows theme and have been doing so for...I dunno, at least over a decade? (I'm a late adopter in terms of Windows OSes, so I was still using Win2k in the mid 2000s as well as XP in the late 2000s).

However there are certain UI elements in MPC-HC that effectively have invisible text with the high contrast black theme, so I was hoping to use MPC-HC's built-in dark mode instead.
__________________
____HTPC____  | __Desktop PC__
2.93GHz Xeon x3470 (4c/8t Nehalem) | 4.5GHz 1.24v dual-core Haswell G3258
Radeon HD5870  | Intel iGPU      
2x2GB+2x1GB DDR3-1333 | 4x4GB DDR3-1600       
Nintendo Maniac 64 is offline   Reply With Quote
Old 15th October 2019, 06:50   #703  |  Link
adipose
Registered User
 
Join Date: Jul 2010
Posts: 45
Quote:
Originally Posted by Nintendo Maniac 64 View Post
It's because I tend to use the high contrast black theme as a form of "night mode" on the classic Windows theme and have been doing so for...I dunno, at least over a decade? (I'm a late adopter in terms of Windows OSes, so I was still using Win2k in the mid 2000s as well as XP in the late 2000s).

However there are certain UI elements in MPC-HC that effectively have invisible text with the high contrast black theme, so I was hoping to use MPC-HC's built-in dark mode instead.
That makes sense. I think I've fixed the flicker issue in my latest PR. You will have to wait for a new build from clsid.
adipose is offline   Reply With Quote
Old 15th October 2019, 08:09   #704  |  Link
NikosD
Registered User
 
Join Date: Aug 2010
Location: Athens, Greece
Posts: 2,901
Hi.

I've just installed mpcVR latest nightlies for both x86/x64 versions but trying to use them with MPC-HC v1.8.8 x64, I had an issue.

The mpcVR didn't show up in View -> Options... -> Playback -> Output -> DirectShow Video.

How could I use mpcVR x64 renderer with MPC-HC x64 player ?

Thanks!
__________________
Win 10 x64 (19042.572) - Core i5-2400 - Radeon RX 470 (20.10.1)
HEVC decoding benchmarks
H.264 DXVA Benchmarks for all
NikosD is offline   Reply With Quote
Old 15th October 2019, 16:13   #705  |  Link
clsid
*****
 
Join Date: Feb 2005
Posts: 5,642
Select System Default video renderer.
Add mpcVR to external filter list, override its merit to 00800001. Don't set it to prefer, because then VSFilter will not load for subtitles.
clsid is offline   Reply With Quote
Old 15th October 2019, 20:07   #706  |  Link
NikosD
Registered User
 
Join Date: Aug 2010
Location: Athens, Greece
Posts: 2,901
Works like a charm! Thank you!

But since you have even Haali Video Renderer (!) as a separate selection in the drop down menu of renderers, maybe you could put MPC Video Renderer in the front seat too, like all the others.

I don't know if MPC-HC needs a lot of changes to support all of the MPC Video Renderer features, but at least an easy selection of a drop down menu wouldn't be much trouble, I hope.

Anyway, it is the first time for my system to see D3D11VA in native mode (!)
__________________
Win 10 x64 (19042.572) - Core i5-2400 - Radeon RX 470 (20.10.1)
HEVC decoding benchmarks
H.264 DXVA Benchmarks for all
NikosD is offline   Reply With Quote
Old 16th October 2019, 11:20   #707  |  Link
NikosD
Registered User
 
Join Date: Aug 2010
Location: Athens, Greece
Posts: 2,901
Well...

Using my iGPU HD 530 of Core i5 6500 and v6951 driver with Windows 10, I couldn't make it work following the exact same instructions, obviously.

I don't have a dGPU in the system.

Intel's driver problem or MPC Video Renderer ?
__________________
Win 10 x64 (19042.572) - Core i5-2400 - Radeon RX 470 (20.10.1)
HEVC decoding benchmarks
H.264 DXVA Benchmarks for all
NikosD is offline   Reply With Quote
Old 16th October 2019, 11:52   #708  |  Link
Aleksoid1978
Registered User
 
Aleksoid1978's Avatar
 
Join Date: Apr 2008
Location: Russia, Vladivostok
Posts: 2,783
Quote:
Originally Posted by NikosD View Post
Well...

Using my iGPU HD 530 of Core i5 6500 and v6951 driver with Windows 10, I couldn't make it work following the exact same instructions, obviously.

I don't have a dGPU in the system.

Intel's driver problem or MPC Video Renderer ?
Try first with MPC-BE + MPC-VR.
__________________
AMD Ryzen 5 3600 /GIGABYTE B450 Gaming X /Patriot 32Gb@3200 /Kingston 500Gb M.2 /RTX 4060 /Samsung U28R550UQI /OLED Philips 55OLED707 /Yamaha RX-V471 + NS-555 + NS-C444 + NS-333 + YST-SW215
Aleksoid1978 is offline   Reply With Quote
Old 16th October 2019, 12:59   #709  |  Link
NikosD
Registered User
 
Join Date: Aug 2010
Location: Athens, Greece
Posts: 2,901
Quote:
Originally Posted by Aleksoid1978 View Post
Try first with MPC-BE + MPC-VR.
I can see MPC VR working in D3D11 mode and GPU icon left to volume while playing hardware accelerated videos and Input Format of renderer is GPU NV12.

Does MPC-BE have a DXVA2/D3D11VA copy-back mode or is it always in native mode ?

I couldn't find that info inside the app.

UPDATE:
It works with MPC-HC now.
I only re-registered MPC Video Renderer and updated LAV filters internally of MPC-HC to latest nightly.

Except if you have locked MPC VR to work firstly in MPC-BE and then to MPC-HC
__________________
Win 10 x64 (19042.572) - Core i5-2400 - Radeon RX 470 (20.10.1)
HEVC decoding benchmarks
H.264 DXVA Benchmarks for all

Last edited by NikosD; 16th October 2019 at 13:30.
NikosD is offline   Reply With Quote
Old 16th October 2019, 14:45   #710  |  Link
clsid
*****
 
Join Date: Feb 2005
Posts: 5,642
I will add some basic support for it soon. Then it will work with the internal subtitle renderer.
clsid is offline   Reply With Quote
Old 16th October 2019, 18:37   #711  |  Link
NikosD
Registered User
 
Join Date: Aug 2010
Location: Athens, Greece
Posts: 2,901
Quote:
Originally Posted by Aleksoid1978 View Post
Try first with MPC-BE + MPC-VR.
Quote:
Originally Posted by clsid View Post
I will add some basic support for it soon. Then it will work with the internal subtitle renderer.
Thanks for the future update.
It seems it was my bad afterall.
I think I probably didn't check the D3D11 check-box of MPC VR and although LAV filters had D3D11 selected, it was falling back to D3D11 copy-back mode.

One question and one comment:

1) Is it possible to select D3D11 in LAV filters while MPC VR has D3D9 (as I didn't choose D3D11) resulting to D3D11 copy-back ?
A little weird I think.

2) I understand that for compatibility reasons MPC VR has D3D9 as the default mode, but the unique thing of the renderer is D3D11 support.
Sooner than later that mode should be the default, I think.
__________________
Win 10 x64 (19042.572) - Core i5-2400 - Radeon RX 470 (20.10.1)
HEVC decoding benchmarks
H.264 DXVA Benchmarks for all
NikosD is offline   Reply With Quote
Old 16th October 2019, 19:11   #712  |  Link
huhn
Registered User
 
Join Date: Oct 2012
Posts: 7,903
d3d11 native has only a clear advantage in madVR right now because DXVA2 native lowers image quality.

mpc VR is so fast copyback operation have no real impact on it.
it does a copyback operation on my zen 2 with just a couple 100 mhz with like 3 % CPU usage at these clocks where most core are at sleep.

we will see how much it brings when it starts supporting external shaders.
huhn is offline   Reply With Quote
Old 17th October 2019, 19:35   #713  |  Link
clsid
*****
 
Join Date: Feb 2005
Posts: 5,642
I have added support for MPC VR.

Things that work: HW decoding, subs, pan&scan.
Things that don't work yet or aren't supported: Shaders and rotation.

Only issue is a small glitch when going fullscreen while paused. Video is not repainted yet. No issue after resuming playback. Will look into that later.
clsid is offline   Reply With Quote
Old 17th October 2019, 20:43   #714  |  Link
Nintendo Maniac 64
Registered User
 
Nintendo Maniac 64's Avatar
 
Join Date: Nov 2009
Location: Northeast Ohio
Posts: 447
Quote:
Originally Posted by huhn View Post
DXVA2 native lowers image quality
Wait, it does?

I've been using quicksync and copyback decoders for years now anyway so this doesn't affect me, but assuming one is viewing a video with no scaling at all (e.g. a 1080p video on a 1080p screen), does said reduction in image quality with native DXVA2 still occur?
__________________
____HTPC____  | __Desktop PC__
2.93GHz Xeon x3470 (4c/8t Nehalem) | 4.5GHz 1.24v dual-core Haswell G3258
Radeon HD5870  | Intel iGPU      
2x2GB+2x1GB DDR3-1333 | 4x4GB DDR3-1600       
Nintendo Maniac 64 is offline   Reply With Quote
Old 17th October 2019, 20:52   #715  |  Link
nussman
Registered User
 
Join Date: Nov 2010
Posts: 238
DXVA2 native <> hardware decoding with copyback, but huhn is right DXVA2 native can still lower image quality.

P.S. thanks for adding MPC VR support to MPC-HC

Last edited by nussman; 17th October 2019 at 20:56.
nussman is offline   Reply With Quote
Old 17th October 2019, 21:32   #716  |  Link
Asmodian
Registered User
 
Join Date: Feb 2002
Location: San Jose, California
Posts: 4,406
Quote:
Originally Posted by Nintendo Maniac 64 View Post
does said reduction in image quality with native DXVA2 still occur?
Yes. The chroma planes get slightly blurred when copying them to GPU memory that madVR can access.
__________________
madVR options explained
Asmodian is offline   Reply With Quote
Old 17th October 2019, 21:53   #717  |  Link
huhn
Registered User
 
Join Date: Oct 2012
Posts: 7,903
dxva2 native outputs RGB and it is wrongly placed too.
edit on nvidia.
huhn is offline   Reply With Quote
Old 17th October 2019, 23:52   #718  |  Link
Aleksoid1978
Registered User
 
Aleksoid1978's Avatar
 
Join Date: Apr 2008
Location: Russia, Vladivostok
Posts: 2,783
Quote:
Originally Posted by clsid View Post
Only issue is a small glitch when going fullscreen while paused. Video is not repainted yet. No issue after resuming playback. Will look into that later.
You are ignore Paint() and IsRendering().
__________________
AMD Ryzen 5 3600 /GIGABYTE B450 Gaming X /Patriot 32Gb@3200 /Kingston 500Gb M.2 /RTX 4060 /Samsung U28R550UQI /OLED Philips 55OLED707 /Yamaha RX-V471 + NS-555 + NS-C444 + NS-333 + YST-SW215
Aleksoid1978 is offline   Reply With Quote
Old 18th October 2019, 07:23   #719  |  Link
NikosD
Registered User
 
Join Date: Aug 2010
Location: Athens, Greece
Posts: 2,901
Quote:
Originally Posted by clsid View Post
I have added support for MPC VR.
Are there any uploads of nightlies ?
Quote:
Originally Posted by Nintendo Maniac 64 View Post
Wait, it does?
They mean using DXVA2 native with madVR only not with EVR/EVR-CP or mpcVR, I hope.
__________________
Win 10 x64 (19042.572) - Core i5-2400 - Radeon RX 470 (20.10.1)
HEVC decoding benchmarks
H.264 DXVA Benchmarks for all
NikosD is offline   Reply With Quote
Old 18th October 2019, 10:18   #720  |  Link
chros
Registered User
 
chros's Avatar
 
Join Date: Mar 2002
Posts: 2,323
Quote:
Originally Posted by Nintendo Maniac 64 View Post
Wait, it does?
As others said, yes, here's a proper test result, more info about d3d11 by Nev, summary about them by Nev, and here's a GPU performance comparison.
__________________
Ryzen 5 2600,Asus Prime b450-Plus,16GB,MSI GTX 1060 Gaming X 6GB(v398.18),Win10 LTSC 1809,MPC-BEx64+LAV+MadVR,Yamaha RX-A870,LG OLED77G2(2160p@23/24/25/29/30/50/59/60Hz) | madvr config
chros is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 17:01.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.