Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Video Encoding > MPEG-4 AVC / H.264

Reply
 
Thread Tools Search this Thread Display Modes
Old 1st December 2008, 07:26   #1421  |  Link
kemuri-_9
Compiling Encoder
 
kemuri-_9's Avatar
 
Join Date: Jan 2007
Posts: 1,348
hmm... strange... i'll have to crack at it then.

Edit:
ok, i'm confirming the crash, i suspect that the way the 2nd patch works is interfering with some of the calls to free() on non aligned memory.
i'll work a new one out using the first patch as a starting point.

Edit Edit:
ok, new patch
preventing breaking cygwin building (as the first probably did break it)
preventing overwriting basic mem functions to avoid aligned freeing non aligned mem (problem with the second)
x264_mingw_aligned_03.diff
__________________
custom x264 builds & patches | F@H | My Specs

Last edited by kemuri-_9; 1st December 2008 at 08:01.
kemuri-_9 is offline   Reply With Quote
Old 1st December 2008, 22:57   #1422  |  Link
skystrife
Registered User
 
skystrife's Avatar
 
Join Date: Feb 2007
Posts: 176
Thanks, kemuri.

x264.1046M.exe - Alternate Download

Patches used:

x264_hrd_pulldown.09_interlace.diff
x264_win_zone_parse_fix_03.diff
x264_mingw_aligned_03.diff

gcc 3.4.5 fprofiled build with -march=pentium2.
skystrife is offline   Reply With Quote
Old 9th December 2008, 16:26   #1423  |  Link
Willyfan
Registered User
 
Willyfan's Avatar
 
Join Date: Sep 2008
Location: Brescia, ITALY
Posts: 30
I'm trying to compile x264, dowloaded from the last snapshot and patched with the last patch, using visual studio 2008. (I want to try to apply a old patch for slicing support, for BD specs problem). I convert from VC 7 to visual studio without problem, and the porgram compile without errot, but when I try to encode the encoding is very slow. There is something I need to do? Many thanks.
William
Willyfan is offline   Reply With Quote
Old 9th December 2008, 16:28   #1424  |  Link
LoRd_MuldeR
Software Developer
 
LoRd_MuldeR's Avatar
 
Join Date: Jun 2005
Location: Last House on Slunk Street
Posts: 13,070
Some of the assmbler functions are not working with MSVC compiler and will be disabled. Hence MSVC builds are a bit slower than MinGW/GCC builds.

Also make sure yasm.exe (nasm.exe isn't supporetd anymore) is available in your build environment. Otherwise all assembler code is disabled and you will get a really slow build...
__________________
There was of course no way of knowing whether you were being watched at any given moment.
How often, or on what system, the Thought Police plugged in on any individual wire was guesswork.



Last edited by LoRd_MuldeR; 9th December 2008 at 16:48.
LoRd_MuldeR is offline   Reply With Quote
Old 9th December 2008, 16:38   #1425  |  Link
Willyfan
Registered User
 
Willyfan's Avatar
 
Join Date: Sep 2008
Location: Brescia, ITALY
Posts: 30
What is the best compiler I must to use for the best result (under XP)?
Willyfan is offline   Reply With Quote
Old 9th December 2008, 16:46   #1426  |  Link
LoRd_MuldeR
Software Developer
 
LoRd_MuldeR's Avatar
 
Join Date: Jun 2005
Location: Last House on Slunk Street
Posts: 13,070
Quote:
Originally Posted by Willyfan View Post
What is the best compiler I must to use for the best result (under XP)?
There is no "best" compiler and you are not allowed to ask what's best. Use the compiler that works most convenient for you

I personally use TDM's Experimental GCC/MinGW32 Builds plus MSYS. It seems most of the x264 builds floating around are MinGW/GCC builds
__________________
There was of course no way of knowing whether you were being watched at any given moment.
How often, or on what system, the Thought Police plugged in on any individual wire was guesswork.



Last edited by LoRd_MuldeR; 9th December 2008 at 16:50.
LoRd_MuldeR is offline   Reply With Quote
Old 9th December 2008, 17:02   #1427  |  Link
Willyfan
Registered User
 
Willyfan's Avatar
 
Join Date: Sep 2008
Location: Brescia, ITALY
Posts: 30
Quote:
Originally Posted by LoRd_MuldeR View Post
There is no "best" compiler and you are not allowed to ask what's best.
I'm really sorry, the question was what compiler was the best for x264, or if x264 is compiled with a specific compiler. Not what is the best compiler at all. Anyway, many thanks for your advice.
William
Willyfan is offline   Reply With Quote
Old 9th December 2008, 17:14   #1428  |  Link
LoRd_MuldeR
Software Developer
 
LoRd_MuldeR's Avatar
 
Join Date: Jun 2005
Location: Last House on Slunk Street
Posts: 13,070
Quote:
Originally Posted by Willyfan View Post
I'm really sorry, the question was what compiler was the best for x264, or if x264 is compiled with a specific compiler. Not what is the best compiler at all. Anyway, many thanks for your advice.
William
Still there is no "best" compiler for x264. Use the compiler that works best for your individual needs and preferences...

(Not that if you use TDM's MinGW/GCC and MSYS, you still need to install yasm.exe separately. The pthread lib is already included in TDM's installer)
__________________
There was of course no way of knowing whether you were being watched at any given moment.
How often, or on what system, the Thought Police plugged in on any individual wire was guesswork.



Last edited by LoRd_MuldeR; 9th December 2008 at 17:28.
LoRd_MuldeR is offline   Reply With Quote
Old 9th December 2008, 18:24   #1429  |  Link
Audionut
Registered User
 
Join Date: Nov 2003
Posts: 1,264
This should help get you started with Mingw.

http://forum.doom9.org/showthread.ph...782#post723782
Audionut is offline   Reply With Quote
Old 9th December 2008, 22:55   #1430  |  Link
kemuri-_9
Compiling Encoder
 
kemuri-_9's Avatar
 
Join Date: Jan 2007
Posts: 1,348
I've ran comparisons of mingw and msvc builds,
in my case it was gcc 3.4.5 fprofiled and 2008 (vc++ 9) w/ PGO,
and they were fairly close in speeds, so this is not the problem.

there's a few possibilities that would have the MSVC version go slow:
A1. it's in debug configuration (which is extremely slow compared to release)
A2. Release config is not fully optimized.

B. the problem may be that it's not compiling with asm support
make sure HAVE_MMX is defined in the preprocessor section of the
projects.

C. no pthread support
the .vcproj's do not have pthread (nor gpac) support by default,
you'll need to compile, and then add the respective folders to the library and include paths for the x264 and libx264 solutions
(gpac to x264, pthreads to both)
then add in the proper preprocessor defines to have x264/libx264 go looking for them to compile with support.
(MP4_OUTPUT and HAVE_PTHREADS iirc)
__________________
custom x264 builds & patches | F@H | My Specs

Last edited by kemuri-_9; 9th December 2008 at 22:59.
kemuri-_9 is offline   Reply With Quote
Old 10th December 2008, 12:15   #1431  |  Link
Willyfan
Registered User
 
Willyfan's Avatar
 
Join Date: Sep 2008
Location: Brescia, ITALY
Posts: 30
Quote:
Originally Posted by kemuri-_9 View Post
C. no pthread support
the .vcproj's do not have pthread (nor gpac) support by default,
you'll need to compile, and then add the respective folders to the library and include paths for the x264 and libx264 solutions
(gpac to x264, pthreads to both)
then add in the proper preprocessor defines to have x264/libx264 go looking for them to compile with support.
(MP4_OUTPUT and HAVE_PTHREADS iirc)
Yes, I think that this is my problem. Now I downloaded the last version of pthread library (2.8.0). A question about gpac: this one is a framework, and need compilation, and not a library. Can you explain to me how to use gpac in MSVC? Many thanks!
William
Willyfan is offline   Reply With Quote
Old 10th December 2008, 12:28   #1432  |  Link
Dark Shikari
x264 developer
 
Dark Shikari's Avatar
 
Join Date: Sep 2005
Posts: 8,689
Quote:
Originally Posted by LoRd_MuldeR View Post
Still there is no "best" compiler for x264. Use the compiler that works best for your individual needs and preferences...
Certainly any compiler that doesn't define __GNUC__, however, couldn't be the best, as that disables a whole lot of inline assembly and such.
Dark Shikari is offline   Reply With Quote
Old 11th December 2008, 07:40   #1433  |  Link
foxyshadis
ангел смерти
 
foxyshadis's Avatar
 
Join Date: Nov 2004
Location: Lost
Posts: 9,436
Quote:
Originally Posted by LoRd_MuldeR View Post
Still there is no "best" compiler for x264. Use the compiler that works best for your individual needs and preferences...
No, that's the advice for 'best' video questions. Here, 'best' is possible to answer because there's only one recommended & supported compiler for x264: gcc. I still say it's better to err on the side of being helpful than on being a rules lawyer, but admittedly not everyone agrees.

Willy, you should still get used to asking for 'recommended' or 'your recommendations' if you stick around here long, though.
__________________
There are four boxes to be used in defense of liberty: soap, ballot, jury, and ammo. Please use in that order.
foxyshadis is offline   Reply With Quote
Old 11th December 2008, 07:50   #1434  |  Link
Dark Shikari
x264 developer
 
Dark Shikari's Avatar
 
Join Date: Sep 2005
Posts: 8,689
Quote:
Originally Posted by foxyshadis View Post
No, that's the advice for 'best' video questions. Here, 'best' is possible to answer because there's only one recommended & supported compiler for x264: gcc. I still say it's better to err on the side of being helpful than on being a rules lawyer, but admittedly not everyone agrees.
ICC works as well, since it has a GCC compatibility mode.
Dark Shikari is offline   Reply With Quote
Old 11th December 2008, 11:58   #1435  |  Link
Audionut
Registered User
 
Join Date: Nov 2003
Posts: 1,264
x264 0.65.0+1051 549cc55
built on Dec 11 2008, gcc: 3.4.5 (mingw-vista special r3)


Patched with,
x264_hrd_pulldown.09_interlace.diff
x264_mingw_aligned_03.diff

There was an error trying to patch x264_win_zone_parse_fix_03.diff, and i'm not clever enough to fix it.
Audionut is offline   Reply With Quote
Old 11th December 2008, 14:09   #1436  |  Link
bob0r
Pain and suffering
 
bob0r's Avatar
 
Join Date: Jul 2002
Posts: 1,337
For x264_win_zone_parse_fix_03.diff, change:
Code:
-        char *p, *tok, *saveptr;
to
Code:
-        char *p, *tok, UNUSED *saveptr;
bob0r is offline   Reply With Quote
Old 11th December 2008, 14:26   #1437  |  Link
Audionut
Registered User
 
Join Date: Nov 2003
Posts: 1,264
Yep, that fixed it. Thanks bob0r.

x264_win_zone_parse_fix_04.diff


As above but with the zone patch.
x264-r1051-A.rar

Last edited by Audionut; 11th December 2008 at 14:40.
Audionut is offline   Reply With Quote
Old 11th December 2008, 15:10   #1438  |  Link
skystrife
Registered User
 
skystrife's Avatar
 
Join Date: Feb 2007
Posts: 176
x264.1051M.exe - Alternate Download

Patches used:

x264_hrd_pulldown.09_interlace.diff
x264_win_zone_parse_fix_04.diff
x264_mingw_aligned_03.diff

gcc 3.4.5 fprofiled build with -march=pentium2.
skystrife is offline   Reply With Quote
Old 12th December 2008, 02:06   #1439  |  Link
kemuri-_9
Compiling Encoder
 
kemuri-_9's Avatar
 
Join Date: Jan 2007
Posts: 1,348
i will no longer be supporting the
x264_win_zone_parse_fix patch i originally started.

for the reason of:
I've successfully added BugMaster's strtok_r to my mingw's native libraries.
it works like a charm,
thus the patch is not needed for me anymore
__________________
custom x264 builds & patches | F@H | My Specs
kemuri-_9 is offline   Reply With Quote
Old 12th December 2008, 03:36   #1440  |  Link
Sharktooth
Mr. Sandman
 
Sharktooth's Avatar
 
Join Date: Sep 2003
Location: Haddonfield, IL
Posts: 11,768
kemuri-_9: please submit the changes to the mingw team. maybe they will consider to add them in future versions.
Sharktooth is offline   Reply With Quote
Reply

Tags
h.264, x264, x264 builds, x264 patches, x264 unofficial builds

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 18:26.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.