FFT3DFilter - The Portening

[Selur]

You are right, but since I like to keep stuff in separate sub folders that wouldn't work. (not complaining, since I usually generate most of the scripts I use, I don't really care much about the explicit loading and even prefer it since for me it seems 'cleaner' )

[lansing]

My image format are rgbs, it works when I convert them to rgb24.

img = core.imwrif.Read(r'001.png')
img = core.resize.Bicubic(img, format=vs.RGB24)
img = core.fft3dfilter.FFT3DFilter(img, sigma=1)

[Myrsloik]

Originally Posted by lansing

My image format are rgbs, it works when I convert them to rgb24.

img = core.imwrif.Read(r'001.png')
img = core.resize.Bicubic(img, format=vs.RGB24)
img = core.fft3dfilter.FFT3DFilter(img, sigma=1)

There's no argument scaling (like most vs filters), so probably you need to use a small sigma like 1/256 for similar effects.

[ChaosKing]

Ps.: I use the portable version which is why I need to load the libraries manually.

I never had to load the libraries manually in my portable version. just use the default folder structure vapoursynth64\plugins (vspipe is in the same folder as vapoursynth64)

[tuanden0]

Could you correct me if I wrong?
planes=0: Y
planes=1: U
planes=2: V

[Myrsloik]

Originally Posted by tuanden0

Could you correct me if I wrong?
planes=0: Y
planes=1: U
planes=2: V

No correction needed

[KingLir]

May I ask if anyone can help with building on macOS 10.13 ?

I have install successfully, using brew, both vapoursynth and fftw --enable threads, but it fails on fftw3f_threads ....

The Meson build system
Version: 0.48.0
Source dir: /Projects/VapourSynth-FFT3DFilter
Build dir: /Projects/VapourSynth-FFT3DFilter/build
Build type: native build
Project name: FFT3DFilter
Project version: 1
Native C++ compiler: ccache c++ (clang 10.0.0 "Apple LLVM version 10.0.0 (clang-1000.11.45.2)")
Build machine cpu family: x86_64
Build machine cpu: x86_64
Found pkg-config: /usr/local/bin/pkg-config (0.29.2)
Dependency vapoursynth found: YES 44
Dependency fftw3f_threads found: NO (tried pkgconfig and framework)

meson.build:11:0: ERROR: Dependency "fftw3f_threads" not found, tried pkgconfig and framework

If I just remove from meson the fftw3f_threads dependency it runs OK but when I build (ninja), I get:

FFT3DFilter::FFT3DFilter(float, float, int, int, int, int, int, int, float, float, float, float, float, float, bool, bool, int, int, int, int, bool, float, float, float, float, float, float, float, float, float, int, VSVideoInfo, VSNodeRef*) in FFT3DFilter.cpp.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

[Are_]

Dont' mess up with the build script, the problem is in your system. Your fftw compilation is miss-configured, as the build script alerts you, you didn't build fftw3f_threads.
Or can you check if you really have fftw3f_threads .so (or whatever is the extension in mac for a dynamic library) somewhere in your path?

[KingLir]

I have libfftw3f_threads.dylib in my path and still the same error.
I tried changing the file name to fftw3f_threads.dylib - but no luck.

Anyone have an idea what to do on macOS ?

[KingLir]

Originally Posted by HolyWu

The build script is updated and the issue should be fixed now.

Thanks!! Works like a charm.

[zorr]

My tests indicate that larger overlap results in better quality when denoising. Currently the maximum overlap that can be used is blocksize / 2. Is there a limitation in the algorithm that prevents using larger ones or why is it not allowed? It would be interesting to see if even larger overlap helps with the quality.

Also best results were obtained with the largest allowed bt=5. Adding support for even larger would also be helpful, but I do realize it takes more work.