Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
12th May 2018, 05:06 | #361 | Link |
Registered User
Join Date: Jul 2016
Posts: 100
|
I downloaded avsmeter and ran avsmeter -avsinfo. All the plugins list as 32 bit and look correct. I can attach the listing here if the information would be considered useful. Bottom line is the same results and error. This filter simply refuses to function with the defaults (no parameters), or any parameter as long as sharp is true. The error is the same, invalid arguments to function mt_clamp. But I tested other filters that use mt_clamp and there are no faults or script crashes. I have even gone so far as changing dgdecode.dll to ffms2.dll, and then trying a different source. Results are the same.
Any other suggestions or debugging tips are welcome. |
12th May 2018, 09:41 | #362 | Link |
HeartlessS Usurer
Join Date: Dec 2009
Location: Over the rainbow
Posts: 10,980
|
Just a simple tip, can use RT_Stats RT_Debug() or RT_DebugF() to show progress,
eg Code:
IntVar=42 RT_DebugF("OK here at step 1 (some IntVar = %d)",IntVar) IntVar=SomeFunc() RT_DebugF("OK here at step 2 (some IntVar = %d)",IntVar) or here:- https://docs.microsoft.com/en-us/sys...oads/debugview
__________________
I sometimes post sober. StainlessS@MediaFire ::: AND/OR ::: StainlessS@SendSpace "Some infinities are bigger than other infinities", but how many of them are infinitely bigger ??? Last edited by StainlessS; 12th May 2018 at 10:25. |
13th May 2018, 06:53 | #363 | Link |
Registered User
Join Date: Jul 2016
Posts: 100
|
StainlessS, the problem is resolved. I posted the information on the MCTD forum in the event someone else hits that error in the future. Now I can get back to the original thing; that was to compare mClean to MCTD. And now I have another tool in the grab bag.
|
14th May 2018, 03:28 | #365 | Link |
Soul Architect
Join Date: Apr 2014
Posts: 2,559
|
I'm also getting much better results with MCTemporalDenoise than with mClean. It accomplishes the same goal, packing the various cleaning functions together to give optimal results, and doesn't have the shape and color distortion problems I had with mClean.
|
14th May 2018, 14:51 | #366 | Link |
Soul Architect
Join Date: Apr 2014
Posts: 2,559
|
If used as a prefilter with FrameRateConverter, mClean was working nicely while MCTemporalDenoise introduces some artifacts. I think MCTemporalDenoise gives better image stabilization and output quality, at the cost of slightly shifting some motions causing artifacts with FRC, while mClean seems to better respect the vectors of the source image.
__________________
FrameRateConverter | AvisynthShader | AvsFilterNet | Natural Grounding Player with Yin Media Encoder, 432hz Player, Powerliminals Player and Audio Video Muxer Last edited by MysteryX; 14th May 2018 at 15:56. |
17th May 2018, 00:51 | #367 | Link |
Registered User
Join Date: Jul 2016
Posts: 100
|
Now that I finally have an MCTD that is functional I have been able to do some comparisons between MCTD and mClean, and also included tests with SMDegrain. When using MCTD I chose the setting of medium. On my worst test cases, the material with the highest amount of noise, only mClean does a good job of cleaning and denoising while maintaining detail. Is it perfect? No. But MCTD and SMDegrain could not clean those worst cases and carried along a noticeable amount of noise.
The largest drawback I found with MCTD was the way it added a milky or smokey haze to the output. At first I ignored it and kept watching the output looking for artifacts, distortion, etc. But that haze becomes some obvious in certain scenes that there is no avoiding it. I purposely did side by side tests (with StackHorizontal) between the source and mClean, and the source and MCTD. What I gleaned from the tests, so far, is that material that is not overly noisy, SMDegrain was my best choice. With some variations of its parameters I was able to significantly remove noise. But as I already stated, in the worse examples, mClean handled the task, and do so very well. One other point worth mentioning is that mClean and SMDegrain work very well with SetFilterMTMode. The very best I was ever able to get with MCTD was SetFilterMTMode (4, force=true). |
17th May 2018, 12:03 | #368 | Link | |||
Registered User
Join Date: Sep 2006
Posts: 1,657
|
Quote:
Quote:
Quote:
|
|||
17th May 2018, 15:20 | #369 | Link |
Soul Architect
Join Date: Apr 2014
Posts: 2,559
|
I find KnlMeansCL to give a lot blurrier results than mClean or MCTD. I guess we have to choose: blurrier or slight distortions.
Truth is various types of noise and videos will look better with either one of these 4: KnlMeansCL, MCTD, mClean or SMDegrain. So in my software I'm probably best to allow the user to select any one of them. |
17th May 2018, 17:02 | #370 | Link |
Registered User
Join Date: Jul 2016
Posts: 100
|
I agree on the blurred results from KNMeansCL. I tried FluxSmooth but it only handles the lightest amount of noise. The thing that caught my eye, quite by surprise actually, was the way mClean handles old B&W films where the brightness would flicker. I have one film that is really bad where the faces of the actors actually has brightness fluctuations. The mClean helped smooth that away and really stabilized the entire video. But I think having all of these as user choices rather than force just one is a wise decision.
The one thing to consider also is whether there needs to be sharpening after the noise filter. I haven't found the need for sharpening with mClean. With SMDegrain I set ContraSharp to true. I have too little experience with MCTD to know whether it needs additional sharpening. FluxSmooth definitely does need sharpening. My favorite choice is mSharpen. The option on that filter to have the areas highlighted so you can see what the filter is seeing is extremely helpful. |
17th May 2018, 18:04 | #371 | Link |
Registered User
Join Date: Feb 2017
Posts: 135
|
I’d be curious to see the knlmeanscl settings they people are using and having blurred results. From my testing the “a” parameter value plays the largest part in the blurring by removing low frequency noise, mottling, or subtle color differences in the video. Anything higher than 1 is going to smudge out the finer subtle details. But maybe that’s desired in situations. That value is a smoother. An “s” value greater than 1 tends to wink out pinpoint noise like star fields similar to the filter dedot(). That said, it’s my go-to denoiser due to its preservation of details with the correct settings for the source.
Last edited by SaurusX; 17th May 2018 at 18:07. |
6th June 2018, 05:43 | #373 | Link |
Registered User
Join Date: Jul 2016
Posts: 100
|
I use mClean 3.2 quite a lot on older SD and HD material that have a goodly amount of grain and noise. I never hit that error with mClean. It could be that you have an outdated plug-in. I only ever processed 8 bit material so it is possible that higher bit-depth material may have a problem.
The best tool I found for checking plug-in information is AVSmeter. Look for duplicate plug-ins and check the versions. |
28th June 2018, 18:17 | #374 | Link |
Registered User
Join Date: Jul 2016
Posts: 100
|
Burfadel, do you have any plans to further tweak or modify this script? I keep hitting a problem where cropped sources have a visible line of distortion on the right side of the frames/clips. I have verified that if I crop further in, the distortion disappears. But I shouldn't need to crop off borders beyond the black (or noise).
Just to be sure the cropping was correct I tried a different filter that does a similar job. The line of distortion is not created in the output. Could this be something related to divisible width? For example, does the source need to be a multiple of 2, 4, 8? |
28th June 2018, 22:21 | #375 | Link |
HeartlessS Usurer
Join Date: Dec 2009
Location: Over the rainbow
Posts: 10,980
|
You could probably say what dimensions cause problem, and what fixes it.
This looks a little strange to me Code:
padX = c.width%8 == 0 ? 0 : (16 - c.width%8) padY = c.height%8 == 0 ? 0 : (16 - c.height%8)
__________________
I sometimes post sober. StainlessS@MediaFire ::: AND/OR ::: StainlessS@SendSpace "Some infinities are bigger than other infinities", but how many of them are infinitely bigger ??? |
30th June 2018, 00:19 | #376 | Link |
Registered User
Join Date: Jul 2016
Posts: 100
|
I think those modulo divisions are exactly where the fault lies. I was using 1436X1080. Everything else works fine but there is this line of corrupted pixels near the entire right edge. I changed the 8's to 16's and the corrupted pixels are gone. Just to be on the safe side I left the original lines but commented out, and added corrected versions of the lines.
padX = c.width%16 == 0 ? 0 : (16 - c.width%16) padY = c.height%16 == 0 ? 0 : (16 - c.height%16) If burfadel is around I would feel happy if he could confirm this as the culprit and fix. Thanks for help! |
3rd July 2018, 03:13 | #377 | Link | |
Registered User
Join Date: Dec 2007
Posts: 20
|
Quote:
|
|
16th August 2018, 13:53 | #378 | Link |
Registered User
Join Date: Dec 2005
Location: Germany
Posts: 1,795
|
Thanks to Wolfberry there is now a Vapoursynth version of mClean https://forum.doom9.org/showthread.php?t=175614
__________________
AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth VapourSynth Portable FATPACK || VapourSynth Database |
18th August 2018, 10:42 | #379 | Link | |
Registered User
Join Date: Oct 2001
Location: Germany
Posts: 7,277
|
Code:
blksize = sc==8 ? 8 : ((defH/sc)/360)>1.5 ? 16 : ((defH/sc)/360)>0.8 ? 12 : 8 Quote:
Cu Selur |
|
18th August 2018, 12:04 | #380 | Link | ||
HeartlessS Usurer
Join Date: Dec 2009
Location: Over the rainbow
Posts: 10,980
|
Changelog from Version 2.7.31
Quote:
Quote:
__________________
I sometimes post sober. StainlessS@MediaFire ::: AND/OR ::: StainlessS@SendSpace "Some infinities are bigger than other infinities", but how many of them are infinitely bigger ??? Last edited by StainlessS; 18th August 2018 at 12:20. |
||
Tags |
cleaning, denoise, denoiser, mclean |
|
|