Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Hardware & Software > Software players

Reply
 
Thread Tools Search this Thread Display Modes
Old 30th December 2019, 10:22   #7001  |  Link
nevcairiel
Registered Developer
 
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,343
Quote:
Originally Posted by Liisachan View Post
If it's just a wrapper of RegQueryValueExW, the terminating NULL is not guaranteed (according to the docs), meaning that even if you zero-init the whole buffer and ERROR_SUCCESS is returned, buff might be still not NULL-terminated (in an unlikely situation where the stored string is not NULL-terminated and has exactly 256 characters). In reality, the version string should be much shorter, though.
CRegKey is part of ATL, which does ensure that the returned string is null-terminated, or it'll return with an error code.
It won't fix strings which were not null-terminated, but it won't just return them to you either. But while such registry entries are possible, they don't usually matter in such cases.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders

Last edited by nevcairiel; 30th December 2019 at 10:26.
nevcairiel is online now   Reply With Quote
Old 31st December 2019, 04:19   #7002  |  Link
Liisachan
李姗倩 Lǐ Shān Qiàn
 
Liisachan's Avatar
 
Join Date: Nov 2002
Posts: 1,340
@nevcairiel
Thanks for clarification. I looked into it, and it returns ERROR_SUCCESS only if the string is null-terminated or empty (0-byte data will be fixed as a null-terminated empty string), so like you said memset is unnecessary (though harmless).

Happy new year everyone
Liisachan is offline   Reply With Quote
Old 31st December 2019, 14:17   #7003  |  Link
alex1399
Registered User
 
Join Date: Jun 2018
Posts: 56
The windows always start with resolution 292x164 at this version 1.5.4 (build 4969). Neither the setting enable or disable can let it always full window.
alex1399 is offline   Reply With Quote
Old 31st December 2019, 15:14   #7004  |  Link
Aleksoid1978
Registered User
 
Aleksoid1978's Avatar
 
Join Date: Apr 2008
Location: Russia, Vladivostok
Posts: 2,783
Happy New Year 2020 !!!
__________________
AMD Ryzen 5 3600 /GIGABYTE B450 Gaming X /Patriot 32Gb@3200 /Kingston 500Gb M.2 /RTX 4060 /Samsung U28R550UQI /OLED Philips 55OLED707 /Yamaha RX-V471 + NS-555 + NS-C444 + NS-333 + YST-SW215
Aleksoid1978 is offline   Reply With Quote
Old 1st January 2020, 00:32   #7005  |  Link
JNW
Registered User
 
Join Date: Sep 2017
Posts: 51
Quote:
Originally Posted by ryrynz View Post
Gone forever. Use this https://yadi.sk/d/AjAXDDHtHRIELg
Aha. Just what I was looking for. Thank you.


Happy New Year all!
JNW is offline   Reply With Quote
Old 1st January 2020, 19:11   #7006  |  Link
beter
Registered User
 
Join Date: Aug 2013
Posts: 182
Update for translation of Traditional Chinese and Dutch:
https://www.sendspace.com/file/g2a8by
beter is offline   Reply With Quote
Old 2nd January 2020, 06:53   #7007  |  Link
v0lt
Registered User
 
Join Date: Dec 2008
Posts: 1,959
@cmhrky
Thanks. Updated in r4981.

@beter
Thanks. Updated in r4983.
v0lt is offline   Reply With Quote
Old 3rd January 2020, 17:45   #7008  |  Link
mclingo
Registered User
 
Join Date: Aug 2016
Posts: 1,348
ive mentioned this before but there have been a few new version since but it still hasnt been fixed, or i'm doing something wrong. When I play a movie with a non english audio track listed as (01) it always plays this instead of the default i've set, i've tried both "eng" and "english", just doesnt work. Works fine in MPC-HC using LAV

EDIT- I think I might know what is causing this for me but there still might be a bug of sorts.

I recently reinstalled MPC-BE and forgot to set "eng" until today, however all the files i've already played with it blank still ignore this and files i hadnt yet played play fine, so I guess MPC-BE is saving the audio track information somewhere and using this as priority over the default setting.

Thinking about it, this actually makes sense

so its not a bug
__________________
LG OLED EF950-YAM RX-V685-RYZEN 3600 - 16GBRAM - WIN10 RX 5700 - https://www.videohelp.com/software/madVR/old-versions

Last edited by mclingo; 3rd January 2020 at 17:50.
mclingo is offline   Reply With Quote
Old 3rd January 2020, 21:45   #7009  |  Link
Liisachan
李姗倩 Lǐ Shān Qiàn
 
Liisachan's Avatar
 
Join Date: Nov 2002
Posts: 1,340
Quote:
Originally Posted by mclingo View Post
ive mentioned this before but there have been a few new version since but it still hasnt been fixed, or i'm doing something wrong. When I play a movie with a non english audio track listed as (01) it always plays this instead of the default i've set, i've tried both "eng" and "english", just doesnt work. Works fine in MPC-HC using LAV
Speaking of which, I've always wanted to say, please support the standard ISO language codes, instead of "Example: eng jap swe". I know these examples are innocent, simply the first 3 letters of the language names, and they're practically fine and easier to understand for most people (so I guess it's fine they are supported). However, the official code for Japanese is jpn, and "jap" is generally considered as a racial slur in Japan for historical reasons, quite a few people feeling uncomfortable or offended to see it.

Also practically, the first-three-letter scheme could be bad for example Malay vs. Malayalam, Sindhi vs. Sinhalese. Not to be picky, just so you know there could be potential problems. Thanks
Liisachan is offline   Reply With Quote
Old 4th January 2020, 06:55   #7010  |  Link
v0lt
Registered User
 
Join Date: Dec 2008
Posts: 1,959
Liisachan
You do not seem to know the history of this option. There is no code for the track language in the AVI files, not at all. In external srt, mp3 files there is also no code for the language. In many MKVs, the track language is recorded with a name, not a code. In general, your proposal can only complicate everything, we will leave everything as it is.
v0lt is offline   Reply With Quote
Old 4th January 2020, 09:54   #7011  |  Link
Klaus1189
Registered User
 
Join Date: Feb 2015
Location: Bavaria
Posts: 1,666
@Devs: Can you please check this sample file with teletext subtitle here for a buddy of mine?
https://drive.google.com/file/d/13G0...ew?usp=sharing
At 00:23 there is I checked displayed, but there should be But he wont say what its on at the very following, but it isn't displayed according to my buddy.
Thanks in advance
Klaus1189 is offline   Reply With Quote
Old 4th January 2020, 10:35   #7012  |  Link
Aleksoid1978
Registered User
 
Aleksoid1978's Avatar
 
Join Date: Apr 2008
Location: Russia, Vladivostok
Posts: 2,783
You checked Display at 00:23 ? Sub can store early in file and not parsed if disable output.
__________________
AMD Ryzen 5 3600 /GIGABYTE B450 Gaming X /Patriot 32Gb@3200 /Kingston 500Gb M.2 /RTX 4060 /Samsung U28R550UQI /OLED Philips 55OLED707 /Yamaha RX-V471 + NS-555 + NS-C444 + NS-333 + YST-SW215
Aleksoid1978 is offline   Reply With Quote
Old 4th January 2020, 10:47   #7013  |  Link
Klaus1189
Registered User
 
Join Date: Feb 2015
Location: Bavaria
Posts: 1,666
I checked the file myself and at 00:23 and there is I checked displayed, but not the following But he wont say what its on which should also be displayed. I don't know anything else about the file. I cannot even check if the text is available in the teletext stream. If you need more info, let me know. I am lost with my knowledge.
Klaus1189 is offline   Reply With Quote
Old 4th January 2020, 10:50   #7014  |  Link
Liisachan
李姗倩 Lǐ Shān Qiàn
 
Liisachan's Avatar
 
Join Date: Nov 2002
Posts: 1,340
Quote:
Originally Posted by v0lt View Post
Liisachan
You do not seem to know the history of this option. There is no code for the track language in the AVI files, not at all. In external srt, mp3 files there is also no code for the language. In many MKVs, the track language is recorded with a name, not a code. In general, your proposal can only complicate everything, we will leave everything as it is.
Imho supporting both "jpn" and "jap" similarly/transparently would be more convenient for everyone, not complicating anything. MPC-HC does support "jpn" in the same edit box and it can auto-select a "jpn" track from MKV, which seems more intuitive. I understand that supporting non-standard language codes is helpful. I'm not saying you should stop that.

If MKV is created properly, each track has a standard language code. If the code is specific (e.g. "rus" or "jpn" instead of "und"), that gives us a simple way to detect the language, more reliable than parsing the track name (which might be something like "ASS" or "Styled"). You're right, I don't know the historical reasons behind this. On the other hand, I've been multisubbing for about 20 years since before MKV was born, and in my experience, decent MKV files (perhaps > 90%) always have "jpn" for Japanese, at least in the anime fandom — partly because it was/is in the predefined list box of MMG/MKVToolnix GUI. I wouldn't insist. If, for some good reason that I don't know, BE doesn't want to support the standard code "jpn" supported by MPC-HC, I'll respect your choice. Thanks!

Last edited by Liisachan; 4th January 2020 at 13:07.
Liisachan is offline   Reply With Quote
Old 4th January 2020, 11:07   #7015  |  Link
Aleksoid1978
Registered User
 
Aleksoid1978's Avatar
 
Join Date: Apr 2008
Location: Russia, Vladivostok
Posts: 2,783
Give a sample with “jpn” that not supported by MPC BE ?
__________________
AMD Ryzen 5 3600 /GIGABYTE B450 Gaming X /Patriot 32Gb@3200 /Kingston 500Gb M.2 /RTX 4060 /Samsung U28R550UQI /OLED Philips 55OLED707 /Yamaha RX-V471 + NS-555 + NS-C444 + NS-333 + YST-SW215
Aleksoid1978 is offline   Reply With Quote
Old 4th January 2020, 12:58   #7016  |  Link
Liisachan
李姗倩 Lǐ Shān Qiàn
 
Liisachan's Avatar
 
Join Date: Nov 2002
Posts: 1,340
sample file with 2 sub tracks (rus = default; jpn): no-audio.mkv

MPC-HC Options: can handle "jpn"


MPC-BE Options: don't like "jpn"
Liisachan is offline   Reply With Quote
Old 4th January 2020, 13:03   #7017  |  Link
Aleksoid1978
Registered User
 
Aleksoid1978's Avatar
 
Join Date: Apr 2008
Location: Russia, Vladivostok
Posts: 2,783
Quote:
Originally Posted by Liisachan View Post
sample file with 2 sub tracks (rus = default; jpn): no-audio.mkv

MPC-HC Options: can handle "jpn"


MPC-BE Options: don't like "jpn"
Ok - i see, you mean handle by language code. But - it's not MPC-HC or MPC-BE deal - it's LAV Source/Splitter generate stream's name including language code
__________________
AMD Ryzen 5 3600 /GIGABYTE B450 Gaming X /Patriot 32Gb@3200 /Kingston 500Gb M.2 /RTX 4060 /Samsung U28R550UQI /OLED Philips 55OLED707 /Yamaha RX-V471 + NS-555 + NS-C444 + NS-333 + YST-SW215
Aleksoid1978 is offline   Reply With Quote
Old 4th January 2020, 14:00   #7018  |  Link
v0lt
Registered User
 
Join Date: Dec 2008
Posts: 1,959
@Liisachan
In r4990, a code is added to the name for languages in which the codes and name differ in the first letters.

Last edited by v0lt; 4th January 2020 at 14:55.
v0lt is offline   Reply With Quote
Old 4th January 2020, 14:52   #7019  |  Link
Liisachan
李姗倩 Lǐ Shān Qiàn
 
Liisachan's Avatar
 
Join Date: Nov 2002
Posts: 1,340
@v0lt
Thanks That's great news.
Liisachan is offline   Reply With Quote
Old 4th January 2020, 14:56   #7020  |  Link
v0lt
Registered User
 
Join Date: Dec 2008
Posts: 1,959
@Liisachan
This will only work for containers in which there is a language code.

In any case, the double option always works: "jap jpn". Therefore, recent changes may be removed in the future.
v0lt is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 17:38.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.