Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Capturing and Editing Video > Avisynth Development

Reply
 
Thread Tools Search this Thread Display Modes
Old 18th July 2015, 05:29   #1  |  Link
Elegant
Registered User
 
Join Date: Jul 2014
Posts: 55
TComb v2.0 (x86/x64)

Hi guys, I decided to update tritical's old filter encompassing his to-do-list of changes as well as porting the code to x64 among other things. An attachment of the filter can be found at the bottom of this post.

Further information can be found in the readme as well as on my GitHub.

Enjoy!
Attached Files
File Type: 7z TComb_v2_0.7z (120.3 KB, 189 views)

Last edited by Elegant; 30th July 2015 at 01:26. Reason: Updated 26/07/2015.
Elegant is offline   Reply With Quote
Old 20th July 2015, 02:18   #2  |  Link
ChiDragon
Registered User
 
ChiDragon's Avatar
 
Join Date: Sep 2005
Location: Vancouver
Posts: 600
It's been a long time since I personally have had occasion to use TComb, so as far as functionality I'll just say thank you very much and place it in my plugins folder for the next time I'm playing with a LaserDisc capture.

Meanwhile, I guess I'm in a perfectionist mood because I noticed a couple things reading the description. Sorry, just trying to help! I'll use itty-bitty font to emphasize how unimportant these are.

Under Programmer Notes: "There work led to the port of this project."
Your section of the change-list in the readme.txt is using DD/MM/YYYY while tritical used the American format. This could get a little confusing if there are future updates.
ChiDragon is offline   Reply With Quote
Old 20th July 2015, 03:05   #3  |  Link
Reel.Deel
Registered User
 
Join Date: Mar 2012
Location: Texas
Posts: 1,664
Thanks Elegant! Nice to see another plugin from tritical available in 64-bit. I still have a handful of (yet to be processed) DVD's with dot crawl and rainbows.
Reel.Deel is offline   Reply With Quote
Old 29th July 2015, 20:17   #4  |  Link
mastrboy
Registered User
 
Join Date: Sep 2008
Posts: 365
Thanks

This is my goto filter for dotcrawl so a update is warmly welcomed.

Offtopic: Has Tritical left the Avisynth community for good? Been a while since I've seen a post from him...
__________________
(i have a tendency to drunk post)
mastrboy is offline   Reply With Quote
Old 24th November 2018, 17:18   #5  |  Link
SaurusX
Registered User
 
Join Date: Feb 2017
Posts: 134
This filter doesn't quite work the same as the 32-bit version. Much less effective, unfortunately. Anyone else come across this and have a workaround?
SaurusX is offline   Reply With Quote
Old 24th November 2018, 18:40   #6  |  Link
poisondeathray
Registered User
 
Join Date: Sep 2007
Posts: 5,345
Quote:
Originally Posted by SaurusX View Post
This filter doesn't quite work the same as the 32-bit version. Much less effective, unfortunately. Anyone else come across this and have a workaround?
Can you be more specific ? For example, do you get different results with the same settings ? It might help to improve it if you provided an accurate description

A workaround would be to run the original 32bit version through mp_pipeline
poisondeathray is offline   Reply With Quote
Old 24th November 2018, 19:13   #7  |  Link
StainlessS
HeartlessS Usurer
 
StainlessS's Avatar
 
Join Date: Dec 2009
Location: Over the rainbow
Posts: 10,980
Quote:
Originally Posted by poisondeathray View Post
Can you be more specific ? For example, do you get different results with the same settings ? It might help to improve it if you provided an accurate description
And a small sample file that exhibited differences would probably help someone to find any problems.
__________________
I sometimes post sober.
StainlessS@MediaFire ::: AND/OR ::: StainlessS@SendSpace

"Some infinities are bigger than other infinities", but how many of them are infinitely bigger ???
StainlessS is offline   Reply With Quote
Old 24th November 2018, 20:20   #8  |  Link
SaurusX
Registered User
 
Join Date: Feb 2017
Posts: 134
Here's a sample of the clip I'm looking at. I recently upgraded meGUI to the x64 version and I've been working at rebuilding my filter library. So far, the 64-bit TComb is far less effective at removing the dot crawl in comparison to the 32-bit version. In the clip below I'm focusing on the vertical lines of the rock monument at the very opening scene as a prime example. I'm using these same exact parameters for both cases:

TComb(mode=0, fthreshL=5, othreshL=4)


This is my entire script (if it helps):
MPEG2SOURCE("J:\Videos\DVDRips\!WORK\Roswell25.d2v")
i=MPEG2SOURCE("J:\Videos\DVDRips\!WORK\Roswell25.d2v")
edeint=i.nnedi3(-2)
TComb(mode=0, fthreshL=5, othreshL=4) #5,4 are the ideal setting for Roswell
TFM(slow=2,pp=7,mode=3,clip2=i.tdeint(mode=2,mthreshl=0,mthreshc=0,edeint=edeint))
TDecimate(mode = 1)
crop(0,2,-12,0)
chromashiftsp(x=2)
QTGMC(preset="slow",inputtype=1,tr0=0,tr1=2,tr2=1,smode=0,ezdenoise=1.3)
FineDehalo2(hconv="-1 -1 1 1 40 1 1 -1 -1", vconv="-1 -1 1 1 40 1 1 -1 -1")
dehalohmod(smooth=true) #kill those skeeters
dehalo_alpha(darkstr=0,brightstr=.2,ss=2) #De-halo the whole thing. In original video and from msharpen
dehalo_alpha(darkstr=0,brightstr=.4,ss=2,cs=true)
dehalo_alpha(darkstr=0,brightstr=.6,ss=2,cs=true)
aWarpSharp2(thresh=128, blur=2, type=0, depth=8, chroma=6)
hysteria(showmask=false,luma_cap=63,lowthresh=10,highthresh=15)
msharpen(mask=false,threshold=22,strength=40)
nnedi3_rpow2(rfactor=2,cshift="Spline36Resize",fwidth=720,fheight=480)
sharpen(.1)

SAMPLE CLIP HERE
SaurusX is offline   Reply With Quote
Old 24th November 2018, 21:40   #9  |  Link
poisondeathray
Registered User
 
Join Date: Sep 2007
Posts: 5,345
Yes, I can replicate the issue. This x86 version works, and the original x86 tritical version works at similar strengths. This x64 version is "less effective" as you describe when using the same settings

Elegant looks to be active still (last post ~ 1 month ago)

Another option in the meantime would be to use x86 version, and avfs into the x64 script
poisondeathray is offline   Reply With Quote
Old 6th April 2019, 18:39   #10  |  Link
SaurusX
Registered User
 
Join Date: Feb 2017
Posts: 134
A user named saiclabs at a different site compiled a new version of 64-bit TComb from Tritical's original source code. I don't think it has the 2.0 updates in it that Elegant tried to put in, but at least it works in 64-bit now.

https://www.upload.ee/files/9792816/TComb.7z.html
SaurusX is offline   Reply With Quote
Old 6th April 2019, 18:43   #11  |  Link
Reel.Deel
Registered User
 
Join Date: Mar 2012
Location: Texas
Posts: 1,664
Quote:
Originally Posted by SaurusX View Post
A user named saiclabs at a different site compiled a new version of 64-bit TComb from Tritical's original source code. I don't think it has the 2.0 updates in it that Elegant tried to put in, but at least it works in 64-bit now.

https://www.upload.ee/files/9792816/TComb.7z.html
But Elangant released a x64 version: https://github.com/Elegant996/TComb/releases
Reel.Deel is offline   Reply With Quote
Old 6th April 2019, 19:27   #12  |  Link
SaurusX
Registered User
 
Join Date: Feb 2017
Posts: 134
Quote:
Originally Posted by Reel.Deel View Post
But Elangant released a x64 version: https://github.com/Elegant996/TComb/releases
It does not work unfortunately.
SaurusX is offline   Reply With Quote
Old 20th February 2021, 02:56   #13  |  Link
Shinkiro
Registered User
 
Join Date: Dec 2012
Posts: 65
The x64 version does not work for me either, maybe someone has a working one?
__________________
Ryzen 2700x | ASUS ROG Strix GTX 1080 Ti | 16 Gb DDR4
Windows 10 x64 20H2
KD-55XE9005 | Edifier R2800
Shinkiro is offline   Reply With Quote
Old 20th February 2021, 20:26   #14  |  Link
SaurusX
Registered User
 
Join Date: Feb 2017
Posts: 134
Here' is the saiclabs version of x64 TComb, again. As an attachment this time.
Attached Files
File Type: 7z TComb.7z (105.8 KB, 61 views)
SaurusX is offline   Reply With Quote
Old 21st February 2021, 01:54   #15  |  Link
kedautinh12
Registered User
 
Join Date: Jan 2018
Posts: 2,153
Can you share another link?? Ex: Gdrive, mediafire
kedautinh12 is offline   Reply With Quote
Old 21st February 2021, 11:53   #16  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 2,309
A simple rebuild won't help, there is a small bug in x64 asm.
pinterf is offline   Reply With Quote
Old 22nd February 2021, 10:41   #17  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 2,309
TComb v2.1 with a lot of bugfixes.
https://github.com/pinterf/TComb/releases
pinterf is offline   Reply With Quote
Old 22nd February 2021, 13:05   #18  |  Link
kedautinh12
Registered User
 
Join Date: Jan 2018
Posts: 2,153
Thanks for your hard work
kedautinh12 is offline   Reply With Quote
Old 22nd February 2021, 17:43   #19  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 2,309
There still left one nasty bug in x64. An unsaved register in one of the assembler routines. And the bug appeared only on release version, and not every time. So it was undebuggable I caught it but I'll leave it for tomorrow. I think I'm gonna rewrite all those external assembler code to simd intrinsics. Yes. A future linux build will probably like it.
pinterf is offline   Reply With Quote
Old 22nd February 2021, 21:51   #20  |  Link
Reel.Deel
Registered User
 
Join Date: Mar 2012
Location: Texas
Posts: 1,664
Quote:
Originally Posted by pinterf View Post
I think I'm gonna rewrite all those external assembler code to simd intrinsics. Yes. A future linux build will probably like it.
Maybe you'll like it - https://github.com/dubhater/vapoursy...rc/simd_sse2.c
Reel.Deel is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 12:56.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.