Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
3rd August 2014, 20:27 | #221 | Link | |
Registered User
Join Date: Feb 2004
Location: Mars
Posts: 428
|
Quote:
Should be fixed on github + in this portable beta: http://www.nikse.dk/SubtitleEdit.zip |
|
4th August 2014, 19:48 | #225 | Link | |
Registered User
Join Date: May 2009
Location: Belgium
Posts: 1,744
|
@ Nikse555 : did you find where does this little problem come from ?
Quote:
http://forum.doom9.org/showthread.ph...98#post1686798 |
|
4th August 2014, 20:31 | #226 | Link |
Registered User
Join Date: Feb 2004
Location: Mars
Posts: 428
|
@mariner: Yeah, I guess... perhaps a warning would be nice...
@Music Fan: Hm, perhaps to give the decoder a tiny bit extra time to decode the subtitles? I don't know The code is here: https://github.com/SubtitleEdit/subt...Picture.cs#L45 |
7th August 2014, 22:33 | #227 | Link |
Registered User
Join Date: Sep 2008
Location: Holland, Belgium
Posts: 330
|
Perhaps a bug.
In case the user has unchecked "Start with uppercase letter after paragraph" in the Fix common Errors dialog (and the other "start with uppercase" choices), some items are still detected and presented to be Uppercased using the "Fix Common Errors (using the OCR replace list)" method. For example, subtitles 444 and 1047 in the subtitle file below. Code:
444 --> als ie tenminste nog capabel was... 1047 -> b kwadraat? Last edited by Betsy25; 7th August 2014 at 22:34. Reason: wrong wording |
8th August 2014, 14:17 | #228 | Link |
Registered User
Join Date: Sep 2006
Posts: 2,197
|
Maybe a bug, for some reason I couldnt delete an entry from the OCR fix list which I had added myself before. had to edit the .xml file to get rid of it.
__________________
Laptop Lenovo Legion 5 17IMH05: i5-10300H, 16 GB Ram, NVIDIA GTX 1650 Ti (+ Intel UHD 630), Windows 10 x64, madVR (x64), MPC-HC (x64), LAV Filter (x64), XySubfilter (x64) (K-lite codec pack) Last edited by Thunderbolt8; 8th August 2014 at 16:26. |
10th August 2014, 07:12 | #229 | Link |
Registered User
Join Date: Feb 2004
Location: Mars
Posts: 428
|
@Betsy25: Hm, yes. "Fix common OCR errors" also changes first letter to uppercase...
@Thunderbolt8: I could not re-create this... let me know if it occurs again or if you can re-create it. Also, changes to interjections require the 'Remove text for HI' window to be closed and re-opened for the changes to take effect... will be fixed next update. |
11th August 2014, 13:15 | #230 | Link |
Registered User
Join Date: Sep 2006
Posts: 2,197
|
in the remove text for hearing impaired menu, would it be possible to add exceptions for removing text between ( ) and { } in case of .ass files? the screen position in some .ass subs is indicated between these markers. perhaps when such marker both occur in the same line or when the ( ) brackets are inside the { } ones?
currently, its like this: {} ticked: {\an5\pos(958,176)}JACKIE: <i>It seems as though</i> -----> <i>It seems as though</i> () ticked: {\an5\pos(958,176)}JACKIE: <i>It seems as though</i> -----> <i>It seems as though</i> --> should be: {\an5\pos(958,176)}<i>It seems as though</i> {} ticked: {\an4\pos(705,833)}<i>Today really marks</i> -----> <i>Today really marks</i> () ticked: {\an4\pos(705,833)}<i>Today really marks</i> -----> {\an4\pos}<i>Today really marks</i> --> should be: {\an4\pos(705,833)}<i>Today really marks</i> {\an4\pos(556,902)}Huh? -----> {\an4\pos(556,902)} --> should be: whole line should get deleted because its empt after the position information after SHD removal. {\an4\pos(814,825)}- [ Panting ] -----> {\an4\pos(814,825)}- --> should be: whole line should get deleted because theres only a hyphen left after SHD removal, but line doesnt get removed because the subtitle screen position information is considered as text information.
__________________
Laptop Lenovo Legion 5 17IMH05: i5-10300H, 16 GB Ram, NVIDIA GTX 1650 Ti (+ Intel UHD 630), Windows 10 x64, madVR (x64), MPC-HC (x64), LAV Filter (x64), XySubfilter (x64) (K-lite codec pack) Last edited by Thunderbolt8; 11th August 2014 at 20:14. |
12th August 2014, 16:47 | #231 | Link |
Registered User
Join Date: Feb 2004
Location: Mars
Posts: 428
|
@Thunderbolt: thx for reporting this... I probably use srt files most of the time.
Should be fixed on github + in this portable beta: http://www.nikse.dk/SubtitleEdit.zip (also contains the interjections-fix) Let me know if you find more stuff Last edited by Nikse555; 13th August 2014 at 15:23. |
18th August 2014, 21:06 | #233 | Link |
Registered User
Join Date: Sep 2006
Posts: 2,197
|
there are a few things I still noticed. some of them to come at a later point. but for now:
- if there are double hyphens "--" in line initial position already present before SHD removal has been run (e.g. --the wheather will be...) then those double hypens shouldnt be changed and taken into consideration for SHD removal. e.g. "SPEAKER: --the wheather will be...." in this case the double hyphens should be disregarded from removal. this should only apply with cases in which the double hyphens were present from the start, not as a leftover result from a previous SHD removal (i dont know how the SHD removal stage works, if there are for examples 2 runs you do after another when pressing button only once) - hyphens and other SHD information in a subtitle line (for .srt) should be taken into consideration if that subtitle line for example consists of two or more lines on screen. e.g - It's already done. (- It's already done.|BENJAMIN: You--) BENJAMIN: You-- gets changed to - It's already done. (- It's already done.|You--) You-- while it should get changed to - It's already done. (- It's already done.|- You--) - You-- (this example can get fixed though with "fix line beginning with dash (-)" in the fix common errors tab, but that option might not be activated, possibly because it could interfere negatively in other situations within the same file. so it would be nice if this situation could be resolved already during SHD removal) - same as above in case of .ass subtitles, if you have 2 or more subtitle lines with identical timestamps, meaning they belong together on screen. e.g. 00:04:40:22 00:04:43:23 {\an4\pos(775,828)}- Hey, hey! 00:04:40:22 00:04:43:23 {\an4\pos(775,900)}- [ Laughing ] gets changed to 00:04:40:22 00:04:43:23 {\an4\pos(775,828)}- Hey, hey! while it should get changed to 00:04:40:22 00:04:43:23 {\an4\pos(775,828)}Hey, hey! - in case of .ass subs apparently brackets like [] or () sometimes arent applied in each line, but each block with same timestamps which belog together 00:29:38:23 00:29:41:11 {\an4\pos(1177,684)}[ Ship's Horn Blows 00:29:38:23 00:29:41:11 {\an4\pos(1178,756)}In Distance ] this get ignored by SHD removal (and "Fixing missing [ in line" only fixes the 2nd line, but doesnt list the first one for some reason), maybe these situations can be added to SHD removal as well in case of .ass subs. it might already get tricky now that implementing new rules could interfere with other rules
__________________
Laptop Lenovo Legion 5 17IMH05: i5-10300H, 16 GB Ram, NVIDIA GTX 1650 Ti (+ Intel UHD 630), Windows 10 x64, madVR (x64), MPC-HC (x64), LAV Filter (x64), XySubfilter (x64) (K-lite codec pack) Last edited by Thunderbolt8; 18th August 2014 at 22:08. |
20th August 2014, 16:21 | #234 | Link |
Registered User
Join Date: Nov 2005
Posts: 583
|
Greetings Nik. A few issues with BD sup rendering:
1. In a srt sub, if the italic tag is preceded by space after a line break, the placement of that line is off. 2. Can't seem to get the font formatting defined by AEGISUB style editor to work. Are these supported by SE? 3. Fade doesn't seem to work as well. Thanks for looking into these issues. |
24th August 2014, 20:33 | #235 | Link |
Registered User
Join Date: Sep 2006
Posts: 2,197
|
in which file are the user edited/added information of the "Remove interjections" list stored?
__________________
Laptop Lenovo Legion 5 17IMH05: i5-10300H, 16 GB Ram, NVIDIA GTX 1650 Ti (+ Intel UHD 630), Windows 10 x64, madVR (x64), MPC-HC (x64), LAV Filter (x64), XySubfilter (x64) (K-lite codec pack) |
24th August 2014, 21:55 | #236 | Link | |
Registered User
Join Date: Feb 2004
Location: Mars
Posts: 428
|
Quote:
@mariner: thx for the info about (1) italic tag is preceded by space after a line break... will be fixed in next update. (2) basic stuff like font style, color should work... (3) I don't know anything about fade. |
|
28th August 2014, 09:26 | #237 | Link |
Registered User
Join Date: Dec 2013
Posts: 631
|
Hi Nikse555
Is it possible to make SE show the subtitles as SUP preview in the videopreview window? Preferably with being able to adjust SUP settings (font, size, position etc.) for all - or selected only. I think I'm asking a lot here... cheers von Suppé |
28th August 2014, 20:13 | #238 | Link |
Registered User
Join Date: Sep 2006
Posts: 2,197
|
the "Fix common errors" window always opens on my primary screen, even though I have the program on my 2nd screen and dragged the window over already before. could you please fix that? other windows also open at that screen at which they have been closed down last.
__________________
Laptop Lenovo Legion 5 17IMH05: i5-10300H, 16 GB Ram, NVIDIA GTX 1650 Ti (+ Intel UHD 630), Windows 10 x64, madVR (x64), MPC-HC (x64), LAV Filter (x64), XySubfilter (x64) (K-lite codec pack) |
4th September 2014, 16:56 | #239 | Link |
Registered User
Join Date: Sep 2006
Posts: 2,197
|
I added "Ha!" to the remove interjections list, but subtitle lines just consisting of "Ha!" dont get removed by that. bug?
edit: well it works if I dont include the exclamation mark. edit²: but then again a line consisting of "- Ha!", resulting from a previous remove interjections run, does not get removed.
__________________
Laptop Lenovo Legion 5 17IMH05: i5-10300H, 16 GB Ram, NVIDIA GTX 1650 Ti (+ Intel UHD 630), Windows 10 x64, madVR (x64), MPC-HC (x64), LAV Filter (x64), XySubfilter (x64) (K-lite codec pack) Last edited by Thunderbolt8; 4th September 2014 at 17:03. |
|
|