Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
|
|
Thread Tools | Search this Thread | Display Modes |
27th December 2018, 06:38 | #1041 | Link |
Registered User
Join Date: Feb 2008
Posts: 15
|
there are issue with XySubFilter 3.1.0.746 BETA3 where last line of an external SSA subtitle is not displayed if it doesn't end with line break. in a text editor, this means SSA file must end with a blank/empty line
haven't test the latest version to see if it's fixed, but also don't see this fixed in the newer releases' Bug Fix section confirmed 3.1.0.752 also has the same behaviour Last edited by supercoolman; 27th December 2018 at 09:36. |
29th December 2018, 03:12 | #1042 | Link |
Registered User
Join Date: Jul 2008
Posts: 54
|
Is it normal that when i enable sub in video the color of the movie changed?
Default no sub https://imgur.com/oprrT9R With english sub selected https://imgur.com/SSo0l5f |
30th December 2018, 00:54 | #1043 | Link |
Broadband Junkie
Join Date: Oct 2005
Posts: 1,859
|
@supercoolman Thanks for reporting that. Looks like it is caused by a bug this Read Buffering commit written by the Aegisub author. Since Aegisub always adds a new line at end of file this must have been overlooked. I'll try to see if he's still around to push a fix.
@Mano That is a bug in madVR, I believe. XySubFilter only provides subtitles, it never touches the video. I seem to remember someone reporting a bug like that with HDR video in one of the madVR threads months ago, but if it still isn't fixed you should probably open a bug report so it isn't forgotten about. Last edited by cyberbeing; 30th December 2018 at 01:24. |
30th December 2018, 09:10 | #1044 | Link | |
Registered User
Join Date: Jan 2014
Posts: 2,314
|
Quote:
https://github.com/pinterf/xy-VSFilter/issues/1 https://github.com/pinterf/xy-VSFilt...2c7414fc5072f0 As I recall there had been other similar parts in the code but I could test and fix only this specific one. @cyberbeing: if the project is still somewhat live again, I'd recommend this x64 fix as well: https://github.com/pinterf/xy-VSFilt...2d32806f8c24cf |
|
31st December 2018, 21:15 | #1045 | Link |
Broadband Junkie
Join Date: Oct 2005
Posts: 1,859
|
Thanks pinterf, I'll merge those in. Looks like you only fixed it for SRT, I assume the same change could be used for SSA/ASS?
Test Build [previous 750 test build + pinterf SRT & x64 fixes + pinterf fix used for SSA/ASS (untested)] Any idea if your fix for the missing last line could be moved from STS.cpp to TextFile.cpp, since that is where the regression occurred? It would prevent the need to add that fix for every text subtitle format in STS.cpp, and simply things. The project is still pretty much dead, aside from minimal maintenance on my part. Last edited by cyberbeing; 1st January 2019 at 00:47. |
1st January 2019, 22:33 | #1046 | Link |
Registered User
Join Date: Feb 2008
Posts: 15
|
I have been manually fixing that (adding newlines) on all ASS subs over the years. just decided to bring it up. didn't know bug was filed on that already
btw/ot, what's going on with aegisub? is it in not, less or similarly active than XySubFilter ? |
2nd January 2019, 02:10 | #1047 | Link |
Broadband Junkie
Join Date: Oct 2005
Posts: 1,859
|
Pretty much, though back in June 2018 he did push out a new trunk build on his site with some fixes from his Github. With the original MPC-HC team dying off, and even Libass updating rather rarely nowadays, everything has sort of stagnated. Or rather the state of subtitle development has returned to the status quo from before we first released xy-VSFilter in 2011 which triggered a large peak in interest in the following years, so you could argue this is actually the normal state of things.
|
2nd January 2019, 13:55 | #1048 | Link | |
Registered User
Join Date: Jan 2014
Posts: 2,314
|
Quote:
|
|
2nd January 2019, 18:51 | #1049 | Link |
Registered User
Join Date: Feb 2008
Posts: 15
|
finishing OT...
I was wondering since this GitHub project has been getting commits, but not a single release since 2014 |
5th January 2019, 00:18 | #1050 | Link | |
Registered User
Join Date: Jul 2013
Posts: 5
|
Quote:
|
|
16th June 2019, 19:56 | #1052 | Link |
Registered User
Join Date: Feb 2008
Posts: 15
|
found another weird behaviour. when there are 2 external ASS subs do the following steps and XySubFilter will switch sub on its own
1. pause playback 2. make change or edit XySubFilter's current rendering subtitle 3. resume playback 4. XySubFilter automatically switch to the other subtitle 5. manually selecting the edited subtitle and XySubFilter happily use it without any error/issue this means there was no error, mistake or issue for the edited subtitle. not sure why XySubFilter would switch the rendering subtitle |
23rd June 2019, 09:18 | #1053 | Link |
Registered User
Join Date: Jun 2015
Posts: 22
|
Is lag at typesetting just par for the course or is my XySubFilter misconfigured? It even happens with the basic stuff Crunchyroll, and therefore Horriblesubs, has been doing lately.
MPC-BE 1.5.3 x64 + madvr + LAV filters + XySubFilter
__________________
Windows 10 // i7-8700k + GTX 1080 SLI // MPC-BE x64 + LAV + XySubFilter |
14th December 2019, 00:42 | #1055 | Link |
Registered User
Join Date: Jul 2013
Posts: 5
|
|
26th December 2019, 18:24 | #1057 | Link | |
Broadcast Encoder
Join Date: Nov 2013
Location: Royal Borough of Kensington & Chelsea, UK
Posts: 2,904
|
Quote:
|
|
27th December 2019, 11:15 | #1059 | Link |
Registered User
Join Date: Oct 2002
Location: France
Posts: 2,316
|
XP can still be targeted with VS 2017 and 2019 (in deprecated status for this last one), but, it's possible that there is some code, codec/display/etc... interface wich is not XP compatible anymore. So in that case, even if you build targeting XP, it will not make your program XP compatible.
__________________
My github. |
27th December 2019, 12:31 | #1060 | Link |
HeartlessS Usurer
Join Date: Dec 2009
Location: Over the rainbow
Posts: 10,980
|
FranceBB, just consider the plugin dead.
__________________
I sometimes post sober. StainlessS@MediaFire ::: AND/OR ::: StainlessS@SendSpace "Some infinities are bigger than other infinities", but how many of them are infinitely bigger ??? |
Thread Tools | Search this Thread |
Display Modes | |
|
|