Avisynth+

[LigH]

Fortunately, DosBox emulates GUS (Gravis Ultrasound) devices nicely.

[Stereodude]

Originally Posted by wonkey_monkey

Quick question: is the horizontally shifting chroma bug from <=2.61 fixed in Avisynth+?

http://avisynth.nl/index.php/Known_I...sitioning_Bugs

No, it's not (or at least something is still wrong with the chroma handling)

You can quickly test for it by doing an integer point resample modification to the chroma and back. It should be lossless, but using the built in avisynth+ functions it's not. Using avsresize (z.lib) it is lossless.

Lossless:
z_ConvertFormat(pixel_type="YUV422P10", resample_filter="point", colorspace_op="170m:601:170m:f=>170m:601:170m:f")
z_ConvertFormat(pixel_type="YV12", resample_filter="point", colorspace_op="170m:601:170m:f=>170m:601:170m:f")

not lossless
ConvertToYUV422(matrix="PC.601", chromaresample="point")
ConvertToYUV420(matrix="PC.601", chromaresample="point")

[real.finder]

can someone add HBD to http://avisynth.nl/index.php/MedianBlur2 and http://avisynth.nl/index.php/AddGrainC ?

they are very basic functions that needed in many scripts

[DJATOM]

AddGrain already have vapoursynth version, probably not that difficult to port back.

[real.finder]

Originally Posted by DJATOM

AddGrain already have vapoursynth version, probably not that difficult to port back.

so you will do it?

I kinda shy to ask pinterf since he already did many ports and work for avs

if not you then maybe jpsdr or MeteorRain

for MedianBlur2 there are also https://forum.doom9.org/showthread.p...20#post1810220

[StvG]

Originally Posted by real.finder

can someone add HBD to http://avisynth.nl/index.php/MedianBlur2 and http://avisynth.nl/index.php/AddGrainC ?

they are very basic functions that needed in many scripts

AddGrain port of the vs version.

[real.finder]

Originally Posted by StvG

AddGrain port of the vs version.

thanks, it work but even in 8 bit it darker (1/255) than the original input or old AddGrain

[real.finder]

so, anyone will pickup MedianBlur2?

[pinterf]

I'll check how difficult it is. If project can be done in a day then probably ok.

[mcjordan]

Pinterf, i have a try to compile your last build of AviSynthPlus (VC2019),
but several times I encounter the following messages:

Error C3447 third operand to the conditional operator ?: is of type 'void', but the second operand is neither a throw-expression nor of type 'void'
and also
C2440 'return': cannot convert from 'AVSMapValue' to 'AVSMapValue &'

It is critical? I read some things in the following forum:
https://cboard.cprogramming.com/c-pr...type-void.html
Thank you in advance and sorry for disturbance. I'm not deep familiar with C/C++ programming.

[pinterf]

Check it again please, work in progress.

[mcjordan]

Thank you. I'll try again later.

[mcjordan]

Also in strings.cpp ->
Warning C4996 'std::codecvt_utf8_utf16<wchar_t,1114111,(std::codecvt_mode)0>': warning STL4017: std::wbuffer_convert, std::wstring_convert, and the <codecvt> header (containing std::codecvt_mode, std::codecvt_utf8, std::codecvt_utf16, and std::codecvt_utf8_utf16) are deprecated in C++17. (The std::codecvt class template is NOT deprecated.) The C++ Standard doesn't provide equivalent non-deprecated functionality; consider using MultiByteToWideChar() and WideCharToMultiByte() from <Windows.h> instead. You can define _SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING or _SILENCE_ALL_CXX17_DEPRECATION_WARNINGS to acknowledge that you have received this warning.

and

error C2039: 'unique_ptr': is not a member of 'std'
message : see declaration of 'std'
syntax error: missing ';' before '<'
error C4430: missing type specifier - int assumed. Note: C++ does not support default-int

Sorry for double post.

[pinterf]

Put an
#include <memory>
in strings.h

rare case when gcc and clang was o.k., but msvc not.

[feisty2]

Originally Posted by pinterf

Put an
#include <memory>
in strings.h

rare case when gcc and clang was o.k., but msvc not.

you could probably write a very high level script-like API wrapper, like I recently did, if you wanna make the coding process painless for people that wish to write their own plugins but with little knowledge of C or C++

[mcjordan]

#include <memory>
in strings.h
works like a charm.

Thank you, Pinterf.

[pinterf]

Originally Posted by feisty2

you could probably write a very high level script-like API wrapper, like I recently did, if you wanna make the coding process painless for people that wish to write their own plugins but with little knowledge of C or C++

I enjoy your coding experiments despite the fact that sometimes I feel myself dummy and too old for those abstractions that are allowed by modern C++ syntax. I have the similar feelings when I'm looking into secrit-twc's repos who solves problems in two elegant lines which I'm doing with a half page of code. Probably my son will do it better than me (he's studying informatics), they had already C++ basics, C++11, 14 and 17 are covered by second half-year course, so he cannot help me right now in interpreting those magics you are doing.

[MeteorRain]

I'd really hope someone's gonna write a wrapper like what I did to make a plugin dual interface, but in a more elegant and clean way.

[MeteorRain]

I actually took some time to read F2's code. I'm impressed by how elegant it's done. In my dual interface framework I put wrapper as template parameter, while he put the filter engine as template parameter. Very interesting design.

Lots of features are not supported yet -- lots of C++20 things. So no MSVC at this point == no chance for AviSynth+ for Windows.

[feisty2]

Originally Posted by MeteorRain

Lots of features are not supported yet -- lots of C++20 things. So no MSVC at this point == no chance for AviSynth+ for Windows.

I actually successfully compiled GCC 10 (trunk ver) from the scratch in Cygwin for windows a few days ago. I'll admit that it was not a pleasant experience...