Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
|
![]() |
|
Thread Tools | Search this Thread | Display Modes |
![]() |
#941 | Link | ||
Broadcast Encoder
Join Date: Nov 2013
Location: Royal Borough of Kensington & Chelsea, UK
Posts: 2,565
|
Quote:
I don't have to do this anymore: Code:
#Hardsub 8bit s16 = last DitherPost (mode=-1) TextSub("Ep1.ass") #Overlay 8bit subs to 16bit video Dither_convert_8_to_16 () s16.Dither_limit_dif16 (last, thr=1.0, elast=2.0) ![]() Quote:
The dll calls DeleteProcThreadAttributeList and InitializeProcThreadAttributeList that are missing in the XP kernel. Last edited by FranceBB; 5th August 2018 at 01:53. |
||
![]() |
![]() |
![]() |
#943 | Link |
Broadcast Encoder
Join Date: Nov 2013
Location: Royal Borough of Kensington & Chelsea, UK
Posts: 2,565
|
That's weird, 'cause I tried to run it on an XP virtual machine just to be sure and it doesn't recognise the command "TextSub()" with the new DLL, 'cause it fails to load and when I opened it with Dependency Walker I noticed these two missing function calls.
(And by the way, I have all the C++ Redistributable on my VM 2005 - 2017 and it's an AVX2 capable CPU, although XP supports up to SSE4.2 only). |
![]() |
![]() |
![]() |
#945 | Link |
Registered User
Join Date: Dec 2002
Posts: 5,565
|
xy-vsfilter renders the subtitles at the video resolution. So if you want to increase quality you would have to upscale (at least the chroma) in the chain before the picture reaches xy-vsfilter.
But it is more straight-forward to use a subtitle renderer that renders at the display resolution to begin with like e.g. the internal subtitle renderer (ISR) of MPC-HC or XySubFilter. |
![]() |
![]() |
![]() |
#948 | Link | |
Soul Seeker
Join Date: Sep 2013
Location: Bulgaria
Posts: 627
|
Quote:
|
|
![]() |
![]() |
![]() |
#949 | Link |
Registered User
Join Date: Dec 2002
Posts: 5,565
|
Madshi released a fixed version for it. I think it's still not in pinterf's fork, though.
https://forum.doom9.org/showthread.p...84#post1839284 |
![]() |
![]() |
![]() |
#950 | Link | |
Soul Seeker
Join Date: Sep 2013
Location: Bulgaria
Posts: 627
|
Quote:
|
|
![]() |
![]() |
![]() |
#951 | Link |
Registered User
Join Date: Jan 2014
Posts: 2,239
|
New build, download v3.1.0.801
An issue with random x64 crashes was reported on git and it looked interesting enough ![]() Then I have found some "new" commits in the original rc4 branch, including the fix for italics issue, so I included them also. I hope they work, there are quite a few branches there. Note: as original authors have said, treat this version as a beta. Note2: I'm just a re-builder and not developer of the product. Use my build as-is. Warning: problems under xp reported, despite my v141_xp settings. Code:
v3.1.0.801 (20180904) - fix random crash in x64 build (address truncated to 32 bits, Rasterizer::Draw and Rasterizer::FillSolidRect were affected) - XySubFilter.DLL now compiled with v141_xp toolset instead of v141 (like VSFilter.DLL) - From upstream (madshi, Cyberbeing) - Fix a possible infinite loop in the Real Text subtitle parser on 64-bit - Fix external SRT subtitles with italic tag not being flagged as repositionable - Disable repositioning for SSA/ASS subtitles with default position level - Add setting to allow repositioning of SSA/ASS dialog Last edited by pinterf; 7th September 2018 at 10:12. Reason: xp warning |
![]() |
![]() |
![]() |
#952 | Link | |
Broadcast Encoder
Join Date: Nov 2013
Location: Royal Borough of Kensington & Chelsea, UK
Posts: 2,565
|
Quote:
None of your modified version work on XP, even though you compiled with v141_xp. I have all the C++ Redistributable installed, from 2005 to 2017, by the way. I tried with a simple script, but AVSPmod didn't recognize the command "TextSub" in the first place. ![]() When I tried to run it: ![]() So I tried to run AVSMeter and it reported "Invalid Access Memory Location (998)". ![]() I decided to investigate why and it seems that two kernel calls are missing in Windows XP: InitializeProcThreadAttributeList and DeleteProcThreadAttributeList. Unfortunately, these two functions have been introduced in Windows Vista. InitializeProcThreadAttributeList is a bool. It returns a zero value if it fails or a non-zero value if it succeeds. It has lpAttributeList (which is the attribute list and it can be NULL to determine the buffer size required to support the specified number of attributes), dwAttributeCount (which is the count of attributes to be added to the list), dwFlags (which is a reserved parameter and it must be zero) and lpSize. Code:
BOOL InitializeProcThreadAttributeList( LPPROC_THREAD_ATTRIBUTE_LIST lpAttributeList, DWORD dwAttributeCount, DWORD dwFlags, PSIZE_T lpSize ); Code:
void DeleteProcThreadAttributeList( LPPROC_THREAD_ATTRIBUTE_LIST lpAttributeList ); I took a look at Wine and it seems that they implemented the call, so I tried to take their implementation and use it as a wrapper to basically direct the call to it instead of to the kernel, but unfortunately it didn't work (I messed it up when I tried to adapt it, I'm 100% sure). Any thoughts? ![]() |
|
![]() |
![]() |
![]() |
#953 | Link |
Registered Developer
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,290
|
Going multiple levels down in Dependency Walker is not meaningful, since you cannot control what other DLLs use. You can only check what your own DLL imports directly, and if those are fine then thats not it. From the error it sounds like the DLL crashes on load, not that it fails to load due to missing symbols.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders |
![]() |
![]() |
![]() |
#954 | Link |
Registered User
Join Date: Jan 2014
Posts: 2,239
|
Don't know, what happens, all I have found is:
https://developercommunity.visualstu...-target-s.html And the DLLs were compiled with /MT instead of /MD, so no redistributables are needed. |
![]() |
![]() |
![]() |
#956 | Link |
Registered User
Join Date: Apr 2018
Posts: 1
|
Trying to open external PGS subtitles (whether autoloading or manual) results in my player freezing for extended periods of time, and when it does finally load the text is either greatly out of sync or don't display at all.
Muxing the subs into the video allows it to load correctly. The issue is also consistently reproducible when I extract subs from any video and try to load them externally. Is this a known issue with external PGS subs? |
![]() |
![]() |
![]() |
#958 | Link |
Soul Seeker
Join Date: Sep 2013
Location: Bulgaria
Posts: 627
|
Do the subtitle output options in XYVsfilter - YCbCr level range "auto" and YCbCr matrix should always be on "auto"? In the OSD when they are on auto it says Colorspace: TV BT.601(auto), if I set the matrix to "guess" it says TV BT.709 (Guessed). I watch only BT.709 content. Which option is the right one?
Last edited by Siso; 20th September 2018 at 18:36. |
![]() |
![]() |
![]() |
#959 | Link |
Registered User
Join Date: Oct 2012
Posts: 7,642
|
leave it at the default settings because this topic is very simple and very complicated at the same time.
the issue comes from the software creating the ASS sub titles usual aegisub which doesn'T really care about color matrix in the past and was using BT 601. the content you watch is not of important it is the ass sub colors relative to the video. it get's really complicated on how they fixed this issue. |
![]() |
![]() |
![]() |
#960 | Link | |
Soul Seeker
Join Date: Sep 2013
Location: Bulgaria
Posts: 627
|
Quote:
|
|
![]() |
![]() |
![]() |
Thread Tools | Search this Thread |
Display Modes | |
|
|