Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
27th November 2019, 17:56 | #101 | Link |
Registered User
Join Date: Jun 2014
Location: Marrakech, Morocco
Posts: 253
|
Hi justdan96, could you please hold to 2.6.15 as I will keep on submitting commits over the week-end for the additional UHD formats/fps.
Can anybody share the ExtensionData formatting info (Jdobbs ? Pelican ?) for HDR10+, Dolby Vision and SL-HDR so that we can incorporate it into .clpi/.mpls/.bdmv as required. Last edited by a5180007; 29th November 2019 at 12:09. |
28th November 2019, 18:28 | #103 | Link |
Registered User
Join Date: Aug 2016
Posts: 12
|
tsMuxer Open Source
I can see you guys are busy over at GitHub!
Before I dive in two questions: o Do you think any of the custom libraries you replaced with standard version would have included custom versions of named functions? o Is there a module/object interaction diagram or would it be simpler to just pull all source into an ide like visual studio and let it build one? Thanks! Last edited by Hart2hart; 28th November 2019 at 19:07. |
28th November 2019, 20:34 | #104 | Link | |
Moderator
Join Date: Oct 2001
Posts: 21,092
|
Quote:
Code:
00 00 00 38 Length of ExtensionData() 00 00 00 18 Data block start address 00 00 00 01 24 bits reserved followed by number_of_ext_data_entries (1) 00 03 00 05 ID1 (0x3) and ID2 (0x5) of the extension 00 00 00 18 ext_data_start_address 00 00 00 24 ext_data_length 00 00 00 20 length of following data (?) 01 00 00 00 10 00 00 00 HDR_DATA 24 bytes Example of HDR_DATA: 33 C2 86 C4 Master Display=G(13250,34500) 1D 4C 0B B8 B(7500,3000) 84 D0 3E 80 R(34000,16000) 3D 13 40 42 WP(15635,16450) 0F A0 00 32 L(40000000,50) = Mastering display luminance: min: 0.0050 cd/m2, max: 4000 cd/m2 = 4000/50 07 8D 02 C5 cll=1933,709 Dolby seems to use the same extension, not sure about SL-HDR. Here is the extension for index.bdmv Code:
00 00 00 20 Length of ExtensionData() 00 00 00 18 Data block start address 00 00 00 01 24 bits reserved followed by number_of_ext_data_entries (1) 00 03 00 01 ID1 (0x3) and ID2 (0x1) of the extension 00 00 00 18 ext_data_start_address 00 00 00 0C ext_data_length 00 00 00 08 I think this is length of following info 21 00 03 00 upper nibble of first byte is disc type (0x2 = BD25/50), not sure about 0x03* 00 00 00 00 seems to be reserved... *Made a correction to the index.bdmv extension data. I'd put a value of 0x20 at offset 24, and it should have been 0x21 [12/13/2019] In order to do dolby vision, TSMUXER will have to be modified so the stream id for the dolby vision extension stream is set to 4117 and an additional entry for dolby vision must be added to the STN_table() *Made a correction to the index.bdmv extension data. I'd put a value of 0x20 at offset 24, and it should have been 0x21 [Dec 13, 2019] Last edited by jdobbs; 13th December 2019 at 17:09. |
|
28th November 2019, 21:13 | #105 | Link | |
Registered User
Join Date: Jun 2019
Location: UK
Posts: 49
|
Quote:
https://github.com/justdan96/tsMuxer...a15072f17cf780 https://github.com/justdan96/tsMuxer...0d75cc53add9cc https://github.com/justdan96/tsMuxer...9ace39b8fc6cf1 There isn't a diagram currently. I just had a quick search around and it looks like maybe Doxygen can be used together with Graphviz to generate one. Something for me to think about! |
|
29th November 2019, 12:34 | #106 | Link |
Registered User
Join Date: Jun 2014
Location: Marrakech, Morocco
Posts: 253
|
@jdobbs thanks, this HDR metadata info is exactly what I was looking for!
Current progress: - The patch for changing BD version to 0300 has already been merged in the master; - The patch for setting coding_type to 0x24 has also already been merged in the master; - I've just submitted the patch for setting video_format to 8 for UHD; - Also bugs were corrected for frame size limitation, and for MP4/AAC and EAC3 bitrates and channels. @justdan96 tsMuxeR should now be able to author UHD but without HDR. The HDR modifs in .clpi, .mpls and .bdmv will require a bit of time, first I need to understand how to extract the HDR metadata info from the HEVC SEI. Let's say HDR (excl. Dolby Vision) will be my objective for 2.6.17... Last edited by a5180007; 29th November 2019 at 14:01. |
30th November 2019, 19:16 | #108 | Link |
Senior Member
Join Date: Apr 2004
Posts: 1,054
|
Hopefully there will be a reconsideration and 32 bit binaries can be built. One main way to capture transport streams from hardware is the 1394 firewire port. There are no Windows 64 bit drivers that work. Using a Windows 32 bit version is a must. Users don't want to capture on 1 PC and then transfer to stream to a second machine to mux.
Last edited by Video Dude; 30th November 2019 at 19:23. |
30th November 2019, 20:02 | #109 | Link |
SuperVirus
Join Date: Jun 2012
Location: Antarctic Japan
Posts: 1,397
|
32-bit binaries CAN be built. The problem is, justdan96 simply doesn't care about them. Also, his workflow became *nix-centric, which means even the Windows builds of tsMuxeR now require a posix-threaded compiler.
Last edited by filler56789; 30th November 2019 at 20:02. Reason: clarity |
30th November 2019, 22:52 | #110 | Link |
Registered User
Join Date: Jun 2014
Location: Marrakech, Morocco
Posts: 253
|
@xavery @justdan96 under Windows/MSVC I can't remove #include "stdafx.h" from textSubtitles.cpp without having 171 errors (!!), see file:
Error.Log.txt Any alternative to get rid of stdafx.h ? Edit : found the solution: actually the "rarely-used stuff from Windows headers" is still required i.e. we need to add #define WIN32_LEAN_AND_MEAN in textSubtitles.h Last edited by a5180007; 30th November 2019 at 23:38. |
2nd December 2019, 14:10 | #111 | Link |
Guest
Posts: n/a
|
That would be useful. On Linux, I found that the GUI worked fine but threw a series of errors upon first use, most of which seemed to relate to cosmetic aspects of the interface. (At the time, I was using 2.6.9 for reasons outlined earlier in the thread.)
|
2nd December 2019, 16:16 | #112 | Link |
Registered User
Join Date: Jun 2019
Location: UK
Posts: 49
|
I didn't think there would be much demand for 32-bit binaries, it does look like the demand is there so I'm pretty sure it would be easy enough to set up in CMake and I can just create a separate build.
Latest (64-bit) binaries for the CLI are available on GitHub, I'm still working on getting the GUI created automatically but I now know how I'll get tsMuxerGUI builds made for Linux and Windows so it's just MacOS where I need to do some more experimenting. Also I moved house over the weekend so things may be a bit slower the next couple of weeks while I get broadband set up. |
3rd December 2019, 21:03 | #114 | Link |
SuperVirus
Join Date: Jun 2012
Location: Antarctic Japan
Posts: 1,397
|
|
3rd December 2019, 23:03 | #115 | Link | |
Registered User
Join Date: Jun 2019
Location: UK
Posts: 49
|
Quote:
https://github.com/justdan96/tsMuxer |
|
3rd December 2019, 23:09 | #116 | Link | ||
SuperVirus
Join Date: Jun 2012
Location: Antarctic Japan
Posts: 1,397
|
Quote:
Quote:
|
||
4th December 2019, 12:03 | #118 | Link | |
Matroska find' ich toll
Join Date: Apr 2008
Posts: 1,412
|
Quote:
I'm mostly interested in demuxing. How good works the new tsMuxeR? Seamless branching disc's supported? Remove/Skip identical frames? I had read that the last old rev of tsMuxeR has issues with subtitle streams, this issues are fixed? E-AC3 EX support? |
|
5th December 2019, 10:54 | #120 | Link | ||
PgcEdit daemon
Join Date: Jul 2003
Posts: 7,483
|
Quote:
Quote:
Unfortunately, that bug has been added in v2.6.10 or v2.6.11, and I suppose that the latest closed source version (v2.6.12) has been used as the basis for the open source development. So, I suppose that the bug is still present. Unfortunately, that bug happens only in some relatively rare cases, and I don't remember what BD has caused it, so I have been unable to check if the bug is still present. I will try to find a good example and report it here, but that may take some time. Currently, if you want to be sure, I suggest to use v2.6.9 (although it has other bugs with the 3D-planes, not important for a 2D BD, but that should be fixed too). Or, use the new version and verify carefully the subtitles timings. If you find an example of bad timings, report it yourself, to help the developers.
__________________
r0lZ PgcEdit homepage (hosted by VideoHelp) BD3D2MK3D A tool to convert 3D blu-rays to SBS, T&B or FS MKV |
||
Thread Tools | Search this Thread |
Display Modes | |
|
|