Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
18th August 2010, 10:01 | #61 | Link |
Registered Developer
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,366
|
I did some research, and it seems that i can even get LATM AAC to work. It was only disabled in libavformat because libavcodec does not support it, but for example libfaad does.
This will have to wait until i setup my own ffmpeg repository with some custom patches though, so not 0.5 i'm afraid. I hope to get 0.5 out today with the fixes for TS durations, DVB subs, audio/subtitle stream switching, the "No Subtitles" option and possibly some other small things, but for now i'm still stuck at work, so don't hold your breath, it'll be a few hours. Speaking about AAC, does anyone know if the populare AAC decoders (ffdshow, mpc-hc internal, CoreAAC, ...) understand the HEAACWAVEFORMAT structure, or if they require everything being packed up in a WAVEFORMATEX? Edit: I just noticed that CoreAAC does not have LATM support yet, so i guess the monogram decoder will have to do. Last edited by nevcairiel; 18th August 2010 at 11:18. |
18th August 2010, 10:26 | #62 | Link |
MPC-HC Project Manager
Join Date: Mar 2007
Posts: 2,317
|
Yeah a custom ffmpeg "fork" sounds like a good idea, that way work can be done on the various patches we have/intend to create and clean them up if/before they are committed upstream
__________________
MPC-HC, an open source project everyone can improve. Want to help? Test Nightly Builds, submit patches or bugs and chat on IRC |
18th August 2010, 17:17 | #63 | Link | |
Registered User
Join Date: May 2007
Location: Norway
Posts: 192
|
Quote:
Take your time. Some of us have waited years for a project like this, so we can certainly wait a little longer. Thanks again. |
|
18th August 2010, 19:45 | #66 | Link |
Registered Developer
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,366
|
LAVFSplitter 0.5
- Fixed duration of MPEG-TS files - Added support for DVB subtitles - Fixed switching of Audio and Subtitle Streams - Added a "No Subtitles" Stream Download: 32-bit & 64-bit I hope the stream switching works properly now. The current approach works as follows: For Audio Streams, it deletes the current audio decoder, and lets the graph choose a new one, this ensures that we always get the right codec. For Subtitles (and Video), i just disconnect the filter, and let the graph reconnect itself. This seems to work fine so far. Feedback is appreciated. =) On the DVB Subs: It can't detect the difference between normal and hearing impaired yet, thats still on my list of things to do. Last edited by nevcairiel; 18th August 2010 at 19:49. |
18th August 2010, 19:57 | #69 | Link | ||
Registered User
Join Date: Oct 2004
Location: France
Posts: 567
|
Quote:
Quote:
|
||
18th August 2010, 20:01 | #70 | Link |
Registered Developer
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,366
|
Use one of the supported renderes, on XP that would be VMR9 (renderless), on Vista/7 EVR-CP, it should just magically work then. Additionally during playback check the "Play -> Subtitles" menu if Enabled is ticked
Oh, and the splitter currently defaults to the "No Subtitles" stream, so you need to turn them on, but i think you figured that out. |
18th August 2010, 20:22 | #71 | Link | |
Registered User
Join Date: Oct 2004
Location: France
Posts: 567
|
Quote:
|
|
18th August 2010, 20:50 | #72 | Link |
Registered User
Join Date: May 2007
Location: Norway
Posts: 192
|
Some quick v0.5 first impressions:
- MPC-HC crashes when seeking in TS. Not always, but often. Mostly tested with the "Henry IV" sample and is easily reproduced with that sample on my system, but also seen with other samples. - When enabling DVB-subs in "John Adams" sample, the video freezes. Don't know if this is related to the missing audio support. - When enabling DVB-subs in "Henry IV" sample, quick video audio freeze, but then resumes and works, so I guess that is expected with the graph reconnecting on change. Would be ideal if it could be enabled seamlessly, but it's probably no big deal if it stays like this. - TS duration is better (in most cases), but still not OK. HD sample duration is very wrong. I have another HD, sample here which doesn't play at all now, but the previously uploaded "Gossip Girl" HD sample (which is really just over a minute long and was reported as over an hour long in v0.3) is now reported as over 7 hours long in v0.5, but it plays. I don't think there is any point in uploading the other HD sample that doesn't play at all anymore in case it's duration related, and you can see the duration problem in the "Gossip Girl" sample as well. |
18th August 2010, 20:55 | #73 | Link | ||
Registered Developer
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,366
|
Quote:
Edit: I just noticed that for some reason the internal mpeg2 decoder doesnt even connect to the stream in the Henry IV sample. Another thing to check out. Quote:
Again, what filters? Last edited by nevcairiel; 18th August 2010 at 21:00. |
||
18th August 2010, 20:57 | #75 | Link | ||
Registered User
Join Date: Oct 2004
Location: France
Posts: 567
|
Quote:
Quote:
Last edited by Underground78; 18th August 2010 at 21:05. |
||
18th August 2010, 21:06 | #76 | Link | |
Registered User
Join Date: May 2007
Location: Norway
Posts: 192
|
With the "John Adams" sample when I first open it, I get a warning about missing audio codec. I click that away and it starts playing (with no audio obviously and with wrong AR). If I then press stop, and play again, it remains frozen. Does that happen with you? This also happens to me with the internal splitter, but not with Haali (stop and play works with Haali).
I'm using Microsoft Win7 decoder (preferred in MPC-HC). Changing from EVR Sync to EVR Custom didn't seem to change anything. Quote:
Last edited by Ger; 18th August 2010 at 21:21. |
|
18th August 2010, 21:13 | #77 | Link | |
Registered Developer
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,366
|
Quote:
Actually, the AR is correct with ffdshow as well. The small freeze on stream switches cannot be avoided, its here to stay. Comparing to VLC on this matter is pointless, as the freeze is a result of Direct Show interaction Edit: I see the freeze issue with the MS thing as well. |
|
18th August 2010, 22:15 | #79 | Link | |
Registered User
Join Date: May 2007
Location: Norway
Posts: 192
|
Quote:
All my crashes on skipping are in MPEG-2 files, so I guess they must all have been with ffdshow as the video decoder then. Tried both ffdshow and internal for MPEG audio, and crash with both. H264 still connects to whatever I set to preferred. If I missed any questions, ask again. I hope I've answered everything. Edit: To reproduce the crash, try clicking on different parts of the seek bar in quick succession with MPEG-2 TS samples with ffdshow for video. CTRL-LEFT and CTRL-RIGHT (I think those are the original shortcuts in MPC-HC for jumping a few seconds back/forward) also causes the crash, especially when done in quick succession. I've changed mine to just left/right arrow like in other players so I'm not 100 % sure what the default shortcut is anymore. Last edited by Ger; 18th August 2010 at 22:30. |
|
18th August 2010, 22:23 | #80 | Link |
4:2:0 hater
Join Date: Apr 2008
Posts: 1,302
|
No subtitles option, subtitle and audio switching working like a charm, good work.
Minor things I noticed: - Seeking seems a bit slower than Haali/Gabest, specially with high bitrate Blu-ray content where there's a lot to decode if you don't seek to an I-frame. Same with stream switching, a bit slower. Maybe Haali doesn't reconstruct the entire graph? - I'd put the no subtitles option always at the bottom of the subtitle streams list, instead of at the top. - There's nothing in MPC's Navigate -> Audio Language -> ??. Same with subtitles. ffdshow detects the stuff though (it uses IAMStreamSelect). |
Tags |
decoders, directshow, filters, splitter |
Thread Tools | Search this Thread |
Display Modes | |
|
|